* [PATCH] ASoC: fsl_ssi: Fixed wrong printf format identifier
@ 2014-01-07 6:04 Alexander Shiyan
2014-01-07 10:08 ` [alsa-devel] " Fabio Estevam
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Shiyan @ 2014-01-07 6:04 UTC (permalink / raw)
To: alsa-devel
Cc: Alexander Shiyan, Liam Girdwood, Takashi Iwai, Timur Tabi,
Jaroslav Kysela, Mark Brown, linuxppc-dev
sound/soc/fsl/fsl_ssi.c: In function 'fsl_ssi_probe':
sound/soc/fsl/fsl_ssi.c:1180:6: warning: format '%d' expects argument
of type 'int', but argument 3 has type 'long int' [-Wformat=]
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
sound/soc/fsl/fsl_ssi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index 3d74477a..c9d567c 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -1192,7 +1192,7 @@ static int fsl_ssi_probe(struct platform_device *pdev)
*/
ssi_private->baudclk = devm_clk_get(&pdev->dev, "baud");
if (IS_ERR(ssi_private->baudclk))
- dev_warn(&pdev->dev, "could not get baud clock: %d\n",
+ dev_warn(&pdev->dev, "could not get baud clock: %ld\n",
PTR_ERR(ssi_private->baudclk));
else
clk_prepare_enable(ssi_private->baudclk);
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: Fixed wrong printf format identifier
2014-01-07 6:04 [PATCH] ASoC: fsl_ssi: Fixed wrong printf format identifier Alexander Shiyan
@ 2014-01-07 10:08 ` Fabio Estevam
2014-01-07 11:11 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2014-01-07 10:08 UTC (permalink / raw)
To: Alexander Shiyan
Cc: alsa-devel@alsa-project.org, Takashi Iwai, Liam Girdwood,
Timur Tabi, Mark Brown, linuxppc-dev@lists.ozlabs.org
On Tue, Jan 7, 2014 at 4:04 AM, Alexander Shiyan <shc_work@mail.ru> wrote:
> sound/soc/fsl/fsl_ssi.c: In function 'fsl_ssi_probe':
> sound/soc/fsl/fsl_ssi.c:1180:6: warning: format '%d' expects argument
> of type 'int', but argument 3 has type 'long int' [-Wformat=]
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
I have sent the same fix as well as I haven't seen your patch before I
submitted mine.
It is usually a good idea to specify in the commit log what was the
commit that caused the warning.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: Fixed wrong printf format identifier
2014-01-07 10:08 ` [alsa-devel] " Fabio Estevam
@ 2014-01-07 11:11 ` Mark Brown
0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-01-07 11:11 UTC (permalink / raw)
To: Fabio Estevam
Cc: alsa-devel@alsa-project.org, Alexander Shiyan, Takashi Iwai,
Liam Girdwood, Timur Tabi, linuxppc-dev@lists.ozlabs.org
[-- Attachment #1: Type: text/plain, Size: 187 bytes --]
On Tue, Jan 07, 2014 at 08:08:14AM -0200, Fabio Estevam wrote:
> I have sent the same fix as well as I haven't seen your patch before I
> submitted mine.
I saw Fabio's patch first too.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-07 11:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-07 6:04 [PATCH] ASoC: fsl_ssi: Fixed wrong printf format identifier Alexander Shiyan
2014-01-07 10:08 ` [alsa-devel] " Fabio Estevam
2014-01-07 11:11 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).