From: Scott Wood <scottwood@freescale.com>
To: Wang Dongsheng-B40534 <Dongsheng.Wang@freescale.com>
Cc: "anton@enomsg.org" <anton@enomsg.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Zhao Chenhui-B35336 <chenhui.zhao@freescale.com>
Subject: Re: [PATCH 3/3] powerpc/fsl: Use the new interface to save or restore registers
Date: Wed, 15 Jan 2014 21:15:43 -0600 [thread overview]
Message-ID: <1389842143.24905.195.camel@snotra.buserror.net> (raw)
In-Reply-To: <93a6a30cd8d240109405d45c8e143dea@BN1PR03MB188.namprd03.prod.outlook.com>
On Tue, 2014-01-14 at 20:57 -0600, Wang Dongsheng-B40534 wrote:
>
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Wednesday, January 15, 2014 7:30 AM
> > To: Wang Dongsheng-B40534
> > Cc: benh@kernel.crashing.org; Zhao Chenhui-B35336; anton@enomsg.org; linuxppc-
> > dev@lists.ozlabs.org
> > Subject: Re: [PATCH 3/3] powerpc/fsl: Use the new interface to save or restore
> > registers
> >
> > On Tue, 2014-01-14 at 15:59 +0800, Dongsheng Wang wrote:
> > > From: Wang Dongsheng <dongsheng.wang@freescale.com>
> > >
> > > Use fsl_cpu_state_save/fsl_cpu_state_restore to save/restore registers.
> > > Use the functions to save/restore registers, so we don't need to
> > > maintain the code.
> > >
> > > Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com>
> >
> > Is there any functional change with this patchset (e.g. suspend
> > supported on chips where it wasn't before), or is it just cleanup? A
> > cover letter would be useful to describe the purpose of the overall
> > patchset when it isn't obvious.
> >
>
> Yes, just cleanup..
It seems to be introducing complexity rather than removing it. Is this
cleanup needed to prepare for adding new functionality?
Plus, I'm skeptical that this is functionally equivalent. It looks like
the new code saves a lot more than the old code does. Why?
> > > +
> > > + /* Restore base register */
> > > + li r4, 0
> > > + bl fsl_cpu_state_restore
> >
> > Why are you calling anything with "fsl" in the name from code that is
> > supposed to be for all booke?
> >
> E200, E300 not support.
> Support E500, E500v2, E500MC, E5500, E6500.
>
> Do you have any suggestions about this?
What about non-FSL booke such as 44x?
Or if this file never supported 44x, rename it appropriately.
-Scott
next prev parent reply other threads:[~2014-01-16 3:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 7:59 [PATCH 1/3] powerpc/fsl: add E500MC and E5500 PVR define Dongsheng Wang
2014-01-14 7:59 ` [PATCH 2/3] powerpc/85xx: Provide two functions to save/restore the core registers Dongsheng Wang
2014-01-14 23:50 ` Scott Wood
2014-01-15 3:30 ` Dongsheng.Wang
2014-01-16 3:17 ` Scott Wood
2014-01-20 6:03 ` Dongsheng.Wang
2014-01-21 1:06 ` Scott Wood
2014-01-21 2:43 ` Dongsheng.Wang
2014-01-23 0:50 ` Scott Wood
2014-01-23 2:49 ` Dongsheng.Wang
2014-01-23 16:22 ` Scott Wood
2014-01-14 7:59 ` [PATCH 3/3] powerpc/fsl: Use the new interface to save or restore registers Dongsheng Wang
2014-01-14 23:30 ` Scott Wood
2014-01-15 2:57 ` Dongsheng.Wang
2014-01-16 3:15 ` Scott Wood [this message]
2014-01-20 5:57 ` Dongsheng.Wang
2014-01-22 20:34 ` Scott Wood
2014-01-23 3:00 ` Dongsheng.Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389842143.24905.195.camel@snotra.buserror.net \
--to=scottwood@freescale.com \
--cc=Dongsheng.Wang@freescale.com \
--cc=anton@enomsg.org \
--cc=chenhui.zhao@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).