Re: [PATCH 3/4 v2]powerpc/fsl-booke: Add support for T2080/T2081 SoC

[Scott Wood <scottwood@freescale.com>]

On Thu, 2014-01-16 at 18:02 +0800, Shengzhou Liu wrote:
> +	cpc: l3-cache-controller@10000 {
> +		compatible = "cache";
> +		reg = <0x10000 0x1000
> +		       0x11000 0x1000
> +		       0x12000 0x1000>;
> +		interrupts = <16 2 1 27
> +			      16 2 1 26
> +			      16 2 1 25>;
> +	};

Where's the specific compatible for this node?

> +       corenet-cf@18000 {
> +               compatible = "fsl,corenet2-cf";
> +               reg = <0x18000 0x1000>;
> +               interrupts = <16 2 1 31>;
> +               fsl,ccf-num-csdids = <32>;
> +               fsl,ccf-num-snoopids = <32>;
> +       };

"fsl,corenet2-cf" doesn't appear in any other device tree nor in any
binding.

> +	clockgen: global-utilities@e1000 {
> +		compatible = "fsl,qoriq-clockgen-2.0", "fixed-clock";
> +		reg = <0xe1000 0x1000>;
> +		clock-output-names = "sysclk";
> +		#clock-cells = <0>;

Please update this according to v9 of the clock binding:
In particular, sysclk goes in its own node, and compatible strings have
changed.

> +	rcpm: global-utilities@e2000 {
> +		compatible = "fsl,qoriq-rcpm-2.0";
> +		reg = <0xe2000 0x1000>;
> +	};

compatible = "fsl,t2080-rcpm-2.0", "fsl,qoriq-rcpm-2.0";

-Scott