From: Geoff Levand <geoff@infradead.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/73] powerpc: use device_initcall for registering rtc devices
Date: Tue, 21 Jan 2014 15:48:05 -0800 [thread overview]
Message-ID: <1390348085.5027.18.camel@smoke> (raw)
In-Reply-To: <1390339396-3479-11-git-send-email-paul.gortmaker@windriver.com>
Hi Paul,
On Tue, 2014-01-21 at 16:22 -0500, Paul Gortmaker wrote:
> Currently these two RTC devices are in core platform code
> where it is not possible for them to be modular. It will
> never be modular, so using module_init as an alias for
> __initcall can be somewhat misleading.
>
> arch/powerpc/kernel/time.c | 2 +-
> arch/powerpc/platforms/ps3/time.c | 3 +--
> 2 files changed, 2 insertions(+), 3 deletions(-)
I tested the PS3 part of this patch and it seems to work OK.
Acked-by: Geoff Levand <geoff@infradead.org>
next prev parent reply other threads:[~2014-01-21 23:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 21:22 [PATCH RFC 00/73] tree-wide: clean up some no longer required #include <linux/init.h> Paul Gortmaker
2014-01-21 21:22 ` [PATCH 10/73] powerpc: use device_initcall for registering rtc devices Paul Gortmaker
2014-01-21 23:48 ` Geoff Levand [this message]
2014-01-22 2:26 ` Paul Gortmaker
2014-01-21 21:22 ` [PATCH 11/73] powerpc: book3s KVM can be modular so it should use module.h Paul Gortmaker
2014-01-21 21:22 ` [PATCH 12/73] powerpc: kvm e500/44x is not modular, so don't use module_init Paul Gortmaker
2014-01-21 22:23 ` Paul Gortmaker
2014-01-21 21:22 ` [PATCH 13/73] powerpc: use subsys_initcall for Freescale Local Bus Paul Gortmaker
2014-01-21 21:22 ` [PATCH 14/73] powerpc: don't use module_init for non-modular core hugetlb code Paul Gortmaker
2014-01-21 21:22 ` [PATCH 15/73] powerpc: don't use module_init in non-modular 83xx suspend code Paul Gortmaker
2014-01-21 21:22 ` [PATCH 39/73] powerpc: delete another unrequired instance of <linux/init.h> Paul Gortmaker
2014-01-21 21:23 ` [PATCH 66/73] drivers/macintosh: delete non-required instances of include <linux/init.h> Paul Gortmaker
2014-01-22 7:00 ` [PATCH RFC 00/73] tree-wide: clean up some no longer required #include <linux/init.h> Stephen Rothwell
2014-01-23 0:38 ` Paul Gortmaker
2014-01-28 3:13 ` Benjamin Herrenschmidt
2014-01-28 16:21 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390348085.5027.18.camel@smoke \
--to=geoff@infradead.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paul.gortmaker@windriver.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).