From: Scott Wood <scottwood@freescale.com>
To: Tang Yuantian-B29983 <Yuantian.Tang@freescale.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Kushwaha Prabhakar-B32579 <prabhakar@freescale.com>
Subject: Re: [PATCH] clk: corenet: Update the clock bindings
Date: Thu, 23 Jan 2014 20:35:34 -0600 [thread overview]
Message-ID: <1390530934.24905.639.camel@snotra.buserror.net> (raw)
In-Reply-To: <a0800d606e364b5980fe5c17efca9d9e@BL2PR03MB115.namprd03.prod.outlook.com>
On Thu, 2014-01-23 at 20:33 -0600, Tang Yuantian-B29983 wrote:
> > > > Instead, how about a note like this near the top of the file:
> > > >
> > > > All references to "1.0" and "2.0" refer to the QorIQ chassis version
> > > > to which the chip complies.
> > > >
> > > > Chassis Version Example Chips
> > > > --------------- -------------
> > > > 1.0 p4080, p5020, p5040
> > > > 2.0 t4240, b4860, t1040
> > > >
> > > Better, I will update.
> > >
> > > >
> > > > BTW, this binding and the associated driver really should be called
> > > > "qoriq-clock", not "corenet-clock". This would match the compatible
> > > > string, and it doesn't really have much to do with corenet (which is
> > > > part of the QorIQ chassis v1 and v2, but not *this* part). Do you
> > > > know if the chassis v3 clock interface will be similar enough to
> > share a driver?
> > > >
> > > Doesn't QorIQ include some low-end socs, like p1022, p1020?
> >
> > Yes, but those aren't "QorIQ Chassis 1.0" or "QorIQ Chassis 2.0".
> > They're mpc85xx-family chips.
> >
> > In any case, if "qoriq" makes sense for the compatible, I don't see why
> > it doesn't make sense for the driver.
> >
> So, "Corenet" is appropriate for driver.
> If something should change, that must be compatible string.
No. Corenet is a bus interconnect, not a chip family (despite abuse of
the name in other contexts in Linux/U-Boot). And the binding with qoriq
has already been accepted.
-Scott
next prev parent reply other threads:[~2014-01-24 2:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 2:02 [PATCH] clk: corenet: Update the clock bindings Tang Yuantian
2014-01-23 0:44 ` Scott Wood
2014-01-23 2:47 ` Yuantian Tang
2014-01-23 21:03 ` Scott Wood
2014-01-24 2:33 ` Yuantian Tang
2014-01-24 2:35 ` Scott Wood [this message]
2014-01-24 2:46 ` Yuantian Tang
2014-01-24 2:47 ` Scott Wood
2014-01-24 3:05 ` Yuantian Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390530934.24905.639.camel@snotra.buserror.net \
--to=scottwood@freescale.com \
--cc=Yuantian.Tang@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=prabhakar@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).