From: Nicolas Pitre <nicolas.pitre@linaro.org>
To: Russell King <linux@arm.linux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mundt <lethal@linux-sh.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/9] idle: move the cpuidle entry point to the generic idle loop
Date: Mon, 27 Jan 2014 01:08:19 -0500 [thread overview]
Message-ID: <1390802904-28399-5-git-send-email-nicolas.pitre@linaro.org> (raw)
In-Reply-To: <1390802904-28399-1-git-send-email-nicolas.pitre@linaro.org>
In order to integrate cpuidle with the scheduler, we must have a better
proximity in the core code with what cpuidle is doing and not delegate
such interaction to arch code.
Architectures implementing arch_cpu_idle() should simply enter
a cheap idle mode in the absence of a proper cpuidle driver.
Signed-off-by: Nicolas Pitre <nico@linaro.org>
---
kernel/cpu/idle.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/cpu/idle.c b/kernel/cpu/idle.c
index 4e327e211b..a6f40ad9f8 100644
--- a/kernel/cpu/idle.c
+++ b/kernel/cpu/idle.c
@@ -3,6 +3,7 @@
*/
#include <linux/sched.h>
#include <linux/cpu.h>
+#include <linux/cpuidle.h>
#include <linux/tick.h>
#include <linux/mm.h>
#include <linux/stackprotector.h>
@@ -94,7 +95,8 @@ static void cpu_idle_loop(void)
if (!current_clr_polling_and_test()) {
stop_critical_timings();
rcu_idle_enter();
- arch_cpu_idle();
+ if (cpuidle_idle_call())
+ arch_cpu_idle();
WARN_ON_ONCE(irqs_disabled());
rcu_idle_exit();
start_critical_timings();
--
1.8.4.108.g55ea5f6
next prev parent reply other threads:[~2014-01-27 6:24 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-27 6:08 [PATCH 0/9] setting the table for integration of cpuidle with the scheduler Nicolas Pitre
2014-01-27 6:08 ` [PATCH 1/9] ARM: get rid of arch_cpu_idle_prepare() Nicolas Pitre
2014-01-27 8:22 ` Daniel Lezcano
2014-01-27 16:07 ` Russell King - ARM Linux
2014-01-27 17:12 ` Daniel Lezcano
2014-01-27 17:21 ` Russell King - ARM Linux
2014-01-27 17:30 ` Daniel Lezcano
2014-01-27 17:35 ` Peter Zijlstra
2014-01-27 12:45 ` Russell King - ARM Linux
2014-01-27 15:45 ` Nicolas Pitre
2014-01-27 16:06 ` Russell King - ARM Linux
2014-01-27 17:36 ` Nicolas Pitre
2014-01-27 6:08 ` [PATCH 2/9] ARM64: " Nicolas Pitre
2014-01-27 8:23 ` Daniel Lezcano
2014-01-27 15:43 ` Catalin Marinas
2014-01-27 15:51 ` Nicolas Pitre
2014-01-27 15:57 ` Catalin Marinas
2014-01-27 6:08 ` [PATCH 3/9] idle: no more arch_cpu_idle_prepare() users Nicolas Pitre
2014-01-27 8:24 ` Daniel Lezcano
2014-01-27 6:08 ` Nicolas Pitre [this message]
2014-01-27 8:32 ` [PATCH 4/9] idle: move the cpuidle entry point to the generic idle loop Daniel Lezcano
2014-01-27 6:08 ` [PATCH 5/9] ARM: remove redundant cpuidle_idle_call() Nicolas Pitre
2014-01-27 8:33 ` Daniel Lezcano
2014-01-27 6:08 ` [PATCH 6/9] PPC: " Nicolas Pitre
2014-01-27 8:35 ` Daniel Lezcano
2014-01-27 11:59 ` Preeti U Murthy
2014-01-27 6:08 ` [PATCH 7/9] SH: " Nicolas Pitre
2014-01-27 8:35 ` Daniel Lezcano
2014-01-27 6:08 ` [PATCH 8/9] X86: " Nicolas Pitre
2014-01-27 8:43 ` Daniel Lezcano
2014-01-27 6:08 ` [PATCH 9/9] cpu/idle.c: move to sched/idle.c Nicolas Pitre
2014-01-27 12:47 ` [PATCH 0/9] setting the table for integration of cpuidle with the scheduler Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390802904-28399-5-git-send-email-nicolas.pitre@linaro.org \
--to=nicolas.pitre@linaro.org \
--cc=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=lethal@linux-sh.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).