Re: [PATCH 1/2][v7] driver/memory:Move Freescale IFC driver to a common driver

[Scott Wood <scottwood@freescale.com>]

On Thu, 2014-01-30 at 21:23 -0600, Kushwaha Prabhakar-B32579 wrote:
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Friday, January 31, 2014 3:01 AM
> > To: Kushwaha Prabhakar-B32579
> > Cc: linuxppc-dev@lists.ozlabs.org
> > Subject: Re: [PATCH 1/2][v7] driver/memory:Move Freescale IFC driver to a common
> > driver
> > 
> > On Tue, 2014-01-28 at 10:59 +0530, Prabhakar Kushwaha wrote:
> > >  Freescale IFC controller has been used for mpc8xxx. It will be used
> > > for ARM-based SoC as well. This patch moves the driver to
> > > driver/memory  and fix the header file includes.
> > >
> > >  Also remove module_platform_driver() and  instead call
> > >  platform_driver_register() from subsys_initcall() to make sure this
> > > module  has been loaded before MTD partition parsing starts.
> > >
> > > Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> > > Acked-by: Arnd Bergmann <arnd@arndb.de>
> > 
> > When did Arnd ack this?  Especially in v7 form... and I don't see him on CC.
> > 
> > > +config FSL_IFC
> > > +	bool "Freescale Integrated Flash Controller"
> > > +	depends on FSL_SOC
> > > +	help
> > > +	  This driver is for the Integrated Flash Controller Controller(IFC)
> > 
> > Controller Controller?
> 
> I will fix it
> 
> > 
> > > +	  module available in Freescale SoCs. This controller allows to handle
> > flash
> > > +	  devices such as NOR, NAND, FPGA and ASIC etc
> > 
> > FPGA and ASIC are not (necessarily) flash devices.
> > 
> 
> Yes it true. 
> I am not sure this folder is only for flash controller.
> I can see references of FPGA, SRAM in same Kconfigs. 

Right, just fix the help text.
s/handle flash devices/handle devices/

-Scott