From: Gavin Shan <shangw@linux.vnet.ibm.com>
To: linuxppc-dev@ozlabs.org
Cc: Gavin Shan <shangw@linux.vnet.ibm.com>
Subject: [PATCH v3 0/5] EEH improvement
Date: Tue, 25 Feb 2014 15:28:33 +0800 [thread overview]
Message-ID: <1393313318-6341-1-git-send-email-shangw@linux.vnet.ibm.com> (raw)
The series of patches intends to improve reliability of EEH on PowerNV
platform. First all, we have had multiple duplicate states (flags) for
PHB and PE, so we remove those duplicate states to simplify the code.
Besides, we had corrupted PHB diag-data for case of frozen PE. In order
to solve the problem, we introduce eeh_ops->event() and notifications
are sent from EEH core to (PowerNV) platform on creating or destroying
PE instance so that we can allocate or free PHB diag-data backend. Then
we cache the PHB diag-data on the first call to eeh_ops->get_state()
and dump it afterwards, which helps to get correct PHB diag-data.
With the patchset applied, we never dump PHB diag-data for INF errors.
Instead, we just maintain statistics in /proc/powerpc/eeh_inf_err. Also,
we changed the PHB diag-data dump format for a bit to have multiple
fields per line and omits the line with all zero'd fields as Ben suggested.
v2 -> v3:
* We don't cache the PHB diag-data, instead we just grab and
dump PHB diag-data on the first catch-up to avoid broken
PHB diag-data.
v1 -> v2:
* Amending commit logs
* Support eeh_ops->event() and maintain PHB diag-data on basis
of PE instance
* When dumping PHB diag-data, to replace "-" with "00000000" and
omit the line if the fields of it are all zeros.
---
arch/powerpc/include/asm/eeh.h | 1 -
arch/powerpc/kernel/eeh.c | 10 +---
arch/powerpc/kernel/eeh_driver.c | 10 ++--
arch/powerpc/platforms/powernv/eeh-ioda.c | 137 ++++++++++++++++++++--------------------------
arch/powerpc/platforms/powernv/pci.c | 228 ++++++++++++++++++++++++++++++++++++++++++---------------------------
arch/powerpc/platforms/powernv/pci.h | 8 +--
6 files changed, 195 insertions(+), 199 deletions(-)
Thanks,
Gavin
next reply other threads:[~2014-02-25 7:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 7:28 Gavin Shan [this message]
2014-02-25 7:28 ` [PATCH 1/5] powerpc/eeh: Remove EEH_PE_PHB_DEAD Gavin Shan
2014-02-25 7:28 ` [PATCH 2/5] powerpc/powernv: Remove PNV_EEH_STATE_REMOVED Gavin Shan
2014-02-25 7:28 ` [PATCH 3/5] powerpc/powernv: Move PNV_EEH_STATE_ENABLED around Gavin Shan
2014-02-25 7:28 ` [PATCH 4/5] powerpc/powernv: Dump PHB diag-data immediately Gavin Shan
2014-02-25 7:28 ` [PATCH 5/5] powerpc/powernv: Refactor PHB diag-data dump Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393313318-6341-1-git-send-email-shangw@linux.vnet.ibm.com \
--to=shangw@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).