linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Cody P Schafer <cody@linux.vnet.ibm.com>
To: Linux PPC <linuxppc-dev@lists.ozlabs.org>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	Ingo Molnar <mingo@redhat.com>, Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Peter Zijlstra <peterz@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Michael Ellerman <michael@ellerman.id.au>,
	scottwood@freescale.com, Cody P Schafer <cody@linux.vnet.ibm.com>
Subject: [PATCH v4 03/11] perf: provide a common perf_event_nop_0() for use with .event_idx
Date: Wed,  5 Mar 2014 16:01:02 -0800	[thread overview]
Message-ID: <1394064082-6242-4-git-send-email-cody@linux.vnet.ibm.com> (raw)
In-Reply-To: <1394064082-6242-1-git-send-email-cody@linux.vnet.ibm.com>

Rather an having every pmu that needs a function that just returns 0 for
.event_idx define their own copy, reuse the one in kernel/events/core.c.

Rename from perf_swevent_event_idx() because we're no longer using it
for just software events. Naming is based on the perf_pmu_nop_*()
functions.

Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>
---
 include/linux/perf_event.h |  1 +
 kernel/events/core.c       | 10 +++++-----
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index 5c12009..23da668 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -560,6 +560,7 @@ extern void perf_pmu_migrate_context(struct pmu *pmu,
 extern u64 perf_event_read_value(struct perf_event *event,
 				 u64 *enabled, u64 *running);
 
+extern int perf_event_nop_0(struct perf_event *event);
 
 struct perf_sample_data {
 	u64				type;
diff --git a/kernel/events/core.c b/kernel/events/core.c
index fa0b2d4..16bf7c2 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -5816,7 +5816,7 @@ static int perf_swevent_init(struct perf_event *event)
 	return 0;
 }
 
-static int perf_swevent_event_idx(struct perf_event *event)
+int perf_event_nop_0(struct perf_event *event)
 {
 	return 0;
 }
@@ -5831,7 +5831,7 @@ static struct pmu perf_swevent = {
 	.stop		= perf_swevent_stop,
 	.read		= perf_swevent_read,
 
-	.event_idx	= perf_swevent_event_idx,
+	.event_idx	= perf_event_nop_0,
 };
 
 #ifdef CONFIG_EVENT_TRACING
@@ -5950,7 +5950,7 @@ static struct pmu perf_tracepoint = {
 	.stop		= perf_swevent_stop,
 	.read		= perf_swevent_read,
 
-	.event_idx	= perf_swevent_event_idx,
+	.event_idx	= perf_event_nop_0,
 };
 
 static inline void perf_tp_register(void)
@@ -6177,7 +6177,7 @@ static struct pmu perf_cpu_clock = {
 	.stop		= cpu_clock_event_stop,
 	.read		= cpu_clock_event_read,
 
-	.event_idx	= perf_swevent_event_idx,
+	.event_idx	= perf_event_nop_0,
 };
 
 /*
@@ -6257,7 +6257,7 @@ static struct pmu perf_task_clock = {
 	.stop		= task_clock_event_stop,
 	.read		= task_clock_event_read,
 
-	.event_idx	= perf_swevent_event_idx,
+	.event_idx	= perf_event_nop_0,
 };
 
 static void perf_pmu_nop_void(struct pmu *pmu)
-- 
1.9.0

  parent reply	other threads:[~2014-03-06  0:01 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-06  0:00 [PATCH v4 00/11] powerpc: Add support for Power Hypervisor supplied performance counters Cody P Schafer
2014-03-06  0:01 ` [PATCH v4 01/11] sysfs: create bin_attributes under the requested group Cody P Schafer
2014-03-06  0:01 ` [PATCH v4 02/11] perf: add PMU_FORMAT_RANGE() helper for use by sw-like pmus Cody P Schafer
2014-03-06  0:01 ` Cody P Schafer [this message]
2014-03-06  0:01 ` [PATCH v4 04/11] powerpc: add hvcalls for 24x7 and gpci (get performance counter info) Cody P Schafer
2014-03-06  0:01 ` [PATCH v4 05/11] powerpc/perf: add hv_gpci interface header Cody P Schafer
2014-03-06  0:01 ` [PATCH v4 06/11] powerpc/perf: add 24x7 interface headers Cody P Schafer
2014-03-06  0:01 ` [PATCH v4 07/11] powerpc/perf: add a shared interface to get gpci version and capabilities Cody P Schafer
2014-03-06  0:01 ` [PATCH v4 08/11] powerpc/perf: add support for the hv gpci (get performance counter info) interface Cody P Schafer
2014-03-06  0:01 ` [PATCH v4 09/11] powerpc/perf: add support for the hv 24x7 interface Cody P Schafer
2014-03-25 10:43   ` Anton Blanchard
2014-03-25 18:19     ` Cody P Schafer
2014-03-25 18:32     ` Cody P Schafer
2014-03-26  9:43       ` David Laight
2014-05-22  8:19   ` Ian Munsie
2014-05-22 22:22     ` Cody P Schafer
2014-05-22 22:29       ` [PATCH] powerpc/perf/hv-24x7: use kmem_cache instead of aligned stack allocations Cody P Schafer
2014-05-22 22:38         ` Stephen Rothwell
2014-05-22 22:43           ` Cody P Schafer
2014-05-22 22:44       ` [PATCH v2] " Cody P Schafer
2014-05-22 23:49         ` Stephen Rothwell
2014-05-22 23:54           ` Cody P Schafer
2014-05-23  0:20             ` Stephen Rothwell
2014-03-06  0:01 ` [PATCH v4 10/11] powerpc/perf: add kconfig option for hypervisor provided counters Cody P Schafer
2014-03-06  0:01 ` [PATCH v4 11/11] powerpc/perf/hv_{gpci, 24x7}: add documentation of device attributes Cody P Schafer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394064082-6242-4-git-send-email-cody@linux.vnet.ibm.com \
    --to=cody@linux.vnet.ibm.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=michael@ellerman.id.au \
    --cc=mingo@redhat.com \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).