From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1lp0140.outbound.protection.outlook.com [207.46.163.140]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 37A072C00AB for ; Fri, 21 Mar 2014 08:30:49 +1100 (EST) Message-ID: <1395351036.12479.328.camel@snotra.buserror.net> Subject: Re: [v2,2/2] powerpc/mpc85xx: add support for Keymile's kmcoge4 board From: Scott Wood To: Valentin Longchamp Date: Thu, 20 Mar 2014 16:30:36 -0500 In-Reply-To: <532AA9F8.3060406@keymile.com> References: <1392119407-29490-3-git-send-email-valentin.longchamp@keymile.com> <20140319230813.GA30481@home.buserror.net> <532AA9F8.3060406@keymile.com> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Cc: "linuxppc-dev@lists.ozlabs.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2014-03-20 at 09:42 +0100, Valentin Longchamp wrote: > On 03/20/2014 12:08 AM, Scott Wood wrote: > > On Tue, Feb 11, 2014 at 12:50:07PM +0100, Valentin Longchamp wrote: > >> + reset_cpld@1,0 { > >> + interrupt-controller; > >> + #interrupt-cells = <2>; > >> + reg = <1 0 0x80>; > >> + interrupt-parent = <&mpic>; > >> + interrupts = < > >> + 4 1 0 0 > >> + 5 1 0 0>; > >> + }; > >> + > >> + chassis_mgmt@3,0 { > >> + interrupt-controller; > >> + #interrupt-cells = <2>; > >> + reg = <3 0 0x100>; > >> + interrupt-parent = <&mpic>; > >> + interrupts = <6 1 0 0>; > >> + }; > > > > Dashes are preferred to underscores in device trees. > > OK. > > > > > More importantly, these nodes need proper compatibles and bindings. Once > > that's done, the name for the nodes should probably be > > "board_control@whatever" for both. > > > > The first one can be board-ctrl. board-control (rather than board-ctrl) is already used in several device trees, so it would be good to be consistent. > The second however manages things that are > beyond this board and important for other boards in the chassis, so I think > chassis-mgmt is correct. OK. > For the binding/compatbiles issues: in the first discussion I had omitted these > nodes because these are not available (and honestly for such FPGAs I doubt they > will ever be mainlined). We discussed it and concluded that the DTS should > describe the HW and not the drivers available in the kernel so I have now added > them. Do you want me to add the compatible strings we use in our tree even > though there are no bindings ? Leave them as is ? Or drop them ? Include the compatibles, and add bindings. The bindings should state the compatible string used, what the interrupt specifier format is, and what reg/interrupts represents -- especially in the case of the reset cpld node, which has two interrupts. Make it clear which interrupt goes first and which goes second. It doesn't matter whether the driver will ever be mainlined. -Scott