From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Cody P Schafer <cody@linux.vnet.ibm.com>
Cc: cody+local@linux.vnet.ibm.com,
LKML <linux-kernel@vger.kernel.org>,
Michael Ellerman <michael@ellerman.id.au>,
David.Laight@aculab.com, Anton Blanchard <anton@samba.org>,
Linux PPC <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 1/2] fixup: "powerpc/perf: Add support for the hv 24x7 interface"
Date: Mon, 07 Apr 2014 09:48:30 +1000 [thread overview]
Message-ID: <1396828110.3671.21.camel@pasglop> (raw)
In-Reply-To: <1396476654-20623-2-git-send-email-cody@linux.vnet.ibm.com>
On Wed, 2014-04-02 at 15:10 -0700, Cody P Schafer wrote:
> Make the "not enabled" message less awful.
>
> Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>
> ---
> arch/powerpc/perf/hv-24x7.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/perf/hv-24x7.c b/arch/powerpc/perf/hv-24x7.c
> index 297c9105..3246ea2 100644
> --- a/arch/powerpc/perf/hv-24x7.c
> +++ b/arch/powerpc/perf/hv-24x7.c
> @@ -491,7 +491,7 @@ static int hv_24x7_init(void)
>
> hret = hv_perf_caps_get(&caps);
> if (hret) {
> - pr_info("could not obtain capabilities, error 0x%80lx, not enabling\n",
> + pr_info("could not obtain capabilities, not enabling (%ld)\n",
> hret);
That's not much less awful... The message gives 0 informations about
where it comes from .. what is it that couldn't obtain capabilities ?
Also, sentences start with a Capital.
Cheers,
Ben.
next prev parent reply other threads:[~2014-04-06 23:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 22:10 [PATCH 0/2] powerpc/perf: fixup 2 patches from the 24x7 series Cody P Schafer
2014-04-02 22:10 ` [PATCH 1/2] fixup: "powerpc/perf: Add support for the hv 24x7 interface" Cody P Schafer
2014-04-06 23:48 ` Benjamin Herrenschmidt [this message]
2014-04-07 1:22 ` Anton Blanchard
2014-04-02 22:10 ` [PATCH 2/2] fixup: "powerpc/perf: Add support for the hv gpci (get performance counter info) interface" Cody P Schafer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396828110.3671.21.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=David.Laight@aculab.com \
--cc=anton@samba.org \
--cc=cody+local@linux.vnet.ibm.com \
--cc=cody@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).