* [PATCH] powerpc/opal: Add missing include
@ 2014-03-25 0:43 Michael Neuling
2014-04-07 21:03 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Michael Neuling @ 2014-03-25 0:43 UTC (permalink / raw)
To: benh; +Cc: sfr, linux-next, Linux PPC dev
next-20140324 currently fails compiling celleb_defconfig with:
arch/powerpc/include/asm/opal.h:894:42: error: 'struct notifier_block' declared inside parameter list [-Werror]
arch/powerpc/include/asm/opal.h:894:42: error: its scope is only this definition or declaration, which is probably not what you want [-Werror]
arch/powerpc/include/asm/opal.h:896:14: error: 'struct notifier_block' declared inside parameter list [-Werror]
This is due to a missing include which is added here.
Signed-off-by: Michael Neuling <mikey@neuling.org>
diff --git a/arch/powerpc/include/asm/opal.h b/arch/powerpc/include/asm/opal.h
index fe2aa0b..f57fb58 100644
--- a/arch/powerpc/include/asm/opal.h
+++ b/arch/powerpc/include/asm/opal.h
@@ -177,6 +177,8 @@ extern int opal_enter_rtas(struct rtas_args *args,
#ifndef __ASSEMBLY__
+#include <linux/notifier.h>
+
/* Other enums */
enum OpalVendorApiTokens {
OPAL_START_VENDOR_API_RANGE = 1000, OPAL_END_VENDOR_API_RANGE = 1999
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc/opal: Add missing include
2014-03-25 0:43 [PATCH] powerpc/opal: Add missing include Michael Neuling
@ 2014-04-07 21:03 ` Geert Uytterhoeven
2014-04-07 22:07 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2014-04-07 21:03 UTC (permalink / raw)
To: Michael Neuling; +Cc: Linux PPC dev, Linux-Next, Stephen Rothwell
On Tue, Mar 25, 2014 at 1:43 AM, Michael Neuling <mikey@neuling.org> wrote:
> next-20140324 currently fails compiling celleb_defconfig with:
>
> arch/powerpc/include/asm/opal.h:894:42: error: 'struct notifier_block' declared inside parameter list [-Werror]
> arch/powerpc/include/asm/opal.h:894:42: error: its scope is only this definition or declaration, which is probably not what you want [-Werror]
> arch/powerpc/include/asm/opal.h:896:14: error: 'struct notifier_block' declared inside parameter list [-Werror]
>
> This is due to a missing include which is added here.
This build issue has now been in mainline since a few days.
> Signed-off-by: Michael Neuling <mikey@neuling.org>
>
> diff --git a/arch/powerpc/include/asm/opal.h b/arch/powerpc/include/asm/opal.h
> index fe2aa0b..f57fb58 100644
> --- a/arch/powerpc/include/asm/opal.h
> +++ b/arch/powerpc/include/asm/opal.h
> @@ -177,6 +177,8 @@ extern int opal_enter_rtas(struct rtas_args *args,
>
> #ifndef __ASSEMBLY__
>
> +#include <linux/notifier.h>
> +
> /* Other enums */
> enum OpalVendorApiTokens {
> OPAL_START_VENDOR_API_RANGE = 1000, OPAL_END_VENDOR_API_RANGE = 1999
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc/opal: Add missing include
2014-04-07 21:03 ` Geert Uytterhoeven
@ 2014-04-07 22:07 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2014-04-07 22:07 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Stephen Rothwell, Michael Neuling, Linux-Next, Linux PPC dev
On Mon, 2014-04-07 at 23:03 +0200, Geert Uytterhoeven wrote:
> On Tue, Mar 25, 2014 at 1:43 AM, Michael Neuling <mikey@neuling.org> wrote:
> > next-20140324 currently fails compiling celleb_defconfig with:
> >
> > arch/powerpc/include/asm/opal.h:894:42: error: 'struct notifier_block' declared inside parameter list [-Werror]
> > arch/powerpc/include/asm/opal.h:894:42: error: its scope is only this definition or declaration, which is probably not what you want [-Werror]
> > arch/powerpc/include/asm/opal.h:896:14: error: 'struct notifier_block' declared inside parameter list [-Werror]
> >
> > This is due to a missing include which is added here.
>
> This build issue has now been in mainline since a few days.
It's in my tree, I will send the patch upstream in the next couple of
days (having a medical procedure today).
Ben.
> > Signed-off-by: Michael Neuling <mikey@neuling.org>
> >
> > diff --git a/arch/powerpc/include/asm/opal.h b/arch/powerpc/include/asm/opal.h
> > index fe2aa0b..f57fb58 100644
> > --- a/arch/powerpc/include/asm/opal.h
> > +++ b/arch/powerpc/include/asm/opal.h
> > @@ -177,6 +177,8 @@ extern int opal_enter_rtas(struct rtas_args *args,
> >
> > #ifndef __ASSEMBLY__
> >
> > +#include <linux/notifier.h>
> > +
> > /* Other enums */
> > enum OpalVendorApiTokens {
> > OPAL_START_VENDOR_API_RANGE = 1000, OPAL_END_VENDOR_API_RANGE = 1999
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-07 22:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-25 0:43 [PATCH] powerpc/opal: Add missing include Michael Neuling
2014-04-07 21:03 ` Geert Uytterhoeven
2014-04-07 22:07 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).