From: Scott Wood <scottwood@freescale.com>
To: Valentin Longchamp <valentin.longchamp@keymile.com>
Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3 3/3] powerpc/mpc85xx: add support for Keymile's kmcoge4 board
Date: Tue, 8 Apr 2014 19:47:32 -0500 [thread overview]
Message-ID: <1397004452.32034.330.camel@snotra.buserror.net> (raw)
In-Reply-To: <1395754915-14534-4-git-send-email-valentin.longchamp@keymile.com>
On Tue, 2014-03-25 at 14:41 +0100, Valentin Longchamp wrote:
> + lbc: localbus@ffe124000 {
> + reg = <0xf 0xfe124000 0 0x1000>;
> + ranges = <0 0 0xf 0xffa00000 0x00040000 /* LB 0 */
> + 1 0 0xf 0xfb000000 0x00010000 /* LB 1 */
> + 2 0 0xf 0xd0000000 0x10000000 /* LB 2 */
> + 3 0 0xf 0xe0000000 0x10000000>; /* LB 3 */
> +
> + nand@0,0 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "fsl,elbc-fcm-nand";
> + reg = <0 0 0x40000>;
> +
> + partition@0 {
> + label = "ubi0";
> + reg = <0x0 0x10000000>;
> + };
Putting partition info in the dts file is a bad habit and (as I've told
others) I don't think we should continue doing so in new dts files.
In this case it looks like you're just making the entire chip into one
partition, so I'm not sure what the point is of partitioning at all.
-Scott
prev parent reply other threads:[~2014-04-09 0:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 13:41 [PATCH v3 0/3] Support of the kmcoge4 board Valentin Longchamp
2014-03-25 13:41 ` [PATCH v3 1/3] devicetree: bindings: add Zarlink to the vendor prefixes Valentin Longchamp
2014-03-25 13:56 ` Rob Herring
2014-03-25 13:41 ` [PATCH v3 2/3] devcietree: bindings: add some MFD Keymile FPGAs Valentin Longchamp
2014-04-09 0:44 ` Scott Wood
2014-04-09 6:39 ` Valentin Longchamp
2014-04-10 15:06 ` Rob Herring
2014-03-25 13:41 ` [PATCH v3 3/3] powerpc/mpc85xx: add support for Keymile's kmcoge4 board Valentin Longchamp
2014-04-09 0:47 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397004452.32034.330.camel@snotra.buserror.net \
--to=scottwood@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=valentin.longchamp@keymile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).