From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 780751400D3 for ; Mon, 28 Apr 2014 10:44:56 +1000 (EST) Message-ID: <1398645801.8437.84.camel@pasglop> Subject: Re: [PATCH 08/13] PCI, rpaphp: Use new pci_is_bridge() to simplify code From: Benjamin Herrenschmidt To: Yijing Wang Date: Mon, 28 Apr 2014 10:43:21 +1000 In-Reply-To: <1398417515-8740-9-git-send-email-wangyijing@huawei.com> References: <1398417515-8740-1-git-send-email-wangyijing@huawei.com> <1398417515-8740-9-git-send-email-wangyijing@huawei.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: Tony Luck , linux-ia64@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, Bjorn Helgaas , Thomas Gleixner , linuxppc-dev@lists.ozlabs.org, "David S. Miller" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2014-04-25 at 17:18 +0800, Yijing Wang wrote: > Now we can use new pci_is_bridge() helper function > to simplify code. > > Signed-off-by: Yijing Wang Acked-by: Benjamin Herrenschmidt > --- > drivers/pci/hotplug/rpadlpar_core.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c > index 4fcdeed..7660232 100644 > --- a/drivers/pci/hotplug/rpadlpar_core.c > +++ b/drivers/pci/hotplug/rpadlpar_core.c > @@ -157,8 +157,7 @@ static void dlpar_pci_add_bus(struct device_node *dn) > } > > /* Scan below the new bridge */ > - if (dev->hdr_type == PCI_HEADER_TYPE_BRIDGE || > - dev->hdr_type == PCI_HEADER_TYPE_CARDBUS) > + if (pci_is_bridge(dev)) > of_scan_pci_bridge(dev); > > /* Map IO space for child bus, which may or may not succeed */