From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
linuxppc-dev@lists.ozlabs.org,
Steven Rostedt <rostedt@goodmis.org>
Subject: [PATCH 0/2] Fix smp_processor_id() in preemptible splat
Date: Tue, 29 Apr 2014 15:25:15 -0400 [thread overview]
Message-ID: <1398799517-47879-1-git-send-email-paul.gortmaker@windriver.com> (raw)
This seems to have been around for a while; I tripped over it while
working on testing 3.10-rt with Steven, and then confirmed it still
was an issue on today's mainline. (didn't check -next however...)
I didn't bisect, but it looks like it may have come in from the
changes in v3.9-rc1~100^2~57. It probably only impacts the older
cores like the 74xx that don't have CONFIG_HAVE_HW_BREAKPOINT,
and I know I haven't booted my sbc8641D in over a year, so no
surprise this went undetected for a while. Maybe adding a Cc:
stable is warranted?
It is pretty hard to ignore the splats since you get one per process,
so it must be just the older platform never getting much testing.
The 1st patch is just a small cleanup that makes the 2nd patch
a bit smaller.
If the __set_breakpoint() addition isn't liked, then we could
alternatively just wrap the one call site with preempt_dis/en/able.
Paul.
---
Paul Gortmaker (2):
powerpc: drop return value from set_breakpoint as it is unused
powerpc: fix smp_processor_id() in preemptible splat in set_breakpoint
arch/powerpc/include/asm/debug.h | 3 ++-
arch/powerpc/include/asm/hw_breakpoint.h | 2 +-
arch/powerpc/kernel/hw_breakpoint.c | 8 ++++----
arch/powerpc/kernel/process.c | 15 +++++++++++----
arch/powerpc/kernel/signal.c | 2 +-
arch/powerpc/xmon/xmon.c | 2 +-
6 files changed, 20 insertions(+), 12 deletions(-)
--
1.9.0
next reply other threads:[~2014-04-29 23:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 19:25 Paul Gortmaker [this message]
2014-04-29 19:25 ` [PATCH 1/2] powerpc: drop return value from set_breakpoint as it is unused Paul Gortmaker
2014-04-29 19:25 ` [PATCH 2/2] powerpc: fix smp_processor_id() in preemptible splat in set_breakpoint Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398799517-47879-1-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).