linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Yann Droneaud <ydroneaud@opteya.com>
Cc: "Hans-Bernhard Bröker" <broeker@users.sourceforge.net>,
	"Neil Horman" <nhorman@tuxdriver.com>,
	linux-kernel@vger.kernel.org,
	"Neil Horman" <nhorman@users.sourceforge.net>,
	cscope-devel@lists.sourceforge.net,
	"Anton Blanchard" <anton@samba.org>,
	linuxppc-dev@lists.ozlabs.org,
	"Hans-Bernhard Broeker" <broeker@physik.rwth-aachen.de>
Subject: Re: cscope: issue with symlinks in tools/testing/selftests/powerpc/copyloops/
Date: Fri, 02 May 2014 11:19:19 +1000	[thread overview]
Message-ID: <1398993559.23822.1.camel@concordia> (raw)
In-Reply-To: <1396530975.4361.28.camel@localhost.localdomain>

On Thu, 2014-04-03 at 15:16 +0200, Yann Droneaud wrote:
> Hi,
> 
> I'm using cscope to browse kernel sources, but I'm facing warnings from
> the tool since following commit:
> 
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=22d651dcef536c75f75537290bf3da5038e68b6b
> 
>     commit 22d651dcef536c75f75537290bf3da5038e68b6b
>     Author: Michael Ellerman <mpe@ellerman.id.au>
>     Date:   Tue Jan 21 15:22:17 2014 +1100
> 
>     selftests/powerpc: Import Anton's memcpy / copy_tofrom_user tests

Ooops, sorry.

> cscope reports error when generating the cross-reference database:
> 
>     $ make ALLSOURCE_ARCHS=all O=./obj-cscope/ cscope
>       GEN     cscope
>     cscope: cannot find
> file /home/ydroneaud/src/linux/tools/testing/selftests/powerpc/copyloops/copyuser_power7.S
> 
> It's a rather uncommon side effect of having (for the first time ?)
> sources files as symlinks: looking for symlinks in the kernel sources
> returns only:
> 
>     $ find . -type l
>     ./arch/mips/boot/dts/include/dt-bindings
>     ./arch/microblaze/boot/dts/system.dts
>     ./arch/powerpc/boot/dts/include/dt-bindings
>     ./arch/metag/boot/dts/include/dt-bindings
>     ./arch/arm/boot/dts/include/dt-bindings
>     ./tools/testing/selftests/powerpc/copyloops/copyuser_power7.S
>     ./tools/testing/selftests/powerpc/copyloops/memcpy_64.S
>     ./tools/testing/selftests/powerpc/copyloops/memcpy_power7.S
>     ./tools/testing/selftests/powerpc/copyloops/copyuser_64.S


Right.

I did check that there were other symlinks already in the tree, but you're
correct I seem to be the first clever person to add symlinks to source files.

> So one can wonder if having symlinked sources files is an expected
> supported feature for kbuild and all the various kernel
> tools/infrastructure ?

Kbuild is not involved really, these files are just built with plain Makefiles,
at least from the symlink side.

FWIW ctags seems to cope, that's what I use.

But I didn't think of cscope.


Given you're the only person who's noticed I suspect most other things haven't
broken, fingers crossed :)

cheers

      parent reply	other threads:[~2014-05-02  1:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-03 13:16 cscope: issue with symlinks in tools/testing/selftests/powerpc/copyloops/ Yann Droneaud
2014-04-07 10:42 ` Neil Horman
2014-04-07 12:42   ` Gerhard Sittig
2014-04-07 15:36     ` Neil Horman
2014-04-08  7:56     ` Gerhard Sittig
2014-04-08 10:49       ` Neil Horman
2014-05-02  1:19 ` Michael Ellerman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398993559.23822.1.camel@concordia \
    --to=mpe@ellerman.id.au \
    --cc=anton@samba.org \
    --cc=broeker@physik.rwth-aachen.de \
    --cc=broeker@users.sourceforge.net \
    --cc=cscope-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=nhorman@tuxdriver.com \
    --cc=nhorman@users.sourceforge.net \
    --cc=ydroneaud@opteya.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).