From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alexander Graf <agraf@suse.de>
Cc: aik@ozlabs.ru, Gavin Shan <gwshan@linux.vnet.ibm.com>,
kvm-ppc@vger.kernel.org, alex.williamson@redhat.com,
qiudayu@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 8/8] powerpc/powernv: Error injection infrastructure
Date: Tue, 20 May 2014 08:40:00 +1000 [thread overview]
Message-ID: <1400539200.3986.73.camel@pasglop> (raw)
In-Reply-To: <537A015D.8030202@suse.de>
On Mon, 2014-05-19 at 15:04 +0200, Alexander Graf wrote:
> On 14.05.14 06:12, Gavin Shan wrote:
> > The patch intends to implement the error injection infrastructure
> > for PowerNV platform. The predetermined handlers will be called
> > according to the type of injected error (e.g. OpalErrinjctTypeIoaBusError).
> > For now, we just support PCI error injection. We need support
> > injecting other types of errors in future.
>
> Your token to a VFIO device is the VFIO fd. If you want to inject an
> error into that device, you should do it via that token. That gets you
> all permission problems solved for free.
>
> But I still didn't quite grasp why you need to do this. Why do we need
> to inject an error into a device via OPAL when we want to do EEH inside
> of a guest? Are you trying to emulate guest side error injection?
Yes, that's what he's trying to do but let's keep that separate from
the core EEH. I'd like the latter to be reviewed /fixed and upstream
first, then we can look at guest side injection.
Cheers,
Ben.
next prev parent reply other threads:[~2014-05-19 22:40 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 4:11 [PATCH RFC v3 0/8] EEH Support for VFIO PCI device Gavin Shan
2014-05-14 4:11 ` [PATCH 1/8] drivers/vfio: Introduce CONFIG_VFIO_EEH Gavin Shan
2014-05-14 4:11 ` [PATCH 2/8] powerpc/eeh: Info to trace passed devices Gavin Shan
2014-05-19 12:46 ` Alexander Graf
2014-05-19 22:37 ` Benjamin Herrenschmidt
2014-05-19 23:54 ` Gavin Shan
2014-05-14 4:11 ` [PATCH 3/8] drivers/vfio: New IOCTL command VFIO_EEH_INFO Gavin Shan
2014-05-19 12:51 ` Alexander Graf
2014-05-19 23:57 ` Gavin Shan
2014-05-19 22:33 ` Alex Williamson
2014-05-19 22:51 ` Benjamin Herrenschmidt
2014-05-20 0:22 ` Gavin Shan
2014-05-20 0:37 ` Alex Williamson
2014-05-20 8:28 ` Gavin Shan
2014-05-20 10:02 ` Alexander Graf
2014-05-20 10:23 ` Gavin Shan
2014-05-14 4:11 ` [PATCH 4/8] powerpc/eeh: Avoid event on passed PE Gavin Shan
2014-05-14 4:11 ` [PATCH 5/8] powerpc/powernv: Sync OPAL header file with firmware Gavin Shan
2014-05-14 4:12 ` [PATCH 6/8] powerpc: Extend syscall ppc_rtas() Gavin Shan
2014-05-19 12:55 ` Alexander Graf
2014-05-19 22:38 ` Benjamin Herrenschmidt
2014-05-14 4:12 ` [PATCH 7/8] powerpc/powernv: Implement ppc_call_opal() Gavin Shan
2014-05-19 12:59 ` Alexander Graf
2014-05-14 4:12 ` [PATCH 8/8] powerpc/powernv: Error injection infrastructure Gavin Shan
2014-05-19 13:04 ` Alexander Graf
2014-05-19 22:40 ` Benjamin Herrenschmidt [this message]
2014-05-15 6:34 ` [PATCH RFC v3 0/8] EEH Support for VFIO PCI device Mike Qiu
2014-05-15 7:43 ` Gavin Shan
2014-05-19 10:07 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400539200.3986.73.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=qiudayu@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).