From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Gavin Shan <gwshan@linux.vnet.ibm.com>
Cc: aik@ozlabs.ru, Alexander Graf <agraf@suse.de>,
kvm-ppc@vger.kernel.org, alex.williamson@redhat.com,
qiudayu@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 3/4] drivers/vfio: New IOCTL command VFIO_EEH_INFO
Date: Wed, 21 May 2014 10:23:52 +1000 [thread overview]
Message-ID: <1400631832.3986.154.camel@pasglop> (raw)
In-Reply-To: <20140520123914.GA28441@shangw>
On Tue, 2014-05-20 at 22:39 +1000, Gavin Shan wrote:
> >>Yeah. How about this? :-)
> >>
> >>- Move eeh-vfio.c to drivers/vfio/pci/
> >>- From eeh-vfio.c, dereference arch/powerpc/kernel/eeh.c::eeh_ops, which
> >> is arch/powerpc/plaforms/powernv/eeh-powernv.c::powernv_eeh_ops. Call
> >
> >Hrm, I think it'd be nicer to just export individual functions that
> >do thing you want to do from eeh.c.
> >
>
> Ok. Got it. Thanks for your comments :)
The interesting thing with this approach is that VFIO per-se can work
with EEH RTAS backend too in the host.
IE, with PR KVM for example or with non-KVM uses of VFIO, it would be
possible to use a device in a user process and exploit EEH even when
running under a PAPR hypervisor.
That is, vfio-eeh uses "generic" exported EEH APIs from the EEH core
that will work on both powernv and RTAS backends.
Note to Alex: This definitely kills the notifier idea for now though,
at least as a first class citizen of the design. We can add it as an
optional optimization on top later.
Cheers,
Ben.
next prev parent reply other threads:[~2014-05-21 0:24 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 8:30 [PATCH RFCv4 0/4] EEH Support for VFIO PCI device Gavin Shan
2014-05-20 8:30 ` [PATCH 1/4] drivers/vfio: Introduce CONFIG_VFIO_PCI_EEH Gavin Shan
2014-05-20 8:30 ` [PATCH 2/4] powerpc/eeh: Flags for passed device and PE Gavin Shan
2014-05-20 8:30 ` [PATCH 3/4] drivers/vfio: New IOCTL command VFIO_EEH_INFO Gavin Shan
2014-05-20 11:21 ` Alexander Graf
2014-05-20 11:28 ` Alexander Graf
2014-05-20 11:40 ` Gavin Shan
2014-05-20 11:44 ` Alexander Graf
2014-05-20 12:21 ` Gavin Shan
2014-05-20 12:25 ` Alexander Graf
2014-05-20 12:39 ` Gavin Shan
2014-05-21 0:23 ` Benjamin Herrenschmidt [this message]
2014-05-21 4:39 ` Gavin Shan
2014-05-21 6:23 ` Alexander Graf
2014-05-21 7:24 ` Benjamin Herrenschmidt
2014-05-21 10:48 ` Gavin Shan
2014-05-21 0:21 ` Benjamin Herrenschmidt
2014-05-20 8:30 ` [PATCH 4/4] powerpc/eeh: Avoid event on passed PE Gavin Shan
2014-05-20 11:25 ` Alexander Graf
2014-05-20 11:56 ` Gavin Shan
2014-05-20 12:14 ` Alexander Graf
2014-05-20 12:45 ` Gavin Shan
2014-05-20 13:49 ` Alexander Graf
2014-05-21 0:13 ` Benjamin Herrenschmidt
2014-05-21 6:16 ` Alexander Graf
2014-05-21 0:19 ` Benjamin Herrenschmidt
2014-05-21 6:20 ` Alexander Graf
2014-05-21 0:12 ` Benjamin Herrenschmidt
2014-05-21 4:41 ` Gavin Shan
2014-06-03 5:54 ` Paul Mackerras
2014-06-03 7:45 ` Alexander Graf
2014-06-03 7:52 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400631832.3986.154.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=qiudayu@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).