From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Gavin Shan <gwshan@linux.vnet.ibm.com>
Cc: aik@ozlabs.ru, Alexander Graf <agraf@suse.de>,
kvm-ppc@vger.kernel.org,
Alex Williamson <alex.williamson@redhat.com>,
qiudayu@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v7 3/3] drivers/vfio: EEH support for VFIO PCI device
Date: Thu, 29 May 2014 07:58:31 +1000 [thread overview]
Message-ID: <1401314311.8262.26.camel@pasglop> (raw)
In-Reply-To: <20140528124947.GA19346@shangw>
On Wed, 2014-05-28 at 22:49 +1000, Gavin Shan wrote:
>
> I will remove those "address" related macros in next revision because it's
> user-level bussiness, not related to host kernel any more.
>
> If the user is QEMU + guest, we need the address to identify the PE though PHB
> BUID could be used as same purpose to get PHB, which is one-to-one mapping with
> IOMMU group on sPAPR platform. However, once the PE address is built and returned
> to guest, guest will use the PE address as input parameter in subsequent RTAS
> calls.
>
> If the user is some kind of application who just uses the ioctl() without supporting
> RTAS calls. We don't need care about PE address.
I am a bit reluctant with that PE==PHB equation we seem to be introducing.
This isn't the case in HW. It's possible that this is how we handle VFIO *today*
in qemu but it doesn't have to be does it ?
It also paints us into a corner if we want to start implementing some kind of
emulated EEH for selected emulated devices and/or virtio.
Cheers,
Ben.
next prev parent reply other threads:[~2014-05-28 21:58 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 8:40 [PATCH v7 0/3] EEH Support for VFIO PCI Device Gavin Shan
2014-05-27 8:40 ` [PATCH v7 1/3] powerpc/eeh: Avoid event on passed PE Gavin Shan
2014-05-27 8:40 ` [PATCH v7 2/3] powerpc/eeh: EEH support for VFIO PCI device Gavin Shan
2014-05-27 8:40 ` [PATCH v7 3/3] drivers/vfio: " Gavin Shan
2014-05-27 18:15 ` Alex Williamson
2014-05-27 20:30 ` Benjamin Herrenschmidt
2014-05-27 20:37 ` Alex Williamson
2014-05-27 20:41 ` Benjamin Herrenschmidt
2014-05-27 22:49 ` Alexander Graf
2014-05-28 0:39 ` Alex Williamson
2014-05-28 0:44 ` Alexander Graf
2014-05-28 0:57 ` Alex Williamson
2014-05-28 11:37 ` Alexander Graf
2014-05-28 16:17 ` Alex Williamson
2014-05-28 22:40 ` Alexander Graf
2014-05-28 23:37 ` Gavin Shan
2014-05-28 23:38 ` Alexander Graf
2014-05-28 23:41 ` Gavin Shan
2014-05-28 0:55 ` Gavin Shan
2014-05-28 11:41 ` Alexander Graf
2014-05-28 12:49 ` Gavin Shan
2014-05-28 13:12 ` Alexander Graf
2014-05-28 23:13 ` Gavin Shan
2014-05-28 21:58 ` Benjamin Herrenschmidt [this message]
2014-05-28 22:46 ` Alexander Graf
2014-05-28 23:18 ` Benjamin Herrenschmidt
2014-05-30 3:44 ` Alexey Kardashevskiy
2014-05-30 3:49 ` Benjamin Herrenschmidt
2014-05-28 16:32 ` Alex Williamson
2014-05-29 0:05 ` Gavin Shan
2014-05-29 0:44 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401314311.8262.26.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=qiudayu@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).