From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout3.w1.samsung.com (mailout3.w1.samsung.com [210.118.77.13]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 39FC51A06DA for ; Fri, 30 May 2014 20:21:39 +1000 (EST) Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N6D00LDVTN97W60@mailout3.w1.samsung.com> for linuxppc-dev@lists.ozlabs.org; Fri, 30 May 2014 11:11:33 +0100 (BST) From: Andrzej Hajda To: Lee Jones , Jingoo Han , Bryan Wu Subject: [PATCH 1/2] backlight: show brightness even if get_brightness is not implemented Date: Fri, 30 May 2014 12:10:49 +0200 Message-id: <1401444650-12267-2-git-send-email-a.hajda@samsung.com> In-reply-to: <1401444650-12267-1-git-send-email-a.hajda@samsung.com> References: <1401444650-12267-1-git-send-email-a.hajda@samsung.com> Cc: Milo Kim , "open list:FRAMEBUFFER LAYER" , "open list:X86 PLATFORM DRIVERS" , Andrzej Hajda , Thierry Reding , Laurent Pinchart , Yijing Wang , Matthew Garrett , Kukjin Kim , Sachin Kamat , Tomi Valkeinen , Geert Uytterhoeven , Daniel Vetter , Jean-Christophe Plagniol-Villard , Dan Carpenter , "open list:PWM SUBSYSTEM" , "moderated list:ARM/S5P EXYNOS AR..." , Mikulas Patocka , "moderated list:ARM/S5P EXYNOS AR..." , Randy Dunlap , open list , Rob Clark , Jon Mason , Joe Perches , "open list:LINUX FOR POWER M..." List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Many implementations of get_brightness operation returns only value of props.brightness field. This change makes such implementations unnecessary. Signed-off-by: Andrzej Hajda --- drivers/video/backlight/backlight.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c index 19b170d..0ce8823 100644 --- a/drivers/video/backlight/backlight.c +++ b/drivers/video/backlight/backlight.c @@ -221,6 +221,8 @@ static ssize_t actual_brightness_show(struct device *dev, mutex_lock(&bd->ops_lock); if (bd->ops && bd->ops->get_brightness) rc = sprintf(buf, "%d\n", bd->ops->get_brightness(bd)); + else + rc = sprintf(buf, "%d\n", bd->props.brightness); mutex_unlock(&bd->ops_lock); return rc; -- 1.9.1