From: Scott Wood <scottwood@freescale.com>
To: Shengzhou Liu <Shengzhou.Liu@freescale.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/3 v2] powerpc/fsl-booke: Add support for T2080/T2081 SoC
Date: Fri, 30 May 2014 16:17:09 -0500 [thread overview]
Message-ID: <1401484629.6603.216.camel@snotra.buserror.net> (raw)
In-Reply-To: <1400833623-17547-1-git-send-email-Shengzhou.Liu@freescale.com>
On Fri, 2014-05-23 at 16:27 +0800, Shengzhou Liu wrote:
> + iommu@20000 {
> + compatible = "fsl,pamu-v1.0", "fsl,pamu";
> + reg = <0x20000 0x6000>;
> + interrupts = <
> + 24 2 0 0
> + 16 2 1 30>;
> + };
Please add fsl,portid-mapping here and on the CPU nodes.
> + clockgen: global-utilities@e1000 {
> + compatible = "fsl,t2080-clockgen", "fsl,qoriq-clockgen-2.0",
> + "fixed-clock";
> + reg = <0xe1000 0x1000>;
> + clock-output-names = "sysclk";
> + #clock-cells = <0>;
Please update this based on
Documentation/devicetree/bindings/clock/qoriq-clock.txt.
In particular, sysclk needs to go in a subnode rather than in the
global-utilities node.
-Scott
prev parent reply other threads:[~2014-05-30 21:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 8:27 [PATCH 1/3 v2] powerpc/fsl-booke: Add support for T2080/T2081 SoC Shengzhou Liu
2014-05-23 8:27 ` [PATCH v2] powerpc/fsl-booke: Add initial T208x QDS board support Shengzhou Liu
2014-05-23 8:27 ` [PATCH v2] powerpc/t2080rdb: Add T2080RDB " Shengzhou Liu
2014-05-30 21:19 ` Scott Wood
2014-05-30 21:17 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401484629.6603.216.camel@snotra.buserror.net \
--to=scottwood@freescale.com \
--cc=Shengzhou.Liu@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).