From: Michael Neuling <mikey@neuling.org>
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc, xmon: Enable hardware instruction breakpoint support on POWER8
Date: Sun, 01 Jun 2014 16:18:11 +1000 [thread overview]
Message-ID: <1401603491.13479.11.camel@ale.ozlabs.ibm.com> (raw)
In-Reply-To: <1401451823-25547-1-git-send-email-khandual@linux.vnet.ibm.com>
On Fri, 2014-05-30 at 17:40 +0530, Anshuman Khandual wrote:
> This patch enables support for hardware instruction breakpoints on POWER8=
with
> the help of a new register called CIABR (Completed Instruction Address Br=
eakpoint
> Register). With this patch, single hardware instruction breakpoint can be=
added
> and cleared during any active xmon debug session. This hardware based ins=
truction
> breakpoint mechanism works correctly along with the existing TRAP based i=
nstruction
> breakpoints available on xmon. Example usage as follows.
Have you actually tried this on a guest?
Please also compile with a range of configs. It doesn't compile with
ppc64e_defconfig.
In file included from /scratch/mikey/src/linux-ozlabs/arch/powerpc/xmon/xmo=
n.c:51:0:
/scratch/mikey/src/linux-ozlabs/arch/powerpc/include/asm/plpar_wrappers.h: =
In function 'get_cede_latency_hint':
/scratch/mikey/src/linux-ozlabs/arch/powerpc/include/asm/plpar_wrappers.h:2=
6:9: error: 'struct paca_struct' has no member named 'lppaca_ptr'
/scratch/mikey/src/linux-ozlabs/arch/powerpc/include/asm/plpar_wrappers.h: =
In function 'set_cede_latency_hint':
/scratch/mikey/src/linux-ozlabs/arch/powerpc/include/asm/plpar_wrappers.h:3=
1:2: error: 'struct paca_struct' has no member named 'lppaca_ptr'
/scratch/mikey/src/linux-ozlabs/arch/powerpc/include/asm/plpar_wrappers.h: =
In function 'plpar_page_set_loaned':
/scratch/mikey/src/linux-ozlabs/arch/powerpc/include/asm/plpar_wrappers.h:9=
8:2: error: implicit declaration of function 'cmo_get_page_size' [-Werror=
=3Dimplicit-function-declaration]
cc1: all warnings being treated as errors
> - (bp->enabled & BP_IABR)? "inst": "trap");
> + (bp->enabled & (BP_IABR | BP_CIABR))?
> + "inst": "trap");
Git complains about whitespace issues here. Spaces before tabs.
Mikey
next prev parent reply other threads:[~2014-06-01 6:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 12:10 [PATCH] powerpc, xmon: Enable hardware instruction breakpoint support on POWER8 Anshuman Khandual
2014-05-30 13:42 ` Aneesh Kumar K.V
2014-06-03 6:03 ` Anshuman Khandual
2014-06-04 8:48 ` Anshuman Khandual
2014-06-12 8:19 ` Anshuman Khandual
2014-06-01 6:18 ` Michael Neuling [this message]
2014-06-02 8:48 ` Anshuman Khandual
2014-06-03 8:31 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401603491.13479.11.camel@ale.ozlabs.ibm.com \
--to=mikey@neuling.org \
--cc=khandual@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).