From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1blp0187.outbound.protection.outlook.com [207.46.163.187]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 583FB1A0041 for ; Thu, 5 Jun 2014 03:07:48 +1000 (EST) Message-ID: <1401901656.6603.327.camel@snotra.buserror.net> Subject: Re: [RESEND PATCH] memory: Freescale CoreNet Coherency Fabric error reporting driver From: Scott Wood To: Bhushan Bharat-R65777 Date: Wed, 4 Jun 2014 12:07:36 -0500 In-Reply-To: <35f1762b80694ba4835cd7902a2faa0a@BLUPR03MB566.namprd03.prod.outlook.com> References: <20140530222743.GA6918@home.buserror.net> <967d9a5e0f7e4d0a8f5e7ec6b8e88ff2@BLUPR03MB566.namprd03.prod.outlook.com> <1401900111.6603.325.camel@snotra.buserror.net> <35f1762b80694ba4835cd7902a2faa0a@BLUPR03MB566.namprd03.prod.outlook.com> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Cc: Greg Kroah-Hartman , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2014-06-04 at 12:04 -0500, Bhushan Bharat-R65777 wrote: > > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Wednesday, June 04, 2014 10:12 PM > > To: Bhushan Bharat-R65777 > > Cc: Greg Kroah-Hartman; linuxppc-dev@lists.ozlabs.org; linux- > > kernel@vger.kernel.org > > Subject: Re: [RESEND PATCH] memory: Freescale CoreNet Coherency Fabric error > > reporting driver > > > > On Wed, 2014-06-04 at 03:17 -0500, Bhushan Bharat-R65777 wrote: > > > > +static int ccf_remove(struct platform_device *pdev) { > > > > + struct ccf_private *ccf = dev_get_drvdata(&pdev->dev); > > > > + > > > > + switch (ccf->info->version) { > > > > + case CCF1: > > > > + iowrite32be(0, &ccf->err_regs->errdis); > > > > + break; > > > > + > > > > + case CCF2: > > > > + iowrite32be(0, &ccf->err_regs->errinten); > > > > > > Do you think it is same to disable detection bits in ccf->err_regs->errdis? > > > > Disabling the interrupt is what we're aiming for here, but ccf1 doesn't provide > > a way to do that separate from disabling detection. > > What I wanted to say that do we also need to disable detection (set > ERRDET_LAE | ERRDET_CV bits in errdis) apart from clearing errinten on > ccf2 ? I don't think we "need" to. You could argue that we should for consistency, though I think there's value in errors continuing to be detected even without the driver (e.g. can dump the registers in a debugger). -Scott