linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
	linux-ia64@vger.kernel.org, sparse@chrisli.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Paul Mackerras <paulus@samba.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-tip-commits@vger.kernel.org,
	anil.s.keshavamurthy@intel.com, Ingo Molnar <mingo@kernel.org>,
	"Suzuki K. Poulose" <suzuki@in.ibm.com>,
	Fenghua Yu <fenghua.yu@intel.com>, Arnd Bergmann <arnd@arndb.de>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Chris Wright <chrisw@sous-sol.org>,
	yrl.pp-manager.tt@hitachi.com, akataria@vmware.com,
	Tony Luck <tony.luck@intel.com>, Kevin Hao <haokexin@gmail.com>,
	linuxppc-dev@lists.ozlabs.org, rdunlap@infradead.org,
	Tony Luck <tony.luck@gmail.com>,
	dl9pf@gmx.de, Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: Re: Re: [RFT PATCH -next v3] [BUGFIX] kprobes: Fix "Failed to find blacklist" error on ia64 and ppc64
Date: Fri, 20 Jun 2014 10:37:26 +1000	[thread overview]
Message-ID: <1403224646.18509.1.camel@concordia> (raw)
In-Reply-To: <53A2C78D.9060708@hitachi.com>

On Thu, 2014-06-19 at 20:20 +0900, Masami Hiramatsu wrote:
> (2014/06/19 20:01), Masami Hiramatsu wrote:
> 
> >>>>> Ah, those messages should be shown in dmesg when booting if it doesn't work,
> >>>>> because the messages are printed by initialization process of kprobe blacklist.
> >>>>> So, reproducing it is just enabling CONFIG_KPROBES and boot it.
> >>>> Well,  we don't get those messages on Power, since the kallsyms has the
> >>>> entries for ".function_name". The correct way to verify is, either  :
> >>>
> >>> Hmm, that seems another issue on powerpc. Is that expected(and designed)
> >>> behavior?
> >> AFAIK, yes, it is.
> >> To be more precise :
> >>
> >> we have 'foo' and '.foo' for a function foo(), where 'foo' points to the
> >> function_entry and '.foo' points to the actual function.
> > 
> > Ah, I see. So if we run
> > 
> >   func_ptr p = foo;
> >   return p == kallsyms_lookup_name(".foo");
> > 
> > it returns true.
> 
> One more thing I should know, is the address of ".function_name" within the
> kernel text? In other words, does kernel_text_address() return true for that
> address? If not, it's easy to verify the address.

Yes. That is the text address, kernel_text_address() should definitely return
true.

On 64-bit, ABIv1, "foo" points to the function descriptor, in the ".opd"
section.

".foo" points to the actual text of the function, in ".text".

On 64-bit, ABIv2, "foo" points to the text in ".text". There are no dot
symbols.

cheers

  reply	other threads:[~2014-06-20  0:37 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <536A16A6.5040709@hitachi.com>
2014-05-07 11:55 ` [RFT PATCH -next ] [BUGFIX] kprobes: Fix "Failed to find blacklist" error on ia64 and ppc64 Masami Hiramatsu
2014-05-07 11:59   ` Masami Hiramatsu
2014-05-14  8:19     ` Masami Hiramatsu
2014-05-08  4:47   ` Ananth N Mavinakayanahalli
2014-05-08  5:40     ` Masami Hiramatsu
2014-05-08  6:16       ` Ananth N Mavinakayanahalli
2014-05-09  8:06         ` Masami Hiramatsu
2014-05-26 11:25   ` Suzuki K. Poulose
2014-05-26 11:48     ` Masami Hiramatsu
2014-05-27  6:31     ` [RFT PATCH -next v2] " Masami Hiramatsu
2014-05-29 19:13       ` Suzuki K. Poulose
2014-05-30  2:47         ` Masami Hiramatsu
2014-05-30  3:18           ` [RFT PATCH -next v3] " Masami Hiramatsu
2014-06-06  6:38             ` Masami Hiramatsu
2014-06-17 23:03               ` Tony Luck
2014-06-18  7:56               ` Michael Ellerman
2014-06-18  8:46                 ` Masami Hiramatsu
2014-06-19  1:30                   ` Michael Ellerman
2014-06-19  4:52                     ` Masami Hiramatsu
2014-06-19  6:40                       ` Suzuki K. Poulose
2014-06-19  7:26                         ` Masami Hiramatsu
2014-06-19  9:45                           ` Suzuki K. Poulose
2014-06-19 11:01                             ` Masami Hiramatsu
2014-06-19 11:20                               ` Masami Hiramatsu
2014-06-20  0:37                                 ` Michael Ellerman [this message]
2014-06-20  2:13                                   ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1403224646.18509.1.camel@concordia \
    --to=mpe@ellerman.id.au \
    --cc=akataria@vmware.com \
    --cc=akpm@linux-foundation.org \
    --cc=anil.s.keshavamurthy@intel.com \
    --cc=arnd@arndb.de \
    --cc=chrisw@sous-sol.org \
    --cc=davem@davemloft.net \
    --cc=dl9pf@gmx.de \
    --cc=fenghua.yu@intel.com \
    --cc=haokexin@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@kernel.org \
    --cc=paulus@samba.org \
    --cc=rdunlap@infradead.org \
    --cc=rusty@rustcorp.com.au \
    --cc=sparse@chrisli.org \
    --cc=suzuki@in.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@gmail.com \
    --cc=tony.luck@intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=yrl.pp-manager.tt@hitachi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).