From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1blp0185.outbound.protection.outlook.com [207.46.163.185]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id B090A1A085D for ; Wed, 25 Jun 2014 03:35:14 +1000 (EST) Message-ID: <1403631298.26908.1.camel@snotra.buserror.net> Subject: Re: [PATCH v2 1/2] flexcan: add err_irq handler for flexcan From: Scott Wood To: Zhao Qiang-B45475 Date: Tue, 24 Jun 2014 12:34:58 -0500 In-Reply-To: References: <1403229664-33912-1-git-send-email-B45475@freescale.com> <1403281165.12851.186.camel@snotra.buserror.net> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Cc: "mkl@pengutronix.de" , "linuxppc-dev@lists.ozlabs.org" , "wg@grandegger.com" , "linux-can@vger.kernel.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2014-06-23 at 01:20 -0500, Zhao Qiang-B45475 wrote: > On Sat, 2014-06-21 at 12:19, Wood Scott wrote: > > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Saturday, June 21, 2014 12:19 AM > > To: Zhao Qiang-B45475 > > Cc: linuxppc-dev@lists.ozlabs.org; linux-can@vger.kernel.org; > > wg@grandegger.com; mkl@pengutronix.de; Wood Scott-B07421 > > Subject: Re: [PATCH v2 1/2] flexcan: add err_irq handler for flexcan > > > > On Fri, 2014-06-20 at 10:01 +0800, Zhao Qiang wrote: > > > when flexcan is not physically linked, command 'cantest' will trigger > > > an err_irq, add err_irq handler for it. > > > > > > Signed-off-by: Zhao Qiang > > > --- > > > Changes for v2: > > > - use a space instead of tab > > > - use flexcan_poll_state instead of print > > > > > > drivers/net/can/flexcan.c | 31 ++++++++++++++++++++++++++++++- > > > 1 file changed, 30 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c > > > index f425ec2..7432ba4 100644 > > > --- a/drivers/net/can/flexcan.c > > > +++ b/drivers/net/can/flexcan.c > > > @@ -208,6 +208,7 @@ struct flexcan_priv { > > > void __iomem *base; > > > u32 reg_esr; > > > u32 reg_ctrl_default; > > > + unsigned int err_irq; > > > > Why unsigned? > Err_irq is from 0. So? irqs are plain "int" almost everywhere in the kernel. -Scott