From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alexander Graf <agraf@suse.de>
Cc: kvm@vger.kernel.org,
Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
linux-kernel@vger.kernel.org,
Alex Williamson <alex.williamson@redhat.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] vfio: Fix endianness handling for emulated BARs
Date: Wed, 25 Jun 2014 07:46:14 +1000 [thread overview]
Message-ID: <1403646374.4587.178.camel@pasglop> (raw)
In-Reply-To: <53A955F5.6050801@suse.de>
On Tue, 2014-06-24 at 12:41 +0200, Alexander Graf wrote:
> Is there actually any difference in generated code with this patch
> applied and without? I would hope that iowrite..() is inlined and
> cancels out the cpu_to_le..() calls that are also inlined?
No, the former uses byteswapping asm, the compiler can't "cancel" it
out, but the overhead of the additional byteswap might not be
measurable.
Cheers,
Ben.
prev parent reply other threads:[~2014-06-24 21:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 11:36 [PATCH] vfio: Fix endianness handling for emulated BARs Alexey Kardashevskiy
2014-06-18 18:35 ` Alex Williamson
2014-06-19 0:50 ` Alexey Kardashevskiy
2014-06-19 1:50 ` Alexey Kardashevskiy
2014-06-19 1:50 ` Alexey Kardashevskiy
2014-06-19 3:48 ` Alexey Kardashevskiy
2014-06-19 5:30 ` Bharat.Bhushan
2014-06-19 6:17 ` Alexey Kardashevskiy
2014-06-20 3:21 ` Alex Williamson
2014-06-20 14:14 ` Alexey Kardashevskiy
2014-06-20 23:16 ` Benjamin Herrenschmidt
2014-06-20 23:12 ` Benjamin Herrenschmidt
2014-06-24 10:11 ` Alexey Kardashevskiy
2014-06-24 10:41 ` Alexander Graf
2014-06-24 12:50 ` Alexey Kardashevskiy
2014-06-24 12:52 ` Alexander Graf
2014-06-24 13:01 ` Alexey Kardashevskiy
2014-06-24 13:22 ` Alexander Graf
2014-06-24 14:21 ` Alex Williamson
2014-06-24 14:33 ` Alexey Kardashevskiy
2014-06-24 14:40 ` David Laight
2014-06-24 14:43 ` Alex Williamson
2014-06-24 16:26 ` Alexey Kardashevskiy
2014-06-24 21:54 ` Benjamin Herrenschmidt
2014-06-25 2:43 ` Alexey Kardashevskiy
2014-06-24 21:46 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403646374.4587.178.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nikunj@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).