From: Michael Ellerman <mpe@ellerman.id.au>
To: Preeti U Murthy <preeti@linux.vnet.ibm.com>
Cc: mikey@neuling.org, linux-kernel@vger.kernel.org,
shreyas@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/powernv: Check for IRQHAPPENED before sleeping
Date: Tue, 01 Jul 2014 10:52:06 +1000 [thread overview]
Message-ID: <1404175926.30002.1.camel@concordia> (raw)
In-Reply-To: <20140630062404.29315.23382.stgit@preeti.in.ibm.com>
On Mon, 2014-06-30 at 11:54 +0530, Preeti U Murthy wrote:
> Commit 8d6f7c5a: "powerpc/powernv: Make it possible to skip the IRQHAPPENED
> check in power7_nap()" added code that prevents even cores which enter sleep
> on idle, from checking for pending interrupts. Fix this.
To be clear, it is a bug in the original commit. Mikey and I pair programmed
that code, and he was *definitely* typing at that point ;)
Can you please include in the changelog what the symptom of the bug is, and
have you seen it in practice?
The bad commit went into 3.16-rc1, so we don't need to backport this to any
stable release.
cheers
> diff --git a/arch/powerpc/kernel/idle_power7.S b/arch/powerpc/kernel/idle_power7.S
> index 2480256..5cf3d36 100644
> --- a/arch/powerpc/kernel/idle_power7.S
> +++ b/arch/powerpc/kernel/idle_power7.S
> @@ -131,7 +131,7 @@ _GLOBAL(power7_nap)
>
> _GLOBAL(power7_sleep)
> li r3,1
> - li r4,0
> + li r4,1
> b power7_powersave_common
> /* No return */
>
>
next prev parent reply other threads:[~2014-07-01 0:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 6:24 [PATCH] powerpc/powernv: Check for IRQHAPPENED before sleeping Preeti U Murthy
2014-06-30 14:01 ` Michael Neuling
2014-07-01 0:52 ` Michael Ellerman [this message]
2014-07-01 3:15 ` Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404175926.30002.1.camel@concordia \
--to=mpe@ellerman.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=preeti@linux.vnet.ibm.com \
--cc=shreyas@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).