From: Joel Stanley <joel@jms.id.au>
To: paulus@samba.org, benh@kernel.crashing.org, mpe@ellerman.id.au
Cc: linuxppc-dev@lists.ozlabs.org
Subject: [PATCH 1/3] powerpc/kvm: Remove redundant save of SIER AND MMCR2
Date: Thu, 3 Jul 2014 15:42:34 +0930 [thread overview]
Message-ID: <1404367956-19515-2-git-send-email-joel@jms.id.au> (raw)
In-Reply-To: <1404367956-19515-1-git-send-email-joel@jms.id.au>
These two registers are already saved in the block above. Aside from
being unnecessary, by the time we get down to the second save location
r8 no longer contains MMCR2, so we are clobbering the saved value with
PMC5.
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
arch/powerpc/kvm/book3s_hv_interrupts.S | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/powerpc/kvm/book3s_hv_interrupts.S b/arch/powerpc/kvm/book3s_hv_interrupts.S
index 8c86422..731be74 100644
--- a/arch/powerpc/kvm/book3s_hv_interrupts.S
+++ b/arch/powerpc/kvm/book3s_hv_interrupts.S
@@ -127,11 +127,6 @@ BEGIN_FTR_SECTION
stw r10, HSTATE_PMC + 24(r13)
stw r11, HSTATE_PMC + 28(r13)
END_FTR_SECTION_IFSET(CPU_FTR_ARCH_201)
-BEGIN_FTR_SECTION
- mfspr r9, SPRN_SIER
- std r8, HSTATE_MMCR + 40(r13)
- std r9, HSTATE_MMCR + 48(r13)
-END_FTR_SECTION_IFSET(CPU_FTR_ARCH_207S)
31:
/*
--
2.0.0
next prev parent reply other threads:[~2014-07-03 6:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 6:12 [PATCH 0/3] POWER8 PMU bugfixes Joel Stanley
2014-07-03 6:12 ` Joel Stanley [this message]
2014-07-04 2:16 ` [PATCH 1/3] powerpc/kvm: Remove redundant save of SIER AND MMCR2 Michael Ellerman
2014-07-04 7:46 ` Paul Mackerras
2014-07-04 7:57 ` Alexander Graf
2014-07-03 6:12 ` [PATCH 2/3] powerpc/perf: Add PPMU_ARCH_207S define Joel Stanley
2014-07-04 2:34 ` Michael Ellerman
2014-07-03 6:12 ` [PATCH 3/3] powerpc/perf: Clear MMCR2 when enabling PMU Joel Stanley
2014-07-04 2:36 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404367956-19515-2-git-send-email-joel@jms.id.au \
--to=joel@jms.id.au \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).