* [PATCH] devicetree/bindings: Add binding for micron n25q512a memory @ 2014-07-03 10:12 Priyanka Jain 2014-07-03 22:10 ` Scott Wood 0 siblings, 1 reply; 7+ messages in thread From: Priyanka Jain @ 2014-07-03 10:12 UTC (permalink / raw) To: devicetree, linuxppc-dev, scottwood; +Cc: Priyanka Jain -Micron n25q512a memory is supported by m25p80 driver. Add compatible field required to support n25q512a in m25p80.txt -Add micron to the vendor-prefixes.txt file Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com> --- Documentation/devicetree/bindings/mtd/m25p80.txt | 1 + .../devicetree/bindings/vendor-prefixes.txt | 1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/Documentation/devicetree/bindings/mtd/m25p80.txt b/Documentation/devicetree/bindings/mtd/m25p80.txt index 4611aa8..ce02e81 100644 --- a/Documentation/devicetree/bindings/mtd/m25p80.txt +++ b/Documentation/devicetree/bindings/mtd/m25p80.txt @@ -7,6 +7,7 @@ Required properties: the DT binding is not Linux-only, but in case of Linux, see the "spi_nor_ids" table in drivers/mtd/spi-nor/spi-nor.c for the list of supported chips. + example: "micron,n25q512a" - reg : Chip-Select number - spi-max-frequency : Maximum frequency of the SPI bus the chip can operate at diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index 4d7f375..a44cfee 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.txt +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -79,6 +79,7 @@ marvell Marvell Technology Group Ltd. maxim Maxim Integrated Products micrel Micrel Inc. microchip Microchip Technology Inc. +micron Micron Technology Inc. mosaixtech Mosaix Technologies, Inc. moxa Moxa mpl MPL AG -- 1.7.4.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] devicetree/bindings: Add binding for micron n25q512a memory 2014-07-03 10:12 [PATCH] devicetree/bindings: Add binding for micron n25q512a memory Priyanka Jain @ 2014-07-03 22:10 ` Scott Wood 2014-07-04 4:08 ` Priyanka Jain 0 siblings, 1 reply; 7+ messages in thread From: Scott Wood @ 2014-07-03 22:10 UTC (permalink / raw) To: Priyanka Jain; +Cc: devicetree, linuxppc-dev, linux-mtd, linux-spi On Thu, 2014-07-03 at 15:42 +0530, Priyanka Jain wrote: > -Micron n25q512a memory is supported by m25p80 driver. > Add compatible field required to support n25q512a in m25p80.txt > -Add micron to the vendor-prefixes.txt file > > Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com> > --- > Documentation/devicetree/bindings/mtd/m25p80.txt | 1 + > .../devicetree/bindings/vendor-prefixes.txt | 1 + > 2 files changed, 2 insertions(+), 0 deletions(-) Why did you send this to the ppc list but not the spi or mtd lists? I'm having a hard time following the flow of how these SPI devices get bound -- is the compatible involved at all? I don't see this string (with vendor prefix included) in the driver. I do see a table that contains what looks like device IDs. If the device can report its id, shouldn't we rely on that rather than device tree compatible? -Scott > diff --git a/Documentation/devicetree/bindings/mtd/m25p80.txt b/Documentation/devicetree/bindings/mtd/m25p80.txt > index 4611aa8..ce02e81 100644 > --- a/Documentation/devicetree/bindings/mtd/m25p80.txt > +++ b/Documentation/devicetree/bindings/mtd/m25p80.txt > @@ -7,6 +7,7 @@ Required properties: > the DT binding is not Linux-only, but in case of Linux, see the > "spi_nor_ids" table in drivers/mtd/spi-nor/spi-nor.c for the list > of supported chips. > + example: "micron,n25q512a" > - reg : Chip-Select number > - spi-max-frequency : Maximum frequency of the SPI bus the chip can operate at > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt > index 4d7f375..a44cfee 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt > @@ -79,6 +79,7 @@ marvell Marvell Technology Group Ltd. > maxim Maxim Integrated Products > micrel Micrel Inc. > microchip Microchip Technology Inc. > +micron Micron Technology Inc. > mosaixtech Mosaix Technologies, Inc. > moxa Moxa > mpl MPL AG ^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] devicetree/bindings: Add binding for micron n25q512a memory 2014-07-03 22:10 ` Scott Wood @ 2014-07-04 4:08 ` Priyanka Jain 2014-07-07 21:25 ` Scott Wood 0 siblings, 1 reply; 7+ messages in thread From: Priyanka Jain @ 2014-07-04 4:08 UTC (permalink / raw) To: Scott Wood Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0 MjENCj4gU2VudDogRnJpZGF5LCBKdWx5IDA0LCAyMDE0IDM6NDAgQU0NCj4gVG86IEphaW4gUHJp eWFua2EtQjMyMTY3DQo+IENjOiBkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZzsgbGludXhwcGMt ZGV2QGxpc3RzLm96bGFicy5vcmc7IGxpbnV4LQ0KPiBzcGlAdmdlci5rZXJuZWwub3JnOyBsaW51 eC1tdGRAbGlzdHMuaW5mcmFkZWFkLm9yZw0KPiBTdWJqZWN0OiBSZTogW1BBVENIXSBkZXZpY2V0 cmVlL2JpbmRpbmdzOiBBZGQgYmluZGluZyBmb3IgbWljcm9uIG4yNXE1MTJhDQo+IG1lbW9yeQ0K PiANCj4gT24gVGh1LCAyMDE0LTA3LTAzIGF0IDE1OjQyICswNTMwLCBQcml5YW5rYSBKYWluIHdy b3RlOg0KPiA+IC1NaWNyb24gbjI1cTUxMmEgbWVtb3J5IGlzIHN1cHBvcnRlZCBieSBtMjVwODAg ZHJpdmVyLg0KPiA+ICBBZGQgY29tcGF0aWJsZSBmaWVsZCByZXF1aXJlZCB0byBzdXBwb3J0IG4y NXE1MTJhIGluIG0yNXA4MC50eHQgLUFkZA0KPiA+IG1pY3JvbiB0byB0aGUgdmVuZG9yLXByZWZp eGVzLnR4dCBmaWxlDQo+ID4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBQcml5YW5rYSBKYWluIDxQcml5 YW5rYS5KYWluQGZyZWVzY2FsZS5jb20+DQo+ID4gLS0tDQo+ID4gIERvY3VtZW50YXRpb24vZGV2 aWNldHJlZS9iaW5kaW5ncy9tdGQvbTI1cDgwLnR4dCAgIHwgICAgMSArDQo+ID4gIC4uLi9kZXZp Y2V0cmVlL2JpbmRpbmdzL3ZlbmRvci1wcmVmaXhlcy50eHQgICAgICAgIHwgICAgMSArDQo+ID4g IDIgZmlsZXMgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQ0KPiANCj4g V2h5IGRpZCB5b3Ugc2VuZCB0aGlzIHRvIHRoZSBwcGMgbGlzdCBidXQgbm90IHRoZSBzcGkgb3Ig bXRkIGxpc3RzPw0KPiANCltKYWluIFByaXlhbmthLUIzMjE2N10gU29ycnksIEkgbWlzc2VkIHRo YXQNCj4gSSdtIGhhdmluZyBhIGhhcmQgdGltZSBmb2xsb3dpbmcgdGhlIGZsb3cgb2YgaG93IHRo ZXNlIFNQSSBkZXZpY2VzIGdldA0KPiBib3VuZCAtLSBpcyB0aGUgY29tcGF0aWJsZSBpbnZvbHZl ZCBhdCBhbGw/ICBJIGRvbid0IHNlZSB0aGlzIHN0cmluZw0KPiAod2l0aCB2ZW5kb3IgcHJlZml4 IGluY2x1ZGVkKSBpbiB0aGUgZHJpdmVyLiAgSSBkbyBzZWUgYSB0YWJsZSB0aGF0DQo+IGNvbnRh aW5zIHdoYXQgbG9va3MgbGlrZSBkZXZpY2UgSURzLiAgSWYgdGhlIGRldmljZSBjYW4gcmVwb3J0 IGl0cyBpZCwNCj4gc2hvdWxkbid0IHdlIHJlbHkgb24gdGhhdCByYXRoZXIgdGhhbiBkZXZpY2Ug dHJlZSBjb21wYXRpYmxlPw0KPiANCj4gLVNjb3R0DQpbSmFpbiBQcml5YW5rYS1CMzIxNjddDQpT cGkgZHJpdmVyIGhhcyBhIGNoZWNrIHRvIGRldmljZSBuYW1lIGNvcnJlc3BvbmRpbmcgdG8gZGV2 aWNlLWlkIGFuZCBjb21wYXJlIHRvIHdoYXQgaXMgcGFzc2VkIGluIGR0cyBzdHJpbmcuDQpOZXcg Y2hlY2twYXRjaCBzY3JpcHQgc2VhcmNoIGZvciBleGFjdCBzdHJpbmcgbWF0Y2ggaW4gYmluZGlu ZyBmb2xkZXIuIFNvLCBJIGhhdmUgYWRkZWQgdGhpcyBpbiBleGFtcGxlLg0KPiANCj4gDQo+ID4g ZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tdGQvbTI1cDgw LnR4dA0KPiA+IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL210ZC9tMjVwODAu dHh0DQo+ID4gaW5kZXggNDYxMWFhOC4uY2UwMmU4MSAxMDA2NDQNCj4gPiAtLS0gYS9Eb2N1bWVu dGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbXRkL20yNXA4MC50eHQNCj4gPiArKysgYi9Eb2N1 bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbXRkL20yNXA4MC50eHQNCj4gPiBAQCAtNyw2 ICs3LDcgQEAgUmVxdWlyZWQgcHJvcGVydGllczoNCj4gPiAgICAgICAgICAgICAgICAgdGhlIERU IGJpbmRpbmcgaXMgbm90IExpbnV4LW9ubHksIGJ1dCBpbiBjYXNlIG9mIExpbnV4LA0KPiBzZWUg dGhlDQo+ID4gICAgICAgICAgICAgICAgICJzcGlfbm9yX2lkcyIgdGFibGUgaW4gZHJpdmVycy9t dGQvc3BpLW5vci9zcGktbm9yLmMNCj4gZm9yIHRoZSBsaXN0DQo+ID4gICAgICAgICAgICAgICAg IG9mIHN1cHBvcnRlZCBjaGlwcy4NCj4gPiArICAgICAgICAgICAgICAgZXhhbXBsZTogIm1pY3Jv bixuMjVxNTEyYSINCj4gPiAgLSByZWcgOiBDaGlwLVNlbGVjdCBudW1iZXINCj4gPiAgLSBzcGkt bWF4LWZyZXF1ZW5jeSA6IE1heGltdW0gZnJlcXVlbmN5IG9mIHRoZSBTUEkgYnVzIHRoZSBjaGlw IGNhbg0KPiA+IG9wZXJhdGUgYXQNCj4gPg0KPiA+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvdmVuZG9yLXByZWZpeGVzLnR4dA0KPiA+IGIvRG9jdW1lbnRh dGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3ZlbmRvci1wcmVmaXhlcy50eHQNCj4gPiBpbmRleCA0 ZDdmMzc1Li5hNDRjZmVlIDEwMDY0NA0KPiA+IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncy92ZW5kb3ItcHJlZml4ZXMudHh0DQo+ID4gKysrIGIvRG9jdW1lbnRhdGlvbi9k ZXZpY2V0cmVlL2JpbmRpbmdzL3ZlbmRvci1wcmVmaXhlcy50eHQNCj4gPiBAQCAtNzksNiArNzks NyBAQCBtYXJ2ZWxsCU1hcnZlbGwgVGVjaG5vbG9neSBHcm91cCBMdGQuDQo+ID4gIG1heGltCU1h eGltIEludGVncmF0ZWQgUHJvZHVjdHMNCj4gPiAgbWljcmVsCU1pY3JlbCBJbmMuDQo+ID4gIG1p Y3JvY2hpcAlNaWNyb2NoaXAgVGVjaG5vbG9neSBJbmMuDQo+ID4gK21pY3JvbglNaWNyb24gVGVj aG5vbG9neSBJbmMuDQo+ID4gIG1vc2FpeHRlY2gJTW9zYWl4IFRlY2hub2xvZ2llcywgSW5jLg0K PiA+ICBtb3hhCU1veGENCj4gPiAgbXBsCU1QTCBBRw0KPiANCg0K ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] devicetree/bindings: Add binding for micron n25q512a memory 2014-07-04 4:08 ` Priyanka Jain @ 2014-07-07 21:25 ` Scott Wood 2014-07-08 4:41 ` Priyanka Jain 2014-07-29 9:24 ` Mark Rutland 0 siblings, 2 replies; 7+ messages in thread From: Scott Wood @ 2014-07-07 21:25 UTC (permalink / raw) To: Jain Priyanka-B32167 Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org On Thu, 2014-07-03 at 23:08 -0500, Jain Priyanka-B32167 wrote: > > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Friday, July 04, 2014 3:40 AM > > To: Jain Priyanka-B32167 > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; linux- > > spi@vger.kernel.org; linux-mtd@lists.infradead.org > > Subject: Re: [PATCH] devicetree/bindings: Add binding for micron n25q512a > > memory > > > > On Thu, 2014-07-03 at 15:42 +0530, Priyanka Jain wrote: > > > -Micron n25q512a memory is supported by m25p80 driver. > > > Add compatible field required to support n25q512a in m25p80.txt -Add > > > micron to the vendor-prefixes.txt file > > > > > > Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com> > > > --- > > > Documentation/devicetree/bindings/mtd/m25p80.txt | 1 + > > > .../devicetree/bindings/vendor-prefixes.txt | 1 + > > > 2 files changed, 2 insertions(+), 0 deletions(-) > > > > Why did you send this to the ppc list but not the spi or mtd lists? > > > [Jain Priyanka-B32167] Sorry, I missed that > > I'm having a hard time following the flow of how these SPI devices get > > bound -- is the compatible involved at all? I don't see this string > > (with vendor prefix included) in the driver. I do see a table that > > contains what looks like device IDs. If the device can report its id, > > shouldn't we rely on that rather than device tree compatible? > > > > -Scott > [Jain Priyanka-B32167] > Spi driver has a check to device name corresponding to device-id and compare to what is passed in dts string. Please go into more detail. I don't see where the string "micron,n25q512a" appears in the current kernel. I do see "n25q512a", but how does that compare successfully with the version of the string that has a vendor compatible? Again, is there a device ID that can be read at runtime? Is there a compatible string that represents a common programming interface? > New checkpatch script search for exact string match in binding folder. So, I have added this in example. That check has a lot of false positives when it comes to compatible strings for specific chips that don't need to be specifically mentioned in a more generic binding. -Scott ^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] devicetree/bindings: Add binding for micron n25q512a memory 2014-07-07 21:25 ` Scott Wood @ 2014-07-08 4:41 ` Priyanka Jain 2014-07-09 1:53 ` Scott Wood 2014-07-29 9:24 ` Mark Rutland 1 sibling, 1 reply; 7+ messages in thread From: Priyanka Jain @ 2014-07-08 4:41 UTC (permalink / raw) To: Scott Wood Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0 MjENCj4gU2VudDogVHVlc2RheSwgSnVseSAwOCwgMjAxNCAyOjU2IEFNDQo+IFRvOiBKYWluIFBy aXlhbmthLUIzMjE2Nw0KPiBDYzogZGV2aWNldHJlZUB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4cHBj LWRldkBsaXN0cy5vemxhYnMub3JnOyBsaW51eC0NCj4gc3BpQHZnZXIua2VybmVsLm9yZzsgbGlu dXgtbXRkQGxpc3RzLmluZnJhZGVhZC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSF0gZGV2aWNl dHJlZS9iaW5kaW5nczogQWRkIGJpbmRpbmcgZm9yIG1pY3JvbiBuMjVxNTEyYQ0KPiBtZW1vcnkN Cj4gDQo+IE9uIFRodSwgMjAxNC0wNy0wMyBhdCAyMzowOCAtMDUwMCwgSmFpbiBQcml5YW5rYS1C MzIxNjcgd3JvdGU6DQo+ID4NCj4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4g PiBGcm9tOiBXb29kIFNjb3R0LUIwNzQyMQ0KPiA+ID4gU2VudDogRnJpZGF5LCBKdWx5IDA0LCAy MDE0IDM6NDAgQU0NCj4gPiA+IFRvOiBKYWluIFByaXlhbmthLUIzMjE2Nw0KPiA+ID4gQ2M6IGRl dmljZXRyZWVAdmdlci5rZXJuZWwub3JnOyBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZzsN Cj4gPiA+IGxpbnV4LSBzcGlAdmdlci5rZXJuZWwub3JnOyBsaW51eC1tdGRAbGlzdHMuaW5mcmFk ZWFkLm9yZw0KPiA+ID4gU3ViamVjdDogUmU6IFtQQVRDSF0gZGV2aWNldHJlZS9iaW5kaW5nczog QWRkIGJpbmRpbmcgZm9yIG1pY3Jvbg0KPiA+ID4gbjI1cTUxMmEgbWVtb3J5DQo+ID4gPg0KPiA+ ID4gT24gVGh1LCAyMDE0LTA3LTAzIGF0IDE1OjQyICswNTMwLCBQcml5YW5rYSBKYWluIHdyb3Rl Og0KPiA+ID4gPiAtTWljcm9uIG4yNXE1MTJhIG1lbW9yeSBpcyBzdXBwb3J0ZWQgYnkgbTI1cDgw IGRyaXZlci4NCj4gPiA+ID4gIEFkZCBjb21wYXRpYmxlIGZpZWxkIHJlcXVpcmVkIHRvIHN1cHBv cnQgbjI1cTUxMmEgaW4gbTI1cDgwLnR4dA0KPiA+ID4gPiAtQWRkIG1pY3JvbiB0byB0aGUgdmVu ZG9yLXByZWZpeGVzLnR4dCBmaWxlDQo+ID4gPiA+DQo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IFBy aXlhbmthIEphaW4gPFByaXlhbmthLkphaW5AZnJlZXNjYWxlLmNvbT4NCj4gPiA+ID4gLS0tDQo+ ID4gPiA+ICBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbXRkL20yNXA4MC50eHQg ICB8ICAgIDEgKw0KPiA+ID4gPiAgLi4uL2RldmljZXRyZWUvYmluZGluZ3MvdmVuZG9yLXByZWZp eGVzLnR4dCAgICAgICAgfCAgICAxICsNCj4gPiA+ID4gIDIgZmlsZXMgY2hhbmdlZCwgMiBpbnNl cnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQ0KPiA+ID4NCj4gPiA+IFdoeSBkaWQgeW91IHNlbmQg dGhpcyB0byB0aGUgcHBjIGxpc3QgYnV0IG5vdCB0aGUgc3BpIG9yIG10ZCBsaXN0cz8NCj4gPiA+ DQo+ID4gW0phaW4gUHJpeWFua2EtQjMyMTY3XSBTb3JyeSwgSSBtaXNzZWQgdGhhdA0KPiA+ID4g SSdtIGhhdmluZyBhIGhhcmQgdGltZSBmb2xsb3dpbmcgdGhlIGZsb3cgb2YgaG93IHRoZXNlIFNQ SSBkZXZpY2VzDQo+ID4gPiBnZXQgYm91bmQgLS0gaXMgdGhlIGNvbXBhdGlibGUgaW52b2x2ZWQg YXQgYWxsPyAgSSBkb24ndCBzZWUgdGhpcw0KPiA+ID4gc3RyaW5nICh3aXRoIHZlbmRvciBwcmVm aXggaW5jbHVkZWQpIGluIHRoZSBkcml2ZXIuICBJIGRvIHNlZSBhDQo+ID4gPiB0YWJsZSB0aGF0 IGNvbnRhaW5zIHdoYXQgbG9va3MgbGlrZSBkZXZpY2UgSURzLiAgSWYgdGhlIGRldmljZSBjYW4N Cj4gPiA+IHJlcG9ydCBpdHMgaWQsIHNob3VsZG4ndCB3ZSByZWx5IG9uIHRoYXQgcmF0aGVyIHRo YW4gZGV2aWNlIHRyZWUNCj4gY29tcGF0aWJsZT8NCj4gPiA+DQo+ID4gPiAtU2NvdHQNCj4gPiBb SmFpbiBQcml5YW5rYS1CMzIxNjddDQo+ID4gU3BpIGRyaXZlciBoYXMgYSBjaGVjayB0byBkZXZp Y2UgbmFtZSBjb3JyZXNwb25kaW5nIHRvIGRldmljZS1pZCBhbmQNCj4gY29tcGFyZSB0byB3aGF0 IGlzIHBhc3NlZCBpbiBkdHMgc3RyaW5nLg0KPiANCj4gUGxlYXNlIGdvIGludG8gbW9yZSBkZXRh aWwuICBJIGRvbid0IHNlZSB3aGVyZSB0aGUgc3RyaW5nDQo+ICJtaWNyb24sbjI1cTUxMmEiIGFw cGVhcnMgaW4gdGhlIGN1cnJlbnQga2VybmVsLiAgSSBkbyBzZWUgIm4yNXE1MTJhIiwNCj4gYnV0 IGhvdyBkb2VzIHRoYXQgY29tcGFyZSBzdWNjZXNzZnVsbHkgd2l0aCB0aGUgdmVyc2lvbiBvZiB0 aGUgc3RyaW5nDQo+IHRoYXQgaGFzIGEgdmVuZG9yIGNvbXBhdGlibGU/DQo+IA0KPiBBZ2Fpbiwg aXMgdGhlcmUgYSBkZXZpY2UgSUQgdGhhdCBjYW4gYmUgcmVhZCBhdCBydW50aW1lPyAgSXMgdGhl cmUgYQ0KPiBjb21wYXRpYmxlIHN0cmluZyB0aGF0IHJlcHJlc2VudHMgYSBjb21tb24gcHJvZ3Jh bW1pbmcgaW50ZXJmYWNlPw0KW0phaW4gUHJpeWFua2EtQjMyMTY3XSANClNwaSBkcml2ZXIgKG9m X3JlZ2lzdGVyX3NwaV9kZXZpY2VzKCkpIHNlYXJjaCBmb3IgY29tcGF0aWJsZSBzdHJpbmcgaW4g ZGV2aWNlLXRyZWUuIEl0IHNlbGVjdHMgdGhlIGZsYXNoIGRldmljZSBkcml2ZXIgYmFzZWQgb24g dGhlIGNvbXBhdGlibGUgc3RyaW5nIChuMjVxNTEyYSkuIFRoaXMgY29tcGF0aWJsZSBzdHJpbmcg aXMgZXNzZW50aWFsLCBlbHNlIGRldmljZSBwcm9iZSB3b250IGNvbnRpbnVlLiAgVGhlbiBEZXZp Y2UtaWQgb2YgZmxhc2ggaXMgcmVhZCBhdCBydW50aW1lIGluIHByb2JlIGFuZCBjb21wYXJlZCB3 aXRoIHRoZSBjb3JyZXNwb25kaW5nIGRldmljZS1pZCBvZiBmbGFzaCAobjI1cTUxMmEpLiBEZXZp Y2UtaWQgKG1haW50YWluZWQgYXMgZmlyc3QgZWxlbWVudCBpbiBJTkZPIHN0cmluZyBpbiBzcGlf bm9yX2lkc1tdIGluIGRyaXZlcnMvbXRkL3NwaS1ub3Ivc3BpLW5vci5jIGZpbGUpDQpPbmx5IGlm IGJvdGggZGV2aWNlLWlkcyBtYXRjaCwgdGhlIGRldmljZSBpcyB0YWtlbiBhcyBzdWNjZXNzZnVs bHkgZGV0ZWN0ZWQuDQpSZWdhcmRpbmcgdmVuZG9yICJtaWNyb24iLCB5b3UgYXJlIHJpZ2h0IGN1 cnJlbnRseSB0aGUgdmVuZG9yIGluZm9ybWF0aW9uIGlzIG5vdCBtYWludGFpbmVkIGFzIHN1Y2gg aW4gZGV2aWNlLWlkLCBidXQgdGhlIGNvbnZlbnRpb24gdGhhdCBpcyBmb2xsb3dlZCBmb3IgY29t cGF0aWJsZSBzdHJpbmcgaXMgInZlbmRvci1pZCwgZGV2aWNlLWlkIg0KPiANCj4gPiBOZXcgY2hl Y2twYXRjaCBzY3JpcHQgc2VhcmNoIGZvciBleGFjdCBzdHJpbmcgbWF0Y2ggaW4gYmluZGluZyBm b2xkZXIuDQo+IFNvLCBJIGhhdmUgYWRkZWQgdGhpcyBpbiBleGFtcGxlLg0KPiANCj4gVGhhdCBj aGVjayBoYXMgYSBsb3Qgb2YgZmFsc2UgcG9zaXRpdmVzIHdoZW4gaXQgY29tZXMgdG8gY29tcGF0 aWJsZQ0KPiBzdHJpbmdzIGZvciBzcGVjaWZpYyBjaGlwcyB0aGF0IGRvbid0IG5lZWQgdG8gYmUg c3BlY2lmaWNhbGx5IG1lbnRpb25lZA0KPiBpbiBhIG1vcmUgZ2VuZXJpYyBiaW5kaW5nLg0KPiAN Cj4gLVNjb3R0DQo+IA0KW0phaW4gUHJpeWFua2EtQjMyMTY3XSBFdmVuIHRob3VnaCAibWljcm9u LG4yNXE1MTJhIiBpcyBpbiBzeW5jIHdpdGggYmluZGluZyBtZW50aW9uZWQgaW4gIiBEb2N1bWVu dGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbXRkL20yNXA4MC50eHQgICAiLCBJIGhhdmUgdG8g YWRkIHRoaXMgYXMgYW4gYSBleGFtcGxlLCBqdXN0IHRvIGF2b2lkIGNoZWNrcGF0Y2ggZXJyb3Iu IFdoYXQgc2hvdWxkIGJlIHRoZSBhcHByb2FjaCBnb2luZyBmb3J3YXJkOiBTaG91bGQgc3VjaCBj aGVja3BhdGNoIHdhcm5pbmdzIGJlIGlnbm9yZWQ/DQoNCg0KDQoNCg== ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] devicetree/bindings: Add binding for micron n25q512a memory 2014-07-08 4:41 ` Priyanka Jain @ 2014-07-09 1:53 ` Scott Wood 0 siblings, 0 replies; 7+ messages in thread From: Scott Wood @ 2014-07-09 1:53 UTC (permalink / raw) To: Jain Priyanka-B32167 Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org On Mon, 2014-07-07 at 23:41 -0500, Jain Priyanka-B32167 wrote: > > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Tuesday, July 08, 2014 2:56 AM > > To: Jain Priyanka-B32167 > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; linux- > > spi@vger.kernel.org; linux-mtd@lists.infradead.org > > Subject: Re: [PATCH] devicetree/bindings: Add binding for micron n25q512a > > memory > > > > On Thu, 2014-07-03 at 23:08 -0500, Jain Priyanka-B32167 wrote: > > > > > > > -----Original Message----- > > > > From: Wood Scott-B07421 > > > > Sent: Friday, July 04, 2014 3:40 AM > > > > To: Jain Priyanka-B32167 > > > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > > > linux- spi@vger.kernel.org; linux-mtd@lists.infradead.org > > > > Subject: Re: [PATCH] devicetree/bindings: Add binding for micron > > > > n25q512a memory > > > > > > > > On Thu, 2014-07-03 at 15:42 +0530, Priyanka Jain wrote: > > > > > -Micron n25q512a memory is supported by m25p80 driver. > > > > > Add compatible field required to support n25q512a in m25p80.txt > > > > > -Add micron to the vendor-prefixes.txt file > > > > > > > > > > Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com> > > > > > --- > > > > > Documentation/devicetree/bindings/mtd/m25p80.txt | 1 + > > > > > .../devicetree/bindings/vendor-prefixes.txt | 1 + > > > > > 2 files changed, 2 insertions(+), 0 deletions(-) > > > > > > > > Why did you send this to the ppc list but not the spi or mtd lists? > > > > > > > [Jain Priyanka-B32167] Sorry, I missed that > > > > I'm having a hard time following the flow of how these SPI devices > > > > get bound -- is the compatible involved at all? I don't see this > > > > string (with vendor prefix included) in the driver. I do see a > > > > table that contains what looks like device IDs. If the device can > > > > report its id, shouldn't we rely on that rather than device tree > > compatible? > > > > > > > > -Scott > > > [Jain Priyanka-B32167] > > > Spi driver has a check to device name corresponding to device-id and > > compare to what is passed in dts string. > > > > Please go into more detail. I don't see where the string > > "micron,n25q512a" appears in the current kernel. I do see "n25q512a", > > but how does that compare successfully with the version of the string > > that has a vendor compatible? > > > > Again, is there a device ID that can be read at runtime? Is there a > > compatible string that represents a common programming interface? > [Jain Priyanka-B32167] > > Spi driver (of_register_spi_devices()) search for compatible string in > device-tree. It selects the flash device driver based on the compatible > string (n25q512a). This compatible string is essential, else device > probe wont continue. Then Device-id of flash is read at runtime in > probe and compared with the corresponding device-id of flash > (n25q512a). Device-id (maintained as first element in INFO string in > spi_nor_ids[] in drivers/mtd/spi-nor/spi-nor.c file) By "device id" I'm talking about 0x20bb20, not "n25q512a". Where does that come from? > Only if both device-ids match, the device is taken as successfully > detected. Regarding vendor "micron", you are right currently the vendor > information is not maintained as such in device-id, but the convention > that is followed for compatible string is "vendor-id, device-id" Is there going to be a patch to the driver to accept the string with vendor id? > > > New checkpatch script search for exact string match in binding folder. > > So, I have added this in example. > > > > That check has a lot of false positives when it comes to compatible > > strings for specific chips that don't need to be specifically mentioned > > in a more generic binding. > > > > -Scott > > > [Jain Priyanka-B32167] Even though "micron,n25q512a" is in sync with > binding mentioned in " > Documentation/devicetree/bindings/mtd/m25p80.txt ", I have to add > this as an a example, just to avoid checkpatch error. What should be > the approach going forward: Should such checkpatch warnings be ignored? They shouldn't be ignored nor blindly remedied. You should look at the message and decide whether a binding is needed and whether it is present. There probably should be a binding here, but I don't have enough information to say whether it should be specific to n25q512a or if spi nor can be described more generically. -Scott ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] devicetree/bindings: Add binding for micron n25q512a memory 2014-07-07 21:25 ` Scott Wood 2014-07-08 4:41 ` Priyanka Jain @ 2014-07-29 9:24 ` Mark Rutland 1 sibling, 0 replies; 7+ messages in thread From: Mark Rutland @ 2014-07-29 9:24 UTC (permalink / raw) To: Scott Wood Cc: Jain Priyanka-B32167, linux-spi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org On Mon, Jul 07, 2014 at 10:25:54PM +0100, Scott Wood wrote: > On Thu, 2014-07-03 at 23:08 -0500, Jain Priyanka-B32167 wrote: > > > > > -----Original Message----- > > > From: Wood Scott-B07421 > > > Sent: Friday, July 04, 2014 3:40 AM > > > To: Jain Priyanka-B32167 > > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; linux- > > > spi@vger.kernel.org; linux-mtd@lists.infradead.org > > > Subject: Re: [PATCH] devicetree/bindings: Add binding for micron n25q512a > > > memory > > > > > > On Thu, 2014-07-03 at 15:42 +0530, Priyanka Jain wrote: > > > > -Micron n25q512a memory is supported by m25p80 driver. > > > > Add compatible field required to support n25q512a in m25p80.txt -Add > > > > micron to the vendor-prefixes.txt file > > > > > > > > Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com> > > > > --- > > > > Documentation/devicetree/bindings/mtd/m25p80.txt | 1 + > > > > .../devicetree/bindings/vendor-prefixes.txt | 1 + > > > > 2 files changed, 2 insertions(+), 0 deletions(-) > > > > > > Why did you send this to the ppc list but not the spi or mtd lists? > > > > > [Jain Priyanka-B32167] Sorry, I missed that > > > I'm having a hard time following the flow of how these SPI devices get > > > bound -- is the compatible involved at all? I don't see this string > > > (with vendor prefix included) in the driver. I do see a table that > > > contains what looks like device IDs. If the device can report its id, > > > shouldn't we rely on that rather than device tree compatible? > > > > > > -Scott > > [Jain Priyanka-B32167] > > Spi driver has a check to device name corresponding to device-id and compare to what is passed in dts string. > > Please go into more detail. I don't see where the string > "micron,n25q512a" appears in the current kernel. I do see "n25q512a", > but how does that compare successfully with the version of the string > that has a vendor compatible? The spi code has a hack to not require an of_device_id_table: of_register_spi_devices calls of_modalias_node, which for a given "foo,bar" compatible string will set spi->modalias to "bar", by cutting off everything up to and including the comma. Later, spi_match_id can match a device with an spi_device_id->name of "bar". Thus "micron,n25q512a" can match one of the entries already in drivers/mtd/spi-nor/spi-nor.c. This is a real pain when searching around. Thanks, Mark. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-07-29 9:25 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-07-03 10:12 [PATCH] devicetree/bindings: Add binding for micron n25q512a memory Priyanka Jain 2014-07-03 22:10 ` Scott Wood 2014-07-04 4:08 ` Priyanka Jain 2014-07-07 21:25 ` Scott Wood 2014-07-08 4:41 ` Priyanka Jain 2014-07-09 1:53 ` Scott Wood 2014-07-29 9:24 ` Mark Rutland
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).