Re: [PATCH] devicetree/bindings/powerpc/fsl: Add binding for board

[Scott Wood <scottwood@freescale.com>]

On Mon, 2014-07-07 at 22:56 -0500, Jain Priyanka-B32167 wrote:
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Tuesday, July 08, 2014 3:00 AM
> > To: Jain Priyanka-B32167
> > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > Subject: Re: [PATCH] devicetree/bindings/powerpc/fsl: Add binding for
> > board
> > 
> > On Mon, 2014-07-07 at 14:06 +0530, Priyanka Jain wrote:
> > > Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com>
> > > ---
> > >  .../devicetree/bindings/powerpc/fsl/board.txt      |   17
> > ++++++++++++++++-
> > >  1 files changed, 16 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/board.txt
> > > b/Documentation/devicetree/bindings/powerpc/fsl/board.txt
> > > index f35f295..7800729 100644
> > > --- a/Documentation/devicetree/bindings/powerpc/fsl/board.txt
> > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/board.txt
> > > @@ -1,8 +1,23 @@
> > >  Freescale Reference Board Bindings
> > >
> > > -This document describes device tree bindings for various devices that
> > > +This document describes device tree bindings for board and  various
> > > +devices that
> > >  exist on some Freescale reference boards.
> > >
> > > +* Board node
> > > +Required properties:
> > > +
> > > + - model : Should be "fsl,<board>"
> > > + - compatible : Should be "fsl,<board>"
> > > +	example: "fsl,T1040RDB", "fsl,T1042RDB", "fsl,T1042RDB_PI"
> > > +		 "fsl,T1040QDS", "fsl,T1042QDS"
> > > +
> > > +Example:
> > > +
> > > +/ {
> > > +	model = "fsl,T1040RDB";
> > > +	compatible = "fsl,T1040RDB";
> > > +};
> > 
> > We really don't need to do this for every board just to satisfy
> > checkpatch.
> > 
> > -Scott
> > 
> [Jain Priyanka-B32167] Is it OK to submit a patch with board checkpatch warning for this case ?

If you mean "is it OK to submit a board patch that has checkpatch
warnings of this sort, where the compatible follows a well established
pattern", then yes.

-Scott