linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: linuxppc-dev@lists.ozlabs.org
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
	Paul Mackerras <paulus@samba.org>,
	Gavin Shan <gwshan@linux.vnet.ibm.com>
Subject: [PATCH QEMU 01/12] spapr_iommu: Disable in-kernel IOMMU tables for >4GB windows
Date: Tue, 15 Jul 2014 19:39:33 +1000	[thread overview]
Message-ID: <1405417184-14333-2-git-send-email-aik@ozlabs.ru> (raw)
In-Reply-To: <1405417184-14333-1-git-send-email-aik@ozlabs.ru>

The existing KVM_CREATE_SPAPR_TCE ioctl only support 4G windows max.
We are going to add huge DMA windows support so this will create small
window and unexpectedly fail later.

This disables KVM_CREATE_SPAPR_TCE for windows bigger that 4GB. Since
those windows are normally mapped at the boot time, there will be no
performance impact.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
 hw/ppc/spapr_iommu.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c
index f6e32a4..36f5d27 100644
--- a/hw/ppc/spapr_iommu.c
+++ b/hw/ppc/spapr_iommu.c
@@ -113,11 +113,11 @@ static MemoryRegionIOMMUOps spapr_iommu_ops = {
 static int spapr_tce_table_realize(DeviceState *dev)
 {
     sPAPRTCETable *tcet = SPAPR_TCE_TABLE(dev);
+    uint64_t window_size = tcet->nb_table << tcet->page_shift;
 
-    if (kvm_enabled()) {
+    if (kvm_enabled() && !(window_size >> 32)) {
         tcet->table = kvmppc_create_spapr_tce(tcet->liobn,
-                                              tcet->nb_table <<
-                                              tcet->page_shift,
+                                              window_size,
                                               &tcet->fd,
                                               tcet->vfio_accel);
     }
-- 
2.0.0

  reply	other threads:[~2014-07-15  9:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-15  9:39 [PATCH QEMU 00/12] vfio: pci: Enable DDW and in-kernel acceleration Alexey Kardashevskiy
2014-07-15  9:39 ` Alexey Kardashevskiy [this message]
2014-07-15  9:39 ` [PATCH QEMU 02/12] spapr_pci: Make find_phb()/find_dev() public Alexey Kardashevskiy
2014-07-15  9:39 ` [PATCH QEMU 03/12] spapr_iommu: Make spapr_tce_find_by_liobn() public Alexey Kardashevskiy
2014-07-15  9:39 ` [PATCH QEMU 04/12] linux headers update for DDW Alexey Kardashevskiy
2014-07-15  9:39 ` [PATCH QEMU 05/12] spapr_rtas: Add Dynamic DMA windows (DDW) RTAS calls support Alexey Kardashevskiy
2014-07-15  9:39 ` [PATCH QEMU 06/12] spapr: Add "ddw" machine option Alexey Kardashevskiy
2014-07-15  9:39 ` [PATCH QEMU 07/12] spapr_pci: Enable DDW Alexey Kardashevskiy
2014-07-15  9:39 ` [PATCH QEMU 08/12] spapr_pci_vfio: " Alexey Kardashevskiy
2014-07-15  9:39 ` [PATCH QEMU 09/12] vfio: Enable DDW ioctls to VFIO IOMMU driver Alexey Kardashevskiy
2014-07-15  9:39 ` [PATCH QEMU 10/12] headers: update for KVM_CAP_SPAPR_TCE_64 and VFIO KVM device Alexey Kardashevskiy
2014-07-15  9:39 ` [PATCH QEMU 11/12] target-ppc: kvm: make use of KVM_CREATE_SPAPR_TCE_64 Alexey Kardashevskiy
2014-07-15  9:39 ` [PATCH QEMU 12/12] vfio: Enable in-kernel acceleration via VFIO KVM device Alexey Kardashevskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405417184-14333-2-git-send-email-aik@ozlabs.ru \
    --to=aik@ozlabs.ru \
    --cc=gwshan@linux.vnet.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).