* [PATCH] arch/powerpc/mm/numa.c: Fix break placement
@ 2014-08-04 20:13 Andrey Utkin
2014-08-05 9:16 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 3+ messages in thread
From: Andrey Utkin @ 2014-08-04 20:13 UTC (permalink / raw)
To: benh, paulus, mpe, akpm, srivatsa.bhat, sfr, qiuxishi, wangyun,
qiudayu, joe, alistair, rcj
Cc: kernel-janitors, Andrey Utkin, linuxppc-dev, linux-kernel
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=81631
Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
---
arch/powerpc/mm/numa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
index 3b181b2..d3e9a78 100644
--- a/arch/powerpc/mm/numa.c
+++ b/arch/powerpc/mm/numa.c
@@ -611,8 +611,8 @@ static int cpu_numa_callback(struct notifier_block *nfb, unsigned long action,
case CPU_UP_CANCELED:
case CPU_UP_CANCELED_FROZEN:
unmap_cpu_from_node(lcpu);
- break;
ret = NOTIFY_OK;
+ break;
#endif
}
return ret;
--
1.8.5.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arch/powerpc/mm/numa.c: Fix break placement
2014-08-04 20:13 [PATCH] arch/powerpc/mm/numa.c: Fix break placement Andrey Utkin
@ 2014-08-05 9:16 ` Benjamin Herrenschmidt
2014-08-05 12:39 ` Michael Ellerman
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2014-08-05 9:16 UTC (permalink / raw)
To: Andrey Utkin
Cc: sfr, rcj, kernel-janitors, linux-kernel, paulus, wangyun,
srivatsa.bhat, alistair, joe, qiuxishi, akpm, qiudayu,
linuxppc-dev
On Mon, 2014-08-04 at 23:13 +0300, Andrey Utkin wrote:
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=81631
> Reported-by: David Binderman <dcb314@hotmail.com>
> Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Thanks, I wonder how that managed to remain unnoticed for so long !
Cheers,
Ben.
> ---
> arch/powerpc/mm/numa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
> index 3b181b2..d3e9a78 100644
> --- a/arch/powerpc/mm/numa.c
> +++ b/arch/powerpc/mm/numa.c
> @@ -611,8 +611,8 @@ static int cpu_numa_callback(struct notifier_block *nfb, unsigned long action,
> case CPU_UP_CANCELED:
> case CPU_UP_CANCELED_FROZEN:
> unmap_cpu_from_node(lcpu);
> - break;
> ret = NOTIFY_OK;
> + break;
> #endif
> }
> return ret;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arch/powerpc/mm/numa.c: Fix break placement
2014-08-05 9:16 ` Benjamin Herrenschmidt
@ 2014-08-05 12:39 ` Michael Ellerman
0 siblings, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2014-08-05 12:39 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: sfr, rcj, alistair, kernel-janitors, linux-kernel, Andrey Utkin,
paulus, wangyun, srivatsa.bhat, joe, qiuxishi, akpm, qiudayu,
linuxppc-dev
On Tue, 2014-08-05 at 19:16 +1000, Benjamin Herrenschmidt wrote:
> On Mon, 2014-08-04 at 23:13 +0300, Andrey Utkin wrote:
> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=81631
> > Reported-by: David Binderman <dcb314@hotmail.com>
> > Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
>
> Thanks, I wonder how that managed to remain unnoticed for so long !
1. No one tested it :)
2. The code stupidly initialises ret at the beginning of the function, so the
compiler can't help us detect the unitialised usage.
3. NOTIFY_OK and NOTIFY_DONE appear to be equivalent in practice.
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-05 12:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-04 20:13 [PATCH] arch/powerpc/mm/numa.c: Fix break placement Andrey Utkin
2014-08-05 9:16 ` Benjamin Herrenschmidt
2014-08-05 12:39 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).