From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
linuxppc-dev@lists.ozlabs.org,
Gavin Shan <gwshan@linux.vnet.ibm.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH v2 4/4] vfio_pci: spapr: Enable VFIO if EEH is not supported
Date: Wed, 06 Aug 2014 14:34:44 +1000 [thread overview]
Message-ID: <1407299684.3073.62.camel@pasglop> (raw)
In-Reply-To: <1407296659.316.78.camel@ul30vt.home>
On Tue, 2014-08-05 at 21:44 -0600, Alex Williamson wrote:
> > ret = vfio_spapr_pci_eeh_open(vdev->pdev);
> > - if (ret) {
> > - vfio_pci_disable(vdev);
> > - goto error;
> > - }
> > + if (ret)
> > + pr_warn_once("EEH is not supported\n");
> > }
> >
> > return 0;
>
> Now the next question, what's the point of vfio_spapr_pci_eeh_open()
> returning a value? Couldn't it return void now and this warning can
> go into eeh specific code? Thanks,
In order to call vfio_pci_disable() when that happens ?
Cheers,
Ben.
prev parent reply other threads:[~2014-08-06 4:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 2:48 [PATCH v2 0/4] vfio: eeh: spapr: Compile and compatibility fixes Alexey Kardashevskiy
2014-08-06 2:48 ` [PATCH v2 1/4] powerpc/eeh: Export eeh_iommu_group_to_pe() Alexey Kardashevskiy
2014-08-06 2:48 ` [PATCH v2 2/4] vfio: spapr: Fix build error Alexey Kardashevskiy
2014-08-06 3:12 ` Alex Williamson
2014-08-06 3:54 ` Gavin Shan
2014-08-06 6:33 ` Alexey Kardashevskiy
2014-08-06 6:57 ` Gavin Shan
2014-08-06 2:48 ` [PATCH v2 3/4] vfio_spapr_eeh: Enable compile as a module Alexey Kardashevskiy
2014-08-06 2:48 ` [PATCH v2 4/4] vfio_pci: spapr: Enable VFIO if EEH is not supported Alexey Kardashevskiy
2014-08-06 3:44 ` Alex Williamson
2014-08-06 4:34 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407299684.3073.62.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).