From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: john.stultz@linaro.org
Cc: sfr@canb.auug.org.au, peterz@infradead.org,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org
Subject: Re: [tip:timers/core] timekeeping: Fixup typo in update_vsyscall_old definition
Date: Mon, 11 Aug 2014 14:19:04 +1000 [thread overview]
Message-ID: <1407730744.4508.67.camel@pasglop> (raw)
In-Reply-To: <tip-953dec21aed4038464fec02f96a2f1b8701a5bce@git.kernel.org>
On Wed, 2014-07-30 at 00:31 -0700, tip-bot for John Stultz wrote:
> Commit-ID: 953dec21aed4038464fec02f96a2f1b8701a5bce
> Gitweb: http://git.kernel.org/tip/953dec21aed4038464fec02f96a2f1b8701a5bce
> Author: John Stultz <john.stultz@linaro.org>
> AuthorDate: Fri, 25 Jul 2014 21:37:19 -0700
> Committer: Thomas Gleixner <tglx@linutronix.de>
> CommitDate: Wed, 30 Jul 2014 09:26:25 +0200
>
> timekeeping: Fixup typo in update_vsyscall_old definition
>
> In commit 4a0e637738f0 ("clocksource: Get rid of cycle_last"),
> currently in the -tip tree, there was a small typo where cycles_t
> was used intstead of cycle_t. This broke ppc64 builds.
There's another bug in there... You fix timespec vs. timespec64 for the
first argument of update_vsyscall_old but not the second one ...
(wall_to_monotonic).
Also, in e2dff1ec0 you claim this is "minor", you seem to forget that
arch/powerpc also deals with 32-bit kernels which use the same time
keeping code, so we have a pretty serious regressions here...
BTW. Is there some documentation you can point me to to figure out what
replace that "_OLD" stuff so we can update to whatever is "new" ?
Cheers,
Ben.
next parent reply other threads:[~2014-08-11 4:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1406349439-11785-1-git-send-email-john.stultz@linaro.org>
[not found] ` <tip-953dec21aed4038464fec02f96a2f1b8701a5bce@git.kernel.org>
2014-08-11 4:19 ` Benjamin Herrenschmidt [this message]
2014-08-12 15:30 ` [tip:timers/core] timekeeping: Fixup typo in update_vsyscall_old definition John Stultz
2014-08-13 4:03 ` Tony Breeds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407730744.4508.67.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=hpa@zytor.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).