From: Michael Neuling <mikey@neuling.org>
To: Paul Mackerras <paulus@samba.org>
Cc: kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Alexander Graf <agraf@suse.de>,
kvm@vger.kernel.org
Subject: Re: [PATCH 1/2] KVM: PPC: Book3S HV: Cleanup kvmppc_load/save_fp
Date: Tue, 19 Aug 2014 15:36:47 +1000 [thread overview]
Message-ID: <1408426607.16286.24.camel@ale.ozlabs.ibm.com> (raw)
In-Reply-To: <20140819052407.GA30652@drongo>
On Tue, 2014-08-19 at 15:24 +1000, Paul Mackerras wrote:
> On Tue, Aug 19, 2014 at 02:59:29PM +1000, Michael Neuling wrote:
> > This cleans up kvmppc_load/save_fp. It removes unnecessary isyncs.
>=20
> NAK - they are necessary on PPC970, which we (still) support. You
> could put them in a feature section if they are really annoying you.
I'm not fussed, but we should at least have a comment there for why we
need them.
> > It also
> > removes the unnecessary resetting of the MSR bits on exit of kvmppc_sav=
e_fp.
>=20
> ... except it doesn't. :) That got folded into e4e38121507a ("KVM:
> PPC: Book3S HV: Add transactional memory support").
Arrh, thanks. This patch was cleaning up stuff from an old local tree
and couldn't see where it had been upstreamed. I missed this.
Mikey
prev parent reply other threads:[~2014-08-19 5:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 4:59 [PATCH 1/2] KVM: PPC: Book3S HV: Cleanup kvmppc_load/save_fp Michael Neuling
2014-08-19 4:59 ` [PATCH 2/2] KVM: PPC: Book3S HV: Add register name when loading toc Michael Neuling
2014-08-27 11:20 ` Alexander Graf
2014-08-19 5:24 ` [PATCH 1/2] KVM: PPC: Book3S HV: Cleanup kvmppc_load/save_fp Paul Mackerras
2014-08-19 5:36 ` Michael Neuling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408426607.16286.24.camel@ale.ozlabs.ibm.com \
--to=mikey@neuling.org \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).