* [PATCH 1/2] KVM: PPC: Book3S HV: Cleanup kvmppc_load/save_fp
@ 2014-08-19 4:59 Michael Neuling
2014-08-19 4:59 ` [PATCH 2/2] KVM: PPC: Book3S HV: Add register name when loading toc Michael Neuling
2014-08-19 5:24 ` [PATCH 1/2] KVM: PPC: Book3S HV: Cleanup kvmppc_load/save_fp Paul Mackerras
0 siblings, 2 replies; 5+ messages in thread
From: Michael Neuling @ 2014-08-19 4:59 UTC (permalink / raw)
To: Alexander Graf, Paul Mackerras; +Cc: linuxppc-dev, kvm-ppc, kvm
This cleans up kvmppc_load/save_fp. It removes unnecessary isyncs. It also
removes the unnecessary resetting of the MSR bits on exit of kvmppc_save_fp.
Signed-off-by: Michael Neuling <mikey@neuling.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
---
arch/powerpc/kvm/book3s_hv_rmhandlers.S | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/powerpc/kvm/book3s_hv_rmhandlers.S b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
index f0c4db7..c4bd2d7 100644
--- a/arch/powerpc/kvm/book3s_hv_rmhandlers.S
+++ b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
@@ -2434,7 +2434,6 @@ BEGIN_FTR_SECTION
END_FTR_SECTION_IFSET(CPU_FTR_VSX)
#endif
mtmsrd r8
- isync
addi r3,r3,VCPU_FPRS
bl store_fp_state
#ifdef CONFIG_ALTIVEC
@@ -2470,7 +2469,6 @@ BEGIN_FTR_SECTION
END_FTR_SECTION_IFSET(CPU_FTR_VSX)
#endif
mtmsrd r8
- isync
addi r3,r4,VCPU_FPRS
bl load_fp_state
#ifdef CONFIG_ALTIVEC
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] KVM: PPC: Book3S HV: Add register name when loading toc
2014-08-19 4:59 [PATCH 1/2] KVM: PPC: Book3S HV: Cleanup kvmppc_load/save_fp Michael Neuling
@ 2014-08-19 4:59 ` Michael Neuling
2014-08-27 11:20 ` Alexander Graf
2014-08-19 5:24 ` [PATCH 1/2] KVM: PPC: Book3S HV: Cleanup kvmppc_load/save_fp Paul Mackerras
1 sibling, 1 reply; 5+ messages in thread
From: Michael Neuling @ 2014-08-19 4:59 UTC (permalink / raw)
To: Alexander Graf, Paul Mackerras; +Cc: linuxppc-dev, kvm-ppc, kvm
Add 'r' to register name r2 in kvmppc_hv_enter.
Also update comment at the top of kvmppc_hv_enter to indicate that R2/TOC is
non-volatile.
Signed-off-by: Michael Neuling <mikey@neuling.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
---
arch/powerpc/kvm/book3s_hv_rmhandlers.S | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/kvm/book3s_hv_rmhandlers.S b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
index c4bd2d7..1e8c480 100644
--- a/arch/powerpc/kvm/book3s_hv_rmhandlers.S
+++ b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
@@ -355,6 +355,7 @@ kvmppc_hv_entry:
* MSR = ~IR|DR
* R13 = PACA
* R1 = host R1
+ * R2 = TOC
* all other volatile GPRS = free
*/
mflr r0
@@ -503,7 +504,7 @@ END_FTR_SECTION_IFSET(CPU_FTR_ARCH_207S)
toc_tlbie_lock:
.tc native_tlbie_lock[TC],native_tlbie_lock
.previous
- ld r3,toc_tlbie_lock@toc(2)
+ ld r3,toc_tlbie_lock@toc(r2)
#ifdef __BIG_ENDIAN__
lwz r8,PACA_LOCK_TOKEN(r13)
#else
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] KVM: PPC: Book3S HV: Cleanup kvmppc_load/save_fp
2014-08-19 4:59 [PATCH 1/2] KVM: PPC: Book3S HV: Cleanup kvmppc_load/save_fp Michael Neuling
2014-08-19 4:59 ` [PATCH 2/2] KVM: PPC: Book3S HV: Add register name when loading toc Michael Neuling
@ 2014-08-19 5:24 ` Paul Mackerras
2014-08-19 5:36 ` Michael Neuling
1 sibling, 1 reply; 5+ messages in thread
From: Paul Mackerras @ 2014-08-19 5:24 UTC (permalink / raw)
To: Michael Neuling; +Cc: kvm-ppc, linuxppc-dev, Alexander Graf, kvm
On Tue, Aug 19, 2014 at 02:59:29PM +1000, Michael Neuling wrote:
> This cleans up kvmppc_load/save_fp. It removes unnecessary isyncs.
NAK - they are necessary on PPC970, which we (still) support. You
could put them in a feature section if they are really annoying you.
> It also
> removes the unnecessary resetting of the MSR bits on exit of kvmppc_save_fp.
... except it doesn't. :) That got folded into e4e38121507a ("KVM:
PPC: Book3S HV: Add transactional memory support").
Paul.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] KVM: PPC: Book3S HV: Cleanup kvmppc_load/save_fp
2014-08-19 5:24 ` [PATCH 1/2] KVM: PPC: Book3S HV: Cleanup kvmppc_load/save_fp Paul Mackerras
@ 2014-08-19 5:36 ` Michael Neuling
0 siblings, 0 replies; 5+ messages in thread
From: Michael Neuling @ 2014-08-19 5:36 UTC (permalink / raw)
To: Paul Mackerras; +Cc: kvm-ppc, linuxppc-dev, Alexander Graf, kvm
On Tue, 2014-08-19 at 15:24 +1000, Paul Mackerras wrote:
> On Tue, Aug 19, 2014 at 02:59:29PM +1000, Michael Neuling wrote:
> > This cleans up kvmppc_load/save_fp. It removes unnecessary isyncs.
>=20
> NAK - they are necessary on PPC970, which we (still) support. You
> could put them in a feature section if they are really annoying you.
I'm not fussed, but we should at least have a comment there for why we
need them.
> > It also
> > removes the unnecessary resetting of the MSR bits on exit of kvmppc_sav=
e_fp.
>=20
> ... except it doesn't. :) That got folded into e4e38121507a ("KVM:
> PPC: Book3S HV: Add transactional memory support").
Arrh, thanks. This patch was cleaning up stuff from an old local tree
and couldn't see where it had been upstreamed. I missed this.
Mikey
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-08-27 11:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-19 4:59 [PATCH 1/2] KVM: PPC: Book3S HV: Cleanup kvmppc_load/save_fp Michael Neuling
2014-08-19 4:59 ` [PATCH 2/2] KVM: PPC: Book3S HV: Add register name when loading toc Michael Neuling
2014-08-27 11:20 ` Alexander Graf
2014-08-19 5:24 ` [PATCH 1/2] KVM: PPC: Book3S HV: Cleanup kvmppc_load/save_fp Paul Mackerras
2014-08-19 5:36 ` Michael Neuling
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).