[PATCH] powerpc: Make 256k pages depend on PPC32=n

[PATCH] powerpc: Make 256k pages depend on PPC32=n

[Pranith Kumar]

256k pages are not tested on PPC32. On a randconfig I got the following error:

arch/powerpc/kernel/misc_32.S:1171: Error: operand out of range (0x0000000000010000 is not between 0xffffffffffff8000 and 0x0000000000007fff)

Disable 256K pages if PPC32=y

Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
---
 arch/powerpc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index da16ffe..6cc518f 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -556,7 +556,7 @@ config PPC_64K_PAGES
 
 config PPC_256K_PAGES
 	bool "256k page size" if 44x
-	depends on !STDBINUTILS
+	depends on !PPC32 && !STDBINUTILS
 	help
 	  Make the page size 256k.
 
-- 
1.9.1

Re: [PATCH] powerpc: Make 256k pages depend on PPC32=n

[Scott Wood]

On Tue, 2014-08-19 at 17:36 -0400, Pranith Kumar wrote:
> 256k pages are not tested on PPC32. On a randconfig I got the following error:
> 
> arch/powerpc/kernel/misc_32.S:1171: Error: operand out of range (0x0000000000010000 is not between 0xffffffffffff8000 and 0x0000000000007fff)
> 
> Disable 256K pages if PPC32=y
> 
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> ---
>  arch/powerpc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index da16ffe..6cc518f 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -556,7 +556,7 @@ config PPC_64K_PAGES
>  
>  config PPC_256K_PAGES
>  	bool "256k page size" if 44x
> -	depends on !STDBINUTILS
> +	depends on !PPC32 && !STDBINUTILS
>  	help
>  	  Make the page size 256k.
>  

How will this ever be selected then?  44x is 32-bit only.

-Scott

Re: [PATCH] powerpc: Make 256k pages depend on PPC32=n

[Pranith Kumar]

On Tue, Aug 19, 2014 at 6:19 PM, Scott Wood <scottwood@freescale.com> wrote:

>>  config PPC_256K_PAGES
>>       bool "256k page size" if 44x
>> -     depends on !STDBINUTILS
>> +     depends on !PPC32 && !STDBINUTILS
>>       help
>>         Make the page size 256k.
>>
>
> How will this ever be selected then?  44x is 32-bit only.

Indeed. I am actually confused about the error which is being thrown
here. The operand (65536) is actually within the range. Any suggestions
on how to fix this?


-- 
Pranith

Re: [PATCH] powerpc: Make 256k pages depend on PPC32=n

[Scott Wood]

On Tue, 2014-08-19 at 18:23 -0400, Pranith Kumar wrote:
> On Tue, Aug 19, 2014 at 6:19 PM, Scott Wood <scottwood@freescale.com> wrote:
> 
> >>  config PPC_256K_PAGES
> >>       bool "256k page size" if 44x
> >> -     depends on !STDBINUTILS
> >> +     depends on !PPC32 && !STDBINUTILS
> >>       help
> >>         Make the page size 256k.
> >>
> >
> > How will this ever be selected then?  44x is 32-bit only.
> 
> Indeed. I am actually confused about the error which is being thrown
> here. The operand (65536) is actually within the range. Any suggestions
> on how to fix this?

It's not within range of "li".  I wonder if whatever non-"STD" binutils
this is supposed to be used with is rewriting it into an lis
instruction.  This sort of external dependency is a poor fit for the
randconfig concept (plus, shouldn't the symbol be indicating what
binutils you're supposed to have rather than anything that isn't
"standard"?).

In any case, you could use something like LOAD_REG_IMMEDIATE().

-Scott