From: Michael Ellerman <mpe@ellerman.id.au>
To: Himangi Saraogi <himangi774@gmail.com>
Cc: linux-kernel@vger.kernel.org, Julia Lawall <julia.lawall@lip6.fr>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, rcj4747@gmail.com
Subject: Re: [PATCH] powerpc/pseries: Drop unnecessary continue
Date: Thu, 21 Aug 2014 14:41:26 +1000 [thread overview]
Message-ID: <1408596086.9307.3.camel@concordia> (raw)
In-Reply-To: <20140813091847.GA3078@himangi-Dell>
On Wed, 2014-08-13 at 14:48 +0530, Himangi Saraogi wrote:
> Continue is not needed at the bottom of a loop.
True.
I wonder though, is the code trying to continue to the outer loop? I stared at
it for a minute but it wasn't obvious.
I wonder if Robert still remembers?
cheers
> diff --git a/arch/powerpc/platforms/pseries/cmm.c b/arch/powerpc/platforms/pseries/cmm.c
> index 2d8bf15..fc44ad0 100644
> --- a/arch/powerpc/platforms/pseries/cmm.c
> +++ b/arch/powerpc/platforms/pseries/cmm.c
> @@ -555,7 +555,6 @@ static int cmm_mem_going_offline(void *arg)
> pa_last = pa_last->next;
> free_page((unsigned long)cmm_page_list);
> cmm_page_list = pa_last;
> - continue;
> }
> }
> pa_curr = pa_curr->next;
next prev parent reply other threads:[~2014-08-21 4:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 9:18 [PATCH] powerpc/pseries: Drop unnecessary continue Himangi Saraogi
2014-08-21 4:41 ` Michael Ellerman [this message]
2014-08-21 15:51 ` Robert Jennings
2014-08-25 4:16 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408596086.9307.3.camel@concordia \
--to=mpe@ellerman.id.au \
--cc=himangi774@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=rcj4747@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).