* [PATCH] Documentation: dts: fsl-usb: Document USB node compatible string for IP version
@ 2014-08-21 9:18 Nikhil Badola
2014-08-21 22:22 ` Scott Wood
0 siblings, 1 reply; 7+ messages in thread
From: Nikhil Badola @ 2014-08-21 9:18 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Nikhil Badola
Document compatible string containing IP version in USB device tree node
Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com>
---
Documentation/devicetree/bindings/usb/fsl-usb.txt | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/fsl-usb.txt b/Documentation/devicetree/bindings/usb/fsl-usb.txt
index 4779c02..5a3a0a8 100644
--- a/Documentation/devicetree/bindings/usb/fsl-usb.txt
+++ b/Documentation/devicetree/bindings/usb/fsl-usb.txt
@@ -10,7 +10,10 @@ Required properties :
controllers, or "fsl-usb2-dr" for dual role USB controllers
or "fsl,mpc5121-usb2-dr" for dual role USB controllers of MPC5121.
Wherever applicable, the IP version of the USB controller should
- also be mentioned (for eg. fsl-usb2-dr-v2.2 for bsc9132).
+ also be mentioned in another string.
+ For multi port host USB controller with IP version <IP_Ver>, it should be
+ "fsl-usb2-mph-<IP_Ver>". For dual role USB controller with IP version
+ <IP_Ver>, it should be "fsl-usb2-dr-<IP_Ver>".
- phy_type : For multi port host USB controllers, should be one of
"ulpi", or "serial". For dual role USB controllers, should be
one of "ulpi", "utmi", "utmi_wide", or "serial".
@@ -42,9 +45,9 @@ Optional properties :
- fsl,invert-pwr-fault : boolean; for MPC5121 USB0 only. Indicates
the PWR_FAULT signal polarity is inverted.
-Example multi port host USB controller device node :
+Example multi port host USB controller version 2.5 device node :
usb@22000 {
- compatible = "fsl-usb2-mph";
+ compatible = "fsl-usb2-mph-v2.5", "fsl-usb2-mph";
reg = <22000 1000>;
#address-cells = <1>;
#size-cells = <0>;
@@ -55,9 +58,9 @@ Example multi port host USB controller device node :
port1;
};
-Example dual role USB controller device node :
+Example dual role USB controller version 2.5 device node :
usb@23000 {
- compatible = "fsl-usb2-dr";
+ compatible = "fsl-usb2-dr-v2.5", "fsl-usb2-dr";
reg = <23000 1000>;
#address-cells = <1>;
#size-cells = <0>;
--
1.7.11.7
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] Documentation: dts: fsl-usb: Document USB node compatible string for IP version
2014-08-21 9:18 [PATCH] Documentation: dts: fsl-usb: Document USB node compatible string for IP version Nikhil Badola
@ 2014-08-21 22:22 ` Scott Wood
2014-08-22 4:48 ` nikhil.badola
0 siblings, 1 reply; 7+ messages in thread
From: Scott Wood @ 2014-08-21 22:22 UTC (permalink / raw)
To: Nikhil Badola; +Cc: devicetree, linuxppc-dev
On Thu, 2014-08-21 at 14:48 +0530, Nikhil Badola wrote:
> Document compatible string containing IP version in USB device tree node
>
> Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com>
> ---
> Documentation/devicetree/bindings/usb/fsl-usb.txt | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
Please CC devicetree@vger.kernel.org on all device tree patches (in
addition to linuxppc-dev).
>
> diff --git a/Documentation/devicetree/bindings/usb/fsl-usb.txt b/Documentation/devicetree/bindings/usb/fsl-usb.txt
> index 4779c02..5a3a0a8 100644
> --- a/Documentation/devicetree/bindings/usb/fsl-usb.txt
> +++ b/Documentation/devicetree/bindings/usb/fsl-usb.txt
> @@ -10,7 +10,10 @@ Required properties :
> controllers, or "fsl-usb2-dr" for dual role USB controllers
> or "fsl,mpc5121-usb2-dr" for dual role USB controllers of MPC5121.
> Wherever applicable, the IP version of the USB controller should
> - also be mentioned (for eg. fsl-usb2-dr-v2.2 for bsc9132).
> + also be mentioned in another string.
> + For multi port host USB controller with IP version <IP_Ver>, it should be
> + "fsl-usb2-mph-<IP_Ver>". For dual role USB controller with IP version
> + <IP_Ver>, it should be "fsl-usb2-dr-<IP_Ver>".
It was documented before -- this is just making it more explicit, right?
FWIW, the version number can be read out of a USB register, so I'd
rather remove the suggestion to specify the version number and replace
it with a reference to the ID register.
> - phy_type : For multi port host USB controllers, should be one of
> "ulpi", or "serial". For dual role USB controllers, should be
> one of "ulpi", "utmi", "utmi_wide", or "serial".
> @@ -42,9 +45,9 @@ Optional properties :
> - fsl,invert-pwr-fault : boolean; for MPC5121 USB0 only. Indicates
> the PWR_FAULT signal polarity is inverted.
>
> -Example multi port host USB controller device node :
> +Example multi port host USB controller version 2.5 device node :
> usb@22000 {
> - compatible = "fsl-usb2-mph";
> + compatible = "fsl-usb2-mph-v2.5", "fsl-usb2-mph";
> reg = <22000 1000>;
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -55,9 +58,9 @@ Example multi port host USB controller device node :
> port1;
> };
>
> -Example dual role USB controller device node :
> +Example dual role USB controller version 2.5 device node :
> usb@23000 {
> - compatible = "fsl-usb2-dr";
> + compatible = "fsl-usb2-dr-v2.5", "fsl-usb2-dr";
> reg = <23000 1000>;
> #address-cells = <1>;
> #size-cells = <0>;
This example doesn't correspond to any device tree I see. Even after
your next patch that sets t2080's USB to v2.5, the addresses are
different.
Also, if you're going to update the example, please also update it to be
modern in other respects, such as using 0x for hex numbers (outside the
unit address).
-Scott
^ permalink raw reply [flat|nested] 7+ messages in thread* RE: [PATCH] Documentation: dts: fsl-usb: Document USB node compatible string for IP version
2014-08-21 22:22 ` Scott Wood
@ 2014-08-22 4:48 ` nikhil.badola
2014-08-22 5:05 ` Ramneek Mehresh
0 siblings, 1 reply; 7+ messages in thread
From: nikhil.badola @ 2014-08-22 4:48 UTC (permalink / raw)
To: Scott Wood
Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Ramneek Mehresh
QWRkaW5nIFJhbW5lZWsNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBX
b29kIFNjb3R0LUIwNzQyMQ0KPiBTZW50OiBGcmlkYXksIEF1Z3VzdCAyMiwgMjAxNCAzOjUzIEFN
DQo+IFRvOiBCYWRvbGEgTmlraGlsLUI0NjE3Mg0KPiBDYzogbGludXhwcGMtZGV2QGxpc3RzLm96
bGFicy5vcmc7IGRldmljZXRyZWVAdmdlci5rZXJuZWwub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFU
Q0hdIERvY3VtZW50YXRpb246IGR0czogZnNsLXVzYjogRG9jdW1lbnQgVVNCIG5vZGUNCj4gY29t
cGF0aWJsZSBzdHJpbmcgZm9yIElQIHZlcnNpb24NCj4gDQo+IE9uIFRodSwgMjAxNC0wOC0yMSBh
dCAxNDo0OCArMDUzMCwgTmlraGlsIEJhZG9sYSB3cm90ZToNCj4gPiBEb2N1bWVudCBjb21wYXRp
YmxlIHN0cmluZyBjb250YWluaW5nIElQIHZlcnNpb24gaW4gVVNCIGRldmljZSB0cmVlDQo+ID4g
bm9kZQ0KPiA+DQo+ID4gU2lnbmVkLW9mZi1ieTogTmlraGlsIEJhZG9sYSA8bmlraGlsLmJhZG9s
YUBmcmVlc2NhbGUuY29tPg0KPiA+IC0tLQ0KPiA+ICBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUv
YmluZGluZ3MvdXNiL2ZzbC11c2IudHh0IHwgMTMgKysrKysrKystLS0tLQ0KPiA+ICAxIGZpbGUg
Y2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQ0KPiANCj4gUGxlYXNlIEND
IGRldmljZXRyZWVAdmdlci5rZXJuZWwub3JnIG9uIGFsbCBkZXZpY2UgdHJlZSBwYXRjaGVzIChp
biBhZGRpdGlvbiB0bw0KPiBsaW51eHBwYy1kZXYpLg0KPiANCj4gPg0KPiA+IGRpZmYgLS1naXQg
YS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdXNiL2ZzbC11c2IudHh0DQo+ID4g
Yi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdXNiL2ZzbC11c2IudHh0DQo+ID4g
aW5kZXggNDc3OWMwMi4uNWEzYTBhOCAxMDA2NDQNCj4gPiAtLS0gYS9Eb2N1bWVudGF0aW9uL2Rl
dmljZXRyZWUvYmluZGluZ3MvdXNiL2ZzbC11c2IudHh0DQo+ID4gKysrIGIvRG9jdW1lbnRhdGlv
bi9kZXZpY2V0cmVlL2JpbmRpbmdzL3VzYi9mc2wtdXNiLnR4dA0KPiA+IEBAIC0xMCw3ICsxMCwx
MCBAQCBSZXF1aXJlZCBwcm9wZXJ0aWVzIDoNCj4gPiAgICAgY29udHJvbGxlcnMsIG9yICJmc2wt
dXNiMi1kciIgZm9yIGR1YWwgcm9sZSBVU0IgY29udHJvbGxlcnMNCj4gPiAgICAgb3IgImZzbCxt
cGM1MTIxLXVzYjItZHIiIGZvciBkdWFsIHJvbGUgVVNCIGNvbnRyb2xsZXJzIG9mIE1QQzUxMjEu
DQo+ID4gICAgIFdoZXJldmVyIGFwcGxpY2FibGUsIHRoZSBJUCB2ZXJzaW9uIG9mIHRoZSBVU0Ig
Y29udHJvbGxlciBzaG91bGQNCj4gPiAtICAgYWxzbyBiZSBtZW50aW9uZWQgKGZvciBlZy4gZnNs
LXVzYjItZHItdjIuMiBmb3IgYnNjOTEzMikuDQo+ID4gKyAgIGFsc28gYmUgbWVudGlvbmVkIGlu
IGFub3RoZXIgc3RyaW5nLg0KPiA+ICsgICBGb3IgbXVsdGkgcG9ydCBob3N0IFVTQiBjb250cm9s
bGVyIHdpdGggSVAgdmVyc2lvbiA8SVBfVmVyPiwgaXQgc2hvdWxkIGJlDQo+ID4gKyAgICJmc2wt
dXNiMi1tcGgtPElQX1Zlcj4iLiBGb3IgZHVhbCByb2xlIFVTQiBjb250cm9sbGVyIHdpdGggSVAg
dmVyc2lvbg0KPiA+ICsgICA8SVBfVmVyPiwgaXQgc2hvdWxkIGJlICJmc2wtdXNiMi1kci08SVBf
VmVyPiIuDQo+IA0KPiBJdCB3YXMgZG9jdW1lbnRlZCBiZWZvcmUgLS0gdGhpcyBpcyBqdXN0IG1h
a2luZyBpdCBtb3JlIGV4cGxpY2l0LCByaWdodD8NCj4gDQo+IEZXSVcsIHRoZSB2ZXJzaW9uIG51
bWJlciBjYW4gYmUgcmVhZCBvdXQgb2YgYSBVU0IgcmVnaXN0ZXIsIHNvIEknZCByYXRoZXINCj4g
cmVtb3ZlIHRoZSBzdWdnZXN0aW9uIHRvIHNwZWNpZnkgdGhlIHZlcnNpb24gbnVtYmVyIGFuZCBy
ZXBsYWNlIGl0IHdpdGggYQ0KPiByZWZlcmVuY2UgdG8gdGhlIElEIHJlZ2lzdGVyLg0KPiANCj4g
PiAgIC0gcGh5X3R5cGUgOiBGb3IgbXVsdGkgcG9ydCBob3N0IFVTQiBjb250cm9sbGVycywgc2hv
dWxkIGJlIG9uZSBvZg0KPiA+ICAgICAidWxwaSIsIG9yICJzZXJpYWwiLiBGb3IgZHVhbCByb2xl
IFVTQiBjb250cm9sbGVycywgc2hvdWxkIGJlDQo+ID4gICAgIG9uZSBvZiAidWxwaSIsICJ1dG1p
IiwgInV0bWlfd2lkZSIsIG9yICJzZXJpYWwiLg0KPiA+IEBAIC00Miw5ICs0NSw5IEBAIE9wdGlv
bmFsIHByb3BlcnRpZXMgOg0KPiA+ICAgLSBmc2wsaW52ZXJ0LXB3ci1mYXVsdCA6IGJvb2xlYW47
IGZvciBNUEM1MTIxIFVTQjAgb25seS4gSW5kaWNhdGVzDQo+ID4gICAgIHRoZSBQV1JfRkFVTFQg
c2lnbmFsIHBvbGFyaXR5IGlzIGludmVydGVkLg0KPiA+DQo+ID4gLUV4YW1wbGUgbXVsdGkgcG9y
dCBob3N0IFVTQiBjb250cm9sbGVyIGRldmljZSBub2RlIDoNCj4gPiArRXhhbXBsZSBtdWx0aSBw
b3J0IGhvc3QgVVNCIGNvbnRyb2xsZXIgdmVyc2lvbiAyLjUgZGV2aWNlIG5vZGUgOg0KPiA+ICAJ
dXNiQDIyMDAwIHsNCj4gPiAtCQljb21wYXRpYmxlID0gImZzbC11c2IyLW1waCI7DQo+ID4gKwkJ
Y29tcGF0aWJsZSA9ICJmc2wtdXNiMi1tcGgtdjIuNSIsICJmc2wtdXNiMi1tcGgiOw0KPiA+ICAJ
CXJlZyA9IDwyMjAwMCAxMDAwPjsNCj4gPiAgCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsNCj4gPiAg
CQkjc2l6ZS1jZWxscyA9IDwwPjsNCj4gPiBAQCAtNTUsOSArNTgsOSBAQCBFeGFtcGxlIG11bHRp
IHBvcnQgaG9zdCBVU0IgY29udHJvbGxlciBkZXZpY2Ugbm9kZSA6DQo+ID4gIAkJcG9ydDE7DQo+
ID4gIAl9Ow0KPiA+DQo+ID4gLUV4YW1wbGUgZHVhbCByb2xlIFVTQiBjb250cm9sbGVyIGRldmlj
ZSBub2RlIDoNCj4gPiArRXhhbXBsZSBkdWFsIHJvbGUgVVNCIGNvbnRyb2xsZXIgdmVyc2lvbiAy
LjUgZGV2aWNlIG5vZGUgOg0KPiA+ICAJdXNiQDIzMDAwIHsNCj4gPiAtCQljb21wYXRpYmxlID0g
ImZzbC11c2IyLWRyIjsNCj4gPiArCQljb21wYXRpYmxlID0gImZzbC11c2IyLWRyLXYyLjUiLCAi
ZnNsLXVzYjItZHIiOw0KPiA+ICAJCXJlZyA9IDwyMzAwMCAxMDAwPjsNCj4gPiAgCQkjYWRkcmVz
cy1jZWxscyA9IDwxPjsNCj4gPiAgCQkjc2l6ZS1jZWxscyA9IDwwPjsNCj4gDQo+IFRoaXMgZXhh
bXBsZSBkb2Vzbid0IGNvcnJlc3BvbmQgdG8gYW55IGRldmljZSB0cmVlIEkgc2VlLiAgRXZlbiBh
ZnRlciB5b3VyIG5leHQNCj4gcGF0Y2ggdGhhdCBzZXRzIHQyMDgwJ3MgVVNCIHRvIHYyLjUsIHRo
ZSBhZGRyZXNzZXMgYXJlIGRpZmZlcmVudC4NCj4gDQo+IEFsc28sIGlmIHlvdSdyZSBnb2luZyB0
byB1cGRhdGUgdGhlIGV4YW1wbGUsIHBsZWFzZSBhbHNvIHVwZGF0ZSBpdCB0byBiZSBtb2Rlcm4N
Cj4gaW4gb3RoZXIgcmVzcGVjdHMsIHN1Y2ggYXMgdXNpbmcgMHggZm9yIGhleCBudW1iZXJzIChv
dXRzaWRlIHRoZSB1bml0IGFkZHJlc3MpLg0KPiANCj4gLVNjb3R0DQo+IA0KDQo=
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] Documentation: dts: fsl-usb: Document USB node compatible string for IP version
2014-08-22 4:48 ` nikhil.badola
@ 2014-08-22 5:05 ` Ramneek Mehresh
2014-08-26 22:53 ` Scott Wood
0 siblings, 1 reply; 7+ messages in thread
From: Ramneek Mehresh @ 2014-08-22 5:05 UTC (permalink / raw)
To: nikhil.badola@freescale.com, Scott Wood
Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
DQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBCYWRvbGEgTmlraGlsLUI0NjE3
MiANClNlbnQ6IEZyaWRheSwgQXVndXN0IDIyLCAyMDE0IDEwOjE4IEFNDQpUbzogV29vZCBTY290
dC1CMDc0MjENCkNjOiBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZzsgZGV2aWNldHJlZUB2
Z2VyLmtlcm5lbC5vcmc7IE1laHJlc2ggUmFtbmVlay1CMzEzODMNClN1YmplY3Q6IFJFOiBbUEFU
Q0hdIERvY3VtZW50YXRpb246IGR0czogZnNsLXVzYjogRG9jdW1lbnQgVVNCIG5vZGUgY29tcGF0
aWJsZSBzdHJpbmcgZm9yIElQIHZlcnNpb24NCg0KQWRkaW5nIFJhbW5lZWsNCg0KPiAtLS0tLU9y
aWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBXb29kIFNjb3R0LUIwNzQyMQ0KPiBTZW50OiBG
cmlkYXksIEF1Z3VzdCAyMiwgMjAxNCAzOjUzIEFNDQo+IFRvOiBCYWRvbGEgTmlraGlsLUI0NjE3
Mg0KPiBDYzogbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmc7IGRldmljZXRyZWVAdmdlci5r
ZXJuZWwub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdIERvY3VtZW50YXRpb246IGR0czogZnNs
LXVzYjogRG9jdW1lbnQgVVNCIG5vZGUgDQo+IGNvbXBhdGlibGUgc3RyaW5nIGZvciBJUCB2ZXJz
aW9uDQo+IA0KPiBPbiBUaHUsIDIwMTQtMDgtMjEgYXQgMTQ6NDggKzA1MzAsIE5pa2hpbCBCYWRv
bGEgd3JvdGU6DQo+ID4gRG9jdW1lbnQgY29tcGF0aWJsZSBzdHJpbmcgY29udGFpbmluZyBJUCB2
ZXJzaW9uIGluIFVTQiBkZXZpY2UgdHJlZSANCj4gPiBub2RlDQo+ID4NCj4gPiBTaWduZWQtb2Zm
LWJ5OiBOaWtoaWwgQmFkb2xhIDxuaWtoaWwuYmFkb2xhQGZyZWVzY2FsZS5jb20+DQo+ID4gLS0t
DQo+ID4gIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy91c2IvZnNsLXVzYi50eHQg
fCAxMyANCj4gPiArKysrKysrKy0tLS0tDQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlv
bnMoKyksIDUgZGVsZXRpb25zKC0pDQo+IA0KPiBQbGVhc2UgQ0MgZGV2aWNldHJlZUB2Z2VyLmtl
cm5lbC5vcmcgb24gYWxsIGRldmljZSB0cmVlIHBhdGNoZXMgKGluIA0KPiBhZGRpdGlvbiB0byBs
aW51eHBwYy1kZXYpLg0KPiANCj4gPg0KPiA+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2Rl
dmljZXRyZWUvYmluZGluZ3MvdXNiL2ZzbC11c2IudHh0DQo+ID4gYi9Eb2N1bWVudGF0aW9uL2Rl
dmljZXRyZWUvYmluZGluZ3MvdXNiL2ZzbC11c2IudHh0DQo+ID4gaW5kZXggNDc3OWMwMi4uNWEz
YTBhOCAxMDA2NDQNCj4gPiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mv
dXNiL2ZzbC11c2IudHh0DQo+ID4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp
bmdzL3VzYi9mc2wtdXNiLnR4dA0KPiA+IEBAIC0xMCw3ICsxMCwxMCBAQCBSZXF1aXJlZCBwcm9w
ZXJ0aWVzIDoNCj4gPiAgICAgY29udHJvbGxlcnMsIG9yICJmc2wtdXNiMi1kciIgZm9yIGR1YWwg
cm9sZSBVU0IgY29udHJvbGxlcnMNCj4gPiAgICAgb3IgImZzbCxtcGM1MTIxLXVzYjItZHIiIGZv
ciBkdWFsIHJvbGUgVVNCIGNvbnRyb2xsZXJzIG9mIE1QQzUxMjEuDQo+ID4gICAgIFdoZXJldmVy
IGFwcGxpY2FibGUsIHRoZSBJUCB2ZXJzaW9uIG9mIHRoZSBVU0IgY29udHJvbGxlciBzaG91bGQN
Cj4gPiAtICAgYWxzbyBiZSBtZW50aW9uZWQgKGZvciBlZy4gZnNsLXVzYjItZHItdjIuMiBmb3Ig
YnNjOTEzMikuDQo+ID4gKyAgIGFsc28gYmUgbWVudGlvbmVkIGluIGFub3RoZXIgc3RyaW5nLg0K
PiA+ICsgICBGb3IgbXVsdGkgcG9ydCBob3N0IFVTQiBjb250cm9sbGVyIHdpdGggSVAgdmVyc2lv
biA8SVBfVmVyPiwgaXQgc2hvdWxkIGJlDQo+ID4gKyAgICJmc2wtdXNiMi1tcGgtPElQX1Zlcj4i
LiBGb3IgZHVhbCByb2xlIFVTQiBjb250cm9sbGVyIHdpdGggSVAgdmVyc2lvbg0KPiA+ICsgICA8
SVBfVmVyPiwgaXQgc2hvdWxkIGJlICJmc2wtdXNiMi1kci08SVBfVmVyPiIuDQo+IA0KPiBJdCB3
YXMgZG9jdW1lbnRlZCBiZWZvcmUgLS0gdGhpcyBpcyBqdXN0IG1ha2luZyBpdCBtb3JlIGV4cGxp
Y2l0LCByaWdodD8NCj4gDQo+IEZXSVcsIHRoZSB2ZXJzaW9uIG51bWJlciBjYW4gYmUgcmVhZCBv
dXQgb2YgYSBVU0IgcmVnaXN0ZXIsIHNvIEknZCANCj4gcmF0aGVyIHJlbW92ZSB0aGUgc3VnZ2Vz
dGlvbiB0byBzcGVjaWZ5IHRoZSB2ZXJzaW9uIG51bWJlciBhbmQgcmVwbGFjZSANCj4gaXQgd2l0
aCBhIHJlZmVyZW5jZSB0byB0aGUgSUQgcmVnaXN0ZXIuDQp3ZSBoYXZlIGZvbGxvd2luZyB0d28g
aXNzdWVzIC0NCihhKSBvdXIgVVNCSVAgdmVyc2lvbiByZWdpc3RlciBkb2Vzbid0IGhhdmUgY29u
c2lzdGVudCAidmVyc2lvbiBmaWVsZCBzaXplIiBvdmVyIA0KbXVsdGlwbGUgdmVyc2lvbihzKS4g
VGhpcyBpcyB3aHkgd2UgY291bGRuJ3QgdXNlIGl0IGZvciByZWFkaW5nIHZlcnNpb24gaW5mbyBh
Y3Jvc3MNCnZhcmlvdXMgSVAgdmVyc2lvbnMNCihiKSB0aGlzIHJlZ2lzdGVyIGlzIG5vdCBleHBv
c2VkIGluIGFsbCBTb0MgUk1zIChwcm9iYWJseSBiZWNhdXNlIG9mIGFib3ZlIHJlYXNvbikNCj4g
DQo+ID4gICAtIHBoeV90eXBlIDogRm9yIG11bHRpIHBvcnQgaG9zdCBVU0IgY29udHJvbGxlcnMs
IHNob3VsZCBiZSBvbmUgb2YNCj4gPiAgICAgInVscGkiLCBvciAic2VyaWFsIi4gRm9yIGR1YWwg
cm9sZSBVU0IgY29udHJvbGxlcnMsIHNob3VsZCBiZQ0KPiA+ICAgICBvbmUgb2YgInVscGkiLCAi
dXRtaSIsICJ1dG1pX3dpZGUiLCBvciAic2VyaWFsIi4NCj4gPiBAQCAtNDIsOSArNDUsOSBAQCBP
cHRpb25hbCBwcm9wZXJ0aWVzIDoNCj4gPiAgIC0gZnNsLGludmVydC1wd3ItZmF1bHQgOiBib29s
ZWFuOyBmb3IgTVBDNTEyMSBVU0IwIG9ubHkuIEluZGljYXRlcw0KPiA+ICAgICB0aGUgUFdSX0ZB
VUxUIHNpZ25hbCBwb2xhcml0eSBpcyBpbnZlcnRlZC4NCj4gPg0KPiA+IC1FeGFtcGxlIG11bHRp
IHBvcnQgaG9zdCBVU0IgY29udHJvbGxlciBkZXZpY2Ugbm9kZSA6DQo+ID4gK0V4YW1wbGUgbXVs
dGkgcG9ydCBob3N0IFVTQiBjb250cm9sbGVyIHZlcnNpb24gMi41IGRldmljZSBub2RlIDoNCj4g
PiAgCXVzYkAyMjAwMCB7DQo+ID4gLQkJY29tcGF0aWJsZSA9ICJmc2wtdXNiMi1tcGgiOw0KPiA+
ICsJCWNvbXBhdGlibGUgPSAiZnNsLXVzYjItbXBoLXYyLjUiLCAiZnNsLXVzYjItbXBoIjsNCj4g
PiAgCQlyZWcgPSA8MjIwMDAgMTAwMD47DQo+ID4gIAkJI2FkZHJlc3MtY2VsbHMgPSA8MT47DQo+
ID4gIAkJI3NpemUtY2VsbHMgPSA8MD47DQo+ID4gQEAgLTU1LDkgKzU4LDkgQEAgRXhhbXBsZSBt
dWx0aSBwb3J0IGhvc3QgVVNCIGNvbnRyb2xsZXIgZGV2aWNlIG5vZGUgOg0KPiA+ICAJCXBvcnQx
Ow0KPiA+ICAJfTsNCj4gPg0KPiA+IC1FeGFtcGxlIGR1YWwgcm9sZSBVU0IgY29udHJvbGxlciBk
ZXZpY2Ugbm9kZSA6DQo+ID4gK0V4YW1wbGUgZHVhbCByb2xlIFVTQiBjb250cm9sbGVyIHZlcnNp
b24gMi41IGRldmljZSBub2RlIDoNCj4gPiAgCXVzYkAyMzAwMCB7DQo+ID4gLQkJY29tcGF0aWJs
ZSA9ICJmc2wtdXNiMi1kciI7DQo+ID4gKwkJY29tcGF0aWJsZSA9ICJmc2wtdXNiMi1kci12Mi41
IiwgImZzbC11c2IyLWRyIjsNCj4gPiAgCQlyZWcgPSA8MjMwMDAgMTAwMD47DQo+ID4gIAkJI2Fk
ZHJlc3MtY2VsbHMgPSA8MT47DQo+ID4gIAkJI3NpemUtY2VsbHMgPSA8MD47DQo+IA0KPiBUaGlz
IGV4YW1wbGUgZG9lc24ndCBjb3JyZXNwb25kIHRvIGFueSBkZXZpY2UgdHJlZSBJIHNlZS4gIEV2
ZW4gYWZ0ZXIgDQo+IHlvdXIgbmV4dCBwYXRjaCB0aGF0IHNldHMgdDIwODAncyBVU0IgdG8gdjIu
NSwgdGhlIGFkZHJlc3NlcyBhcmUgZGlmZmVyZW50Lg0KPiANCkkgcmVja29uIHRoYXQgdGhlIGV4
YW1wbGUgZW1waGFzaXplcyBvbiBzaG93aW5nIGhvdyBJUCB2ZXJzaW9uIGluZm9ybWF0aW9uIGlz
DQp0byBiZSBzdG9yZWQgaW4gImNvbXBhdGlibGUgc3RyaW5nIi4gSXMgaXQgbmVjZXNzYXJ5IHRv
IG1ha2Ugc3VyZSB0aGF0IHdlIHNob3VsZCANCmFsd2F5cyBzaXRlIGFjdHVhbCB2YWx1ZXMgYWxy
ZWFkeSB1c2VkPw0KPiBBbHNvLCBpZiB5b3UncmUgZ29pbmcgdG8gdXBkYXRlIHRoZSBleGFtcGxl
LCBwbGVhc2UgYWxzbyB1cGRhdGUgaXQgdG8gDQo+IGJlIG1vZGVybiBpbiBvdGhlciByZXNwZWN0
cywgc3VjaCBhcyB1c2luZyAweCBmb3IgaGV4IG51bWJlcnMgKG91dHNpZGUgdGhlIHVuaXQgYWRk
cmVzcykuDQo+IA0KPiAtU2NvdHQNCj4gDQoNCg==
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Documentation: dts: fsl-usb: Document USB node compatible string for IP version
2014-08-22 5:05 ` Ramneek Mehresh
@ 2014-08-26 22:53 ` Scott Wood
2014-08-27 5:46 ` Ramneek Mehresh
0 siblings, 1 reply; 7+ messages in thread
From: Scott Wood @ 2014-08-26 22:53 UTC (permalink / raw)
To: Mehresh Ramneek-B31383
Cc: devicetree@vger.kernel.org, Badola Nikhil-B46172,
linuxppc-dev@lists.ozlabs.org
On Fri, 2014-08-22 at 00:05 -0500, Mehresh Ramneek-B31383 wrote:
>
> -----Original Message-----
> From: Badola Nikhil-B46172
> Sent: Friday, August 22, 2014 10:18 AM
> To: Wood Scott-B07421
> Cc: linuxppc-dev@lists.ozlabs.org; devicetree@vger.kernel.org; Mehresh Ramneek-B31383
> Subject: RE: [PATCH] Documentation: dts: fsl-usb: Document USB node compatible string for IP version
>
> Adding Ramneek
>
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Friday, August 22, 2014 3:53 AM
> > To: Badola Nikhil-B46172
> > Cc: linuxppc-dev@lists.ozlabs.org; devicetree@vger.kernel.org
> > Subject: Re: [PATCH] Documentation: dts: fsl-usb: Document USB node
> > compatible string for IP version
> >
> > On Thu, 2014-08-21 at 14:48 +0530, Nikhil Badola wrote:
> > > Document compatible string containing IP version in USB device tree
> > > node
> > >
> > > Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com>
> > > ---
> > > Documentation/devicetree/bindings/usb/fsl-usb.txt | 13
> > > ++++++++-----
> > > 1 file changed, 8 insertions(+), 5 deletions(-)
> >
> > Please CC devicetree@vger.kernel.org on all device tree patches (in
> > addition to linuxppc-dev).
> >
> > >
> > > diff --git a/Documentation/devicetree/bindings/usb/fsl-usb.txt
> > > b/Documentation/devicetree/bindings/usb/fsl-usb.txt
> > > index 4779c02..5a3a0a8 100644
> > > --- a/Documentation/devicetree/bindings/usb/fsl-usb.txt
> > > +++ b/Documentation/devicetree/bindings/usb/fsl-usb.txt
> > > @@ -10,7 +10,10 @@ Required properties :
> > > controllers, or "fsl-usb2-dr" for dual role USB controllers
> > > or "fsl,mpc5121-usb2-dr" for dual role USB controllers of MPC5121.
> > > Wherever applicable, the IP version of the USB controller should
> > > - also be mentioned (for eg. fsl-usb2-dr-v2.2 for bsc9132).
> > > + also be mentioned in another string.
> > > + For multi port host USB controller with IP version <IP_Ver>, it should be
> > > + "fsl-usb2-mph-<IP_Ver>". For dual role USB controller with IP version
> > > + <IP_Ver>, it should be "fsl-usb2-dr-<IP_Ver>".
> >
> > It was documented before -- this is just making it more explicit, right?
> >
> > FWIW, the version number can be read out of a USB register, so I'd
> > rather remove the suggestion to specify the version number and replace
> > it with a reference to the ID register.
> we have following two issues -
> (a) our USBIP version register doesn't have consistent "version field size" over
> multiple version(s). This is why we couldn't use it for reading version info across
> various IP versions
> (b) this register is not exposed in all SoC RMs (probably because of above reason)
:-(
If this is just a problem with older chips, we could have a new
compatible name that designates the family of USB block versions with a
sane version register.
> > > @@ -55,9 +58,9 @@ Example multi port host USB controller device node :
> > > port1;
> > > };
> > >
> > > -Example dual role USB controller device node :
> > > +Example dual role USB controller version 2.5 device node :
> > > usb@23000 {
> > > - compatible = "fsl-usb2-dr";
> > > + compatible = "fsl-usb2-dr-v2.5", "fsl-usb2-dr";
> > > reg = <23000 1000>;
> > > #address-cells = <1>;
> > > #size-cells = <0>;
> >
> > This example doesn't correspond to any device tree I see. Even after
> > your next patch that sets t2080's USB to v2.5, the addresses are different.
> >
> I reckon that the example emphasizes on showing how IP version information is
> to be stored in "compatible string". Is it necessary to make sure that we should
> always site actual values already used?
The more realistic the examples are, the better.
-Scott
^ permalink raw reply [flat|nested] 7+ messages in thread* RE: [PATCH] Documentation: dts: fsl-usb: Document USB node compatible string for IP version
2014-08-26 22:53 ` Scott Wood
@ 2014-08-27 5:46 ` Ramneek Mehresh
2014-08-27 23:34 ` Scott Wood
0 siblings, 1 reply; 7+ messages in thread
From: Ramneek Mehresh @ 2014-08-27 5:46 UTC (permalink / raw)
To: Scott Wood
Cc: devicetree@vger.kernel.org, nikhil.badola@freescale.com,
linuxppc-dev@lists.ozlabs.org
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0
MjENCj4gU2VudDogV2VkbmVzZGF5LCBBdWd1c3QgMjcsIDIwMTQgNDoyMyBBTQ0KPiBUbzogTWVo
cmVzaCBSYW1uZWVrLUIzMTM4Mw0KPiBDYzogQmFkb2xhIE5pa2hpbC1CNDYxNzI7IGxpbnV4cHBj
LWRldkBsaXN0cy5vemxhYnMub3JnOw0KPiBkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZw0KPiBT
dWJqZWN0OiBSZTogW1BBVENIXSBEb2N1bWVudGF0aW9uOiBkdHM6IGZzbC11c2I6IERvY3VtZW50
IFVTQiBub2RlDQo+IGNvbXBhdGlibGUgc3RyaW5nIGZvciBJUCB2ZXJzaW9uDQo+IA0KPiBPbiBG
cmksIDIwMTQtMDgtMjIgYXQgMDA6MDUgLTA1MDAsIE1laHJlc2ggUmFtbmVlay1CMzEzODMgd3Jv
dGU6DQo+ID4NCj4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+IEZyb206IEJhZG9s
YSBOaWtoaWwtQjQ2MTcyDQo+ID4gU2VudDogRnJpZGF5LCBBdWd1c3QgMjIsIDIwMTQgMTA6MTgg
QU0NCj4gPiBUbzogV29vZCBTY290dC1CMDc0MjENCj4gPiBDYzogbGludXhwcGMtZGV2QGxpc3Rz
Lm96bGFicy5vcmc7IGRldmljZXRyZWVAdmdlci5rZXJuZWwub3JnOyBNZWhyZXNoDQo+ID4gUmFt
bmVlay1CMzEzODMNCj4gPiBTdWJqZWN0OiBSRTogW1BBVENIXSBEb2N1bWVudGF0aW9uOiBkdHM6
IGZzbC11c2I6IERvY3VtZW50IFVTQiBub2RlDQo+ID4gY29tcGF0aWJsZSBzdHJpbmcgZm9yIElQ
IHZlcnNpb24NCj4gPg0KPiA+IEFkZGluZyBSYW1uZWVrDQo+ID4NCj4gPiA+IC0tLS0tT3JpZ2lu
YWwgTWVzc2FnZS0tLS0tDQo+ID4gPiBGcm9tOiBXb29kIFNjb3R0LUIwNzQyMQ0KPiA+ID4gU2Vu
dDogRnJpZGF5LCBBdWd1c3QgMjIsIDIwMTQgMzo1MyBBTQ0KPiA+ID4gVG86IEJhZG9sYSBOaWto
aWwtQjQ2MTcyDQo+ID4gPiBDYzogbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmc7IGRldmlj
ZXRyZWVAdmdlci5rZXJuZWwub3JnDQo+ID4gPiBTdWJqZWN0OiBSZTogW1BBVENIXSBEb2N1bWVu
dGF0aW9uOiBkdHM6IGZzbC11c2I6IERvY3VtZW50IFVTQiBub2RlDQo+ID4gPiBjb21wYXRpYmxl
IHN0cmluZyBmb3IgSVAgdmVyc2lvbg0KPiA+ID4NCj4gPiA+IE9uIFRodSwgMjAxNC0wOC0yMSBh
dCAxNDo0OCArMDUzMCwgTmlraGlsIEJhZG9sYSB3cm90ZToNCj4gPiA+ID4gRG9jdW1lbnQgY29t
cGF0aWJsZSBzdHJpbmcgY29udGFpbmluZyBJUCB2ZXJzaW9uIGluIFVTQiBkZXZpY2UNCj4gPiA+
ID4gdHJlZSBub2RlDQo+ID4gPiA+DQo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IE5pa2hpbCBCYWRv
bGEgPG5pa2hpbC5iYWRvbGFAZnJlZXNjYWxlLmNvbT4NCj4gPiA+ID4gLS0tDQo+ID4gPiA+ICBE
b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdXNiL2ZzbC11c2IudHh0IHwgMTMNCj4g
PiA+ID4gKysrKysrKystLS0tLQ0KPiA+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9u
cygrKSwgNSBkZWxldGlvbnMoLSkNCj4gPiA+DQo+ID4gPiBQbGVhc2UgQ0MgZGV2aWNldHJlZUB2
Z2VyLmtlcm5lbC5vcmcgb24gYWxsIGRldmljZSB0cmVlIHBhdGNoZXMgKGluDQo+ID4gPiBhZGRp
dGlvbiB0byBsaW51eHBwYy1kZXYpLg0KPiA+ID4NCj4gPiA+ID4NCj4gPiA+ID4gZGlmZiAtLWdp
dCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy91c2IvZnNsLXVzYi50eHQNCj4g
PiA+ID4gYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdXNiL2ZzbC11c2IudHh0
DQo+ID4gPiA+IGluZGV4IDQ3NzljMDIuLjVhM2EwYTggMTAwNjQ0DQo+ID4gPiA+IC0tLSBhL0Rv
Y3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy91c2IvZnNsLXVzYi50eHQNCj4gPiA+ID4g
KysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3VzYi9mc2wtdXNiLnR4dA0K
PiA+ID4gPiBAQCAtMTAsNyArMTAsMTAgQEAgUmVxdWlyZWQgcHJvcGVydGllcyA6DQo+ID4gPiA+
ICAgICBjb250cm9sbGVycywgb3IgImZzbC11c2IyLWRyIiBmb3IgZHVhbCByb2xlIFVTQiBjb250
cm9sbGVycw0KPiA+ID4gPiAgICAgb3IgImZzbCxtcGM1MTIxLXVzYjItZHIiIGZvciBkdWFsIHJv
bGUgVVNCIGNvbnRyb2xsZXJzIG9mIE1QQzUxMjEuDQo+ID4gPiA+ICAgICBXaGVyZXZlciBhcHBs
aWNhYmxlLCB0aGUgSVAgdmVyc2lvbiBvZiB0aGUgVVNCIGNvbnRyb2xsZXIgc2hvdWxkDQo+ID4g
PiA+IC0gICBhbHNvIGJlIG1lbnRpb25lZCAoZm9yIGVnLiBmc2wtdXNiMi1kci12Mi4yIGZvciBi
c2M5MTMyKS4NCj4gPiA+ID4gKyAgIGFsc28gYmUgbWVudGlvbmVkIGluIGFub3RoZXIgc3RyaW5n
Lg0KPiA+ID4gPiArICAgRm9yIG11bHRpIHBvcnQgaG9zdCBVU0IgY29udHJvbGxlciB3aXRoIElQ
IHZlcnNpb24gPElQX1Zlcj4sIGl0IHNob3VsZA0KPiBiZQ0KPiA+ID4gPiArICAgImZzbC11c2Iy
LW1waC08SVBfVmVyPiIuIEZvciBkdWFsIHJvbGUgVVNCIGNvbnRyb2xsZXIgd2l0aCBJUCB2ZXJz
aW9uDQo+ID4gPiA+ICsgICA8SVBfVmVyPiwgaXQgc2hvdWxkIGJlICJmc2wtdXNiMi1kci08SVBf
VmVyPiIuDQo+ID4gPg0KPiA+ID4gSXQgd2FzIGRvY3VtZW50ZWQgYmVmb3JlIC0tIHRoaXMgaXMg
anVzdCBtYWtpbmcgaXQgbW9yZSBleHBsaWNpdCwgcmlnaHQ/DQo+ID4gPg0KPiA+ID4gRldJVywg
dGhlIHZlcnNpb24gbnVtYmVyIGNhbiBiZSByZWFkIG91dCBvZiBhIFVTQiByZWdpc3Rlciwgc28g
SSdkDQo+ID4gPiByYXRoZXIgcmVtb3ZlIHRoZSBzdWdnZXN0aW9uIHRvIHNwZWNpZnkgdGhlIHZl
cnNpb24gbnVtYmVyIGFuZA0KPiA+ID4gcmVwbGFjZSBpdCB3aXRoIGEgcmVmZXJlbmNlIHRvIHRo
ZSBJRCByZWdpc3Rlci4NCj4gPiB3ZSBoYXZlIGZvbGxvd2luZyB0d28gaXNzdWVzIC0NCj4gPiAo
YSkgb3VyIFVTQklQIHZlcnNpb24gcmVnaXN0ZXIgZG9lc24ndCBoYXZlIGNvbnNpc3RlbnQgInZl
cnNpb24gZmllbGQNCj4gPiBzaXplIiBvdmVyIG11bHRpcGxlIHZlcnNpb24ocykuIFRoaXMgaXMg
d2h5IHdlIGNvdWxkbid0IHVzZSBpdCBmb3INCj4gPiByZWFkaW5nIHZlcnNpb24gaW5mbyBhY3Jv
c3MgdmFyaW91cyBJUCB2ZXJzaW9ucw0KPiA+IChiKSB0aGlzIHJlZ2lzdGVyIGlzIG5vdCBleHBv
c2VkIGluIGFsbCBTb0MgUk1zIChwcm9iYWJseSBiZWNhdXNlIG9mDQo+ID4gYWJvdmUgcmVhc29u
KQ0KPiANCj4gOi0oDQo+IA0KPiBJZiB0aGlzIGlzIGp1c3QgYSBwcm9ibGVtIHdpdGggb2xkZXIg
Y2hpcHMsIHdlIGNvdWxkIGhhdmUgYSBuZXcgY29tcGF0aWJsZSBuYW1lDQo+IHRoYXQgZGVzaWdu
YXRlcyB0aGUgZmFtaWx5IG9mIFVTQiBibG9jayB2ZXJzaW9ucyB3aXRoIGEgc2FuZSB2ZXJzaW9u
IHJlZ2lzdGVyLg0KPiANCndlIGNvdWxkIGhhdmUgZG9uZS4uLmJ1dCB3ZSBoYXZlIGEgcmVxdWly
ZW1lbnQgdG8gd3JpdGUgdmVyc2lvbiBzcGVjaWZpYyBjb2RlLi4uDQpmb3IgaW5zdGFuY2UsIHVz
YiBjb250cm9sbGVyIGluaXQgc2VxdWVuY2UgaGFzIGNoYW5nZXMgZnJvbSB2ZXJzaW9uIDIuNSBv
bndhcmRzLi4uDQp0aGVuIHRoZXJlIGFyZSB2ZXJzaW9uIHNwZWNpZmljIGVycmF0YSBmaXhlKHMp
IGFsc28uIEhlbmNlIHdlIGRlY2lkZWQgdG8gZ28gZm9yDQpjb21wYXRpYmxlIHN0cmluZyBjb250
YWluaW5nIGh3IGlwIHZlcnNpb24gKG1ham9yIG5vLikgc28gdGhhdCBvdXIgd29ya2Fyb3VuZC9j
b2RlIGlzDQpjb25zaXN0ZW50IHdpdGggaHcgaXAgdmVyc2lvbihzKSBwdWJsaXNoZWQgaW4gZXJy
YXRhKHMpDQogDQo+ID4gPiA+IEBAIC01NSw5ICs1OCw5IEBAIEV4YW1wbGUgbXVsdGkgcG9ydCBo
b3N0IFVTQiBjb250cm9sbGVyIGRldmljZSBub2RlIDoNCj4gPiA+ID4gIAkJcG9ydDE7DQo+ID4g
PiA+ICAJfTsNCj4gPiA+ID4NCj4gPiA+ID4gLUV4YW1wbGUgZHVhbCByb2xlIFVTQiBjb250cm9s
bGVyIGRldmljZSBub2RlIDoNCj4gPiA+ID4gK0V4YW1wbGUgZHVhbCByb2xlIFVTQiBjb250cm9s
bGVyIHZlcnNpb24gMi41IGRldmljZSBub2RlIDoNCj4gPiA+ID4gIAl1c2JAMjMwMDAgew0KPiA+
ID4gPiAtCQljb21wYXRpYmxlID0gImZzbC11c2IyLWRyIjsNCj4gPiA+ID4gKwkJY29tcGF0aWJs
ZSA9ICJmc2wtdXNiMi1kci12Mi41IiwgImZzbC11c2IyLWRyIjsNCj4gPiA+ID4gIAkJcmVnID0g
PDIzMDAwIDEwMDA+Ow0KPiA+ID4gPiAgCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsNCj4gPiA+ID4g
IAkJI3NpemUtY2VsbHMgPSA8MD47DQo+ID4gPg0KPiA+ID4gVGhpcyBleGFtcGxlIGRvZXNuJ3Qg
Y29ycmVzcG9uZCB0byBhbnkgZGV2aWNlIHRyZWUgSSBzZWUuICBFdmVuDQo+ID4gPiBhZnRlciB5
b3VyIG5leHQgcGF0Y2ggdGhhdCBzZXRzIHQyMDgwJ3MgVVNCIHRvIHYyLjUsIHRoZSBhZGRyZXNz
ZXMgYXJlDQo+IGRpZmZlcmVudC4NCj4gPiA+DQo+ID4gSSByZWNrb24gdGhhdCB0aGUgZXhhbXBs
ZSBlbXBoYXNpemVzIG9uIHNob3dpbmcgaG93IElQIHZlcnNpb24NCj4gPiBpbmZvcm1hdGlvbiBp
cyB0byBiZSBzdG9yZWQgaW4gImNvbXBhdGlibGUgc3RyaW5nIi4gSXMgaXQgbmVjZXNzYXJ5IHRv
DQo+ID4gbWFrZSBzdXJlIHRoYXQgd2Ugc2hvdWxkIGFsd2F5cyBzaXRlIGFjdHVhbCB2YWx1ZXMg
YWxyZWFkeSB1c2VkPw0KPiANCj4gVGhlIG1vcmUgcmVhbGlzdGljIHRoZSBleGFtcGxlcyBhcmUs
IHRoZSBiZXR0ZXIuDQo+IA0KdW5kZXJzdG9vZC4uLndlIGFncmVlIA0KDQo+IC1TY290dA0KPiAN
Cg0K
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Documentation: dts: fsl-usb: Document USB node compatible string for IP version
2014-08-27 5:46 ` Ramneek Mehresh
@ 2014-08-27 23:34 ` Scott Wood
0 siblings, 0 replies; 7+ messages in thread
From: Scott Wood @ 2014-08-27 23:34 UTC (permalink / raw)
To: Mehresh Ramneek-B31383
Cc: devicetree@vger.kernel.org, Badola Nikhil-B46172,
linuxppc-dev@lists.ozlabs.org
On Wed, 2014-08-27 at 00:46 -0500, Mehresh Ramneek-B31383 wrote:
>
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Wednesday, August 27, 2014 4:23 AM
> > To: Mehresh Ramneek-B31383
> > Cc: Badola Nikhil-B46172; linuxppc-dev@lists.ozlabs.org;
> > devicetree@vger.kernel.org
> > Subject: Re: [PATCH] Documentation: dts: fsl-usb: Document USB node
> > compatible string for IP version
> >
> > On Fri, 2014-08-22 at 00:05 -0500, Mehresh Ramneek-B31383 wrote:
> > >
> > > -----Original Message-----
> > > From: Badola Nikhil-B46172
> > > Sent: Friday, August 22, 2014 10:18 AM
> > > To: Wood Scott-B07421
> > > Cc: linuxppc-dev@lists.ozlabs.org; devicetree@vger.kernel.org; Mehresh
> > > Ramneek-B31383
> > > Subject: RE: [PATCH] Documentation: dts: fsl-usb: Document USB node
> > > compatible string for IP version
> > >
> > > Adding Ramneek
> > >
> > > > -----Original Message-----
> > > > From: Wood Scott-B07421
> > > > Sent: Friday, August 22, 2014 3:53 AM
> > > > To: Badola Nikhil-B46172
> > > > Cc: linuxppc-dev@lists.ozlabs.org; devicetree@vger.kernel.org
> > > > Subject: Re: [PATCH] Documentation: dts: fsl-usb: Document USB node
> > > > compatible string for IP version
> > > >
> > > > On Thu, 2014-08-21 at 14:48 +0530, Nikhil Badola wrote:
> > > > > Document compatible string containing IP version in USB device
> > > > > tree node
> > > > >
> > > > > Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com>
> > > > > ---
> > > > > Documentation/devicetree/bindings/usb/fsl-usb.txt | 13
> > > > > ++++++++-----
> > > > > 1 file changed, 8 insertions(+), 5 deletions(-)
> > > >
> > > > Please CC devicetree@vger.kernel.org on all device tree patches (in
> > > > addition to linuxppc-dev).
> > > >
> > > > >
> > > > > diff --git a/Documentation/devicetree/bindings/usb/fsl-usb.txt
> > > > > b/Documentation/devicetree/bindings/usb/fsl-usb.txt
> > > > > index 4779c02..5a3a0a8 100644
> > > > > --- a/Documentation/devicetree/bindings/usb/fsl-usb.txt
> > > > > +++ b/Documentation/devicetree/bindings/usb/fsl-usb.txt
> > > > > @@ -10,7 +10,10 @@ Required properties :
> > > > > controllers, or "fsl-usb2-dr" for dual role USB controllers
> > > > > or "fsl,mpc5121-usb2-dr" for dual role USB controllers of MPC5121.
> > > > > Wherever applicable, the IP version of the USB controller should
> > > > > - also be mentioned (for eg. fsl-usb2-dr-v2.2 for bsc9132).
> > > > > + also be mentioned in another string.
> > > > > + For multi port host USB controller with IP version <IP_Ver>, it should
> > be
> > > > > + "fsl-usb2-mph-<IP_Ver>". For dual role USB controller with IP version
> > > > > + <IP_Ver>, it should be "fsl-usb2-dr-<IP_Ver>".
> > > >
> > > > It was documented before -- this is just making it more explicit, right?
> > > >
> > > > FWIW, the version number can be read out of a USB register, so I'd
> > > > rather remove the suggestion to specify the version number and
> > > > replace it with a reference to the ID register.
> > > we have following two issues -
> > > (a) our USBIP version register doesn't have consistent "version field
> > > size" over multiple version(s). This is why we couldn't use it for
> > > reading version info across various IP versions
> > > (b) this register is not exposed in all SoC RMs (probably because of
> > > above reason)
> >
> > :-(
> >
> > If this is just a problem with older chips, we could have a new compatible name
> > that designates the family of USB block versions with a sane version register.
> >
> we could have done...but we have a requirement to write version specific code...
> for instance, usb controller init sequence has changes from version 2.5 onwards...
> then there are version specific errata fixe(s) also. Hence we decided to go for
> compatible string containing hw ip version (major no.) so that our workaround/code is
> consistent with hw ip version(s) published in errata(s)
I wasn't saying ignore version differences. I was suggesting that we
make a special case out of older versions where the version register is
different/broken.
-Scott
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-08-27 23:35 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-21 9:18 [PATCH] Documentation: dts: fsl-usb: Document USB node compatible string for IP version Nikhil Badola
2014-08-21 22:22 ` Scott Wood
2014-08-22 4:48 ` nikhil.badola
2014-08-22 5:05 ` Ramneek Mehresh
2014-08-26 22:53 ` Scott Wood
2014-08-27 5:46 ` Ramneek Mehresh
2014-08-27 23:34 ` Scott Wood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).