* [PATCH] powerpc: dts: t208x: Change T208x USB controller version
@ 2014-08-21 10:31 Nikhil Badola
2014-08-21 22:36 ` Scott Wood
0 siblings, 1 reply; 4+ messages in thread
From: Nikhil Badola @ 2014-08-21 10:31 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Nikhil Badola
Change USB controller version to 2.5 in compatible string for T2080/T2081
Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com>
---
Checkpatch warnings handled by commit 61a8c2c6fe71082de3ea8629589dcdd0cc5c3f02
Documentation: dts: fsl-usb: Document USB node compatible string for IP version
arch/powerpc/boot/dts/fsl/t2081si-post.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi b/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
index 97479f0..aecee96 100644
--- a/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
@@ -410,7 +410,7 @@
/include/ "qoriq-gpio-3.dtsi"
/include/ "qoriq-usb2-mph-0.dtsi"
usb0: usb@210000 {
- compatible = "fsl-usb2-mph-v2.4", "fsl-usb2-mph";
+ compatible = "fsl-usb2-mph-v2.5", "fsl-usb2-mph";
fsl,iommu-parent = <&pamu1>;
fsl,liodn-reg = <&guts 0x520>; /* USB1LIODNR */
phy_type = "utmi";
@@ -418,7 +418,7 @@
};
/include/ "qoriq-usb2-dr-0.dtsi"
usb1: usb@211000 {
- compatible = "fsl-usb2-dr-v2.4", "fsl-usb2-dr";
+ compatible = "fsl-usb2-dr-v2.5", "fsl-usb2-dr";
fsl,iommu-parent = <&pamu1>;
fsl,liodn-reg = <&guts 0x524>; /* USB1LIODNR */
dr_mode = "host";
--
1.7.11.7
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] powerpc: dts: t208x: Change T208x USB controller version
2014-08-21 10:31 [PATCH] powerpc: dts: t208x: Change T208x USB controller version Nikhil Badola
@ 2014-08-21 22:36 ` Scott Wood
2014-09-10 4:45 ` nikhil.badola
0 siblings, 1 reply; 4+ messages in thread
From: Scott Wood @ 2014-08-21 22:36 UTC (permalink / raw)
To: Nikhil Badola; +Cc: devicetree, linuxppc-dev
On Thu, 2014-08-21 at 16:01 +0530, Nikhil Badola wrote:
> Change USB controller version to 2.5 in compatible string for T2080/T2081
>
> Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com>
> ---
> Checkpatch warnings handled by commit 61a8c2c6fe71082de3ea8629589dcdd0cc5c3f02
That checkpatch warning is known to have false positives in cases where
the binding says "<CHIPNAME>-device" or "device-<VERSION>". If you want
to update the binding to give an example with a version, that's fine,
but checkpatch shouldn't be why. We're not going to update the binding
example again to match a different version the next time one is added to
a device tree...
> Documentation: dts: fsl-usb: Document USB node compatible string for IP version
>
> arch/powerpc/boot/dts/fsl/t2081si-post.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi b/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
> index 97479f0..aecee96 100644
> --- a/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
> @@ -410,7 +410,7 @@
> /include/ "qoriq-gpio-3.dtsi"
> /include/ "qoriq-usb2-mph-0.dtsi"
> usb0: usb@210000 {
> - compatible = "fsl-usb2-mph-v2.4", "fsl-usb2-mph";
> + compatible = "fsl-usb2-mph-v2.5", "fsl-usb2-mph";
This is an example of why it's better to rely on version registers when
present.
-Scott
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] powerpc: dts: t208x: Change T208x USB controller version
2014-08-21 22:36 ` Scott Wood
@ 2014-09-10 4:45 ` nikhil.badola
2014-09-10 5:16 ` Scott Wood
0 siblings, 1 reply; 4+ messages in thread
From: nikhil.badola @ 2014-09-10 4:45 UTC (permalink / raw)
To: Scott Wood; +Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Pi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+RnJvbTogV29vZCBTY290dC1CMDc0MjENCj5T
ZW50OiBGcmlkYXksIEF1Z3VzdCAyMiwgMjAxNCA0OjA3IEFNDQo+VG86IEJhZG9sYSBOaWtoaWwt
QjQ2MTcyDQo+Q2M6IGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnOyBkZXZpY2V0cmVlQHZn
ZXIua2VybmVsLm9yZw0KPlN1YmplY3Q6IFJlOiBbUEFUQ0hdIHBvd2VycGM6IGR0czogdDIwOHg6
IENoYW5nZSBUMjA4eCBVU0IgY29udHJvbGxlciB2ZXJzaW9uDQo+DQo+T24gVGh1LCAyMDE0LTA4
LTIxIGF0IDE2OjAxICswNTMwLCBOaWtoaWwgQmFkb2xhIHdyb3RlOg0KPj4gQ2hhbmdlIFVTQiBj
b250cm9sbGVyIHZlcnNpb24gdG8gMi41IGluIGNvbXBhdGlibGUgc3RyaW5nIGZvcg0KPj4gVDIw
ODAvVDIwODENCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBOaWtoaWwgQmFkb2xhIDxuaWtoaWwuYmFk
b2xhQGZyZWVzY2FsZS5jb20+DQo+PiAtLS0NCj4+IAlDaGVja3BhdGNoIHdhcm5pbmdzIGhhbmRs
ZWQgYnkgY29tbWl0DQo+PiA2MWE4YzJjNmZlNzEwODJkZTNlYTg2Mjk1ODlkY2RkMGNjNWMzZjAy
DQo+DQo+VGhhdCBjaGVja3BhdGNoIHdhcm5pbmcgaXMga25vd24gdG8gaGF2ZSBmYWxzZSBwb3Np
dGl2ZXMgaW4gY2FzZXMgd2hlcmUgdGhlDQo+YmluZGluZyBzYXlzICI8Q0hJUE5BTUU+LWRldmlj
ZSIgb3IgImRldmljZS08VkVSU0lPTj4iLiAgSWYgeW91IHdhbnQgdG8NCj51cGRhdGUgdGhlIGJp
bmRpbmcgdG8gZ2l2ZSBhbiBleGFtcGxlIHdpdGggYSB2ZXJzaW9uLCB0aGF0J3MgZmluZSwgYnV0
DQo+Y2hlY2twYXRjaCBzaG91bGRuJ3QgYmUgd2h5LiAgV2UncmUgbm90IGdvaW5nIHRvIHVwZGF0
ZSB0aGUgYmluZGluZyBleGFtcGxlDQo+YWdhaW4gdG8gbWF0Y2ggYSBkaWZmZXJlbnQgdmVyc2lv
biB0aGUgbmV4dCB0aW1lIG9uZSBpcyBhZGRlZCB0byBhIGRldmljZSB0cmVlLi4uDQo+DQo+PiAJ
RG9jdW1lbnRhdGlvbjogZHRzOiBmc2wtdXNiOiBEb2N1bWVudCBVU0Igbm9kZSBjb21wYXRpYmxl
IHN0cmluZyBmb3INCj5JUCB2ZXJzaW9uDQo+Pg0KPj4gIGFyY2gvcG93ZXJwYy9ib290L2R0cy9m
c2wvdDIwODFzaS1wb3N0LmR0c2kgfCA0ICsrLS0NCj4+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNl
cnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQ0KPj4NCj4+IGRpZmYgLS1naXQgYS9hcmNoL3Bvd2Vy
cGMvYm9vdC9kdHMvZnNsL3QyMDgxc2ktcG9zdC5kdHNpDQo+PiBiL2FyY2gvcG93ZXJwYy9ib290
L2R0cy9mc2wvdDIwODFzaS1wb3N0LmR0c2kNCj4+IGluZGV4IDk3NDc5ZjAuLmFlY2VlOTYgMTAw
NjQ0DQo+PiAtLS0gYS9hcmNoL3Bvd2VycGMvYm9vdC9kdHMvZnNsL3QyMDgxc2ktcG9zdC5kdHNp
DQo+PiArKysgYi9hcmNoL3Bvd2VycGMvYm9vdC9kdHMvZnNsL3QyMDgxc2ktcG9zdC5kdHNpDQo+
PiBAQCAtNDEwLDcgKzQxMCw3IEBADQo+PiAgL2luY2x1ZGUvICJxb3JpcS1ncGlvLTMuZHRzaSIN
Cj4+ICAvaW5jbHVkZS8gInFvcmlxLXVzYjItbXBoLTAuZHRzaSINCj4+ICAJdXNiMDogdXNiQDIx
MDAwMCB7DQo+PiAtCQljb21wYXRpYmxlID0gImZzbC11c2IyLW1waC12Mi40IiwgImZzbC11c2Iy
LW1waCI7DQo+PiArCQljb21wYXRpYmxlID0gImZzbC11c2IyLW1waC12Mi41IiwgImZzbC11c2Iy
LW1waCI7DQo+DQo+VGhpcyBpcyBhbiBleGFtcGxlIG9mIHdoeSBpdCdzIGJldHRlciB0byByZWx5
IG9uIHZlcnNpb24gcmVnaXN0ZXJzIHdoZW4gcHJlc2VudC4NCj4NCj4tU2NvdHQNCj4NCkhpIHNj
b3R0LA0KDQpJIGNhbiBzZWUgdGhpcyBwYXRjaCBpbiAic3VwZXJzZWRlZCIgc3RhdGUgaW4gcGF0
Y2h3b3JrLiBBcyBwZXIgb3VyIGRpc2N1c3Npb24gdGhlIElQIHZlcnNpb24gY2hlY2tpbmcgaXMg
dG8gYmUgZG9uZSBieSBjb21wYXRpYmxlIHN0cmluZyBvbmx5LCBzbyBjYW4gSSBwcm9jZWVkIHRv
IHNlbmQgdGhpcyBwYXRjaCBhZ2Fpbj8NCg==
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc: dts: t208x: Change T208x USB controller version
2014-09-10 4:45 ` nikhil.badola
@ 2014-09-10 5:16 ` Scott Wood
0 siblings, 0 replies; 4+ messages in thread
From: Scott Wood @ 2014-09-10 5:16 UTC (permalink / raw)
To: Badola Nikhil-B46172
Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
On Tue, 2014-09-09 at 23:45 -0500, Badola Nikhil-B46172 wrote:
> >-----Original Message-----
> >From: Wood Scott-B07421
> >Sent: Friday, August 22, 2014 4:07 AM
> >To: Badola Nikhil-B46172
> >Cc: linuxppc-dev@lists.ozlabs.org; devicetree@vger.kernel.org
> >Subject: Re: [PATCH] powerpc: dts: t208x: Change T208x USB controller version
> >
> >On Thu, 2014-08-21 at 16:01 +0530, Nikhil Badola wrote:
> >> Change USB controller version to 2.5 in compatible string for
> >> T2080/T2081
> >>
> >> Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com>
> >> ---
> >> Checkpatch warnings handled by commit
> >> 61a8c2c6fe71082de3ea8629589dcdd0cc5c3f02
> >
> >That checkpatch warning is known to have false positives in cases where the
> >binding says "<CHIPNAME>-device" or "device-<VERSION>". If you want to
> >update the binding to give an example with a version, that's fine, but
> >checkpatch shouldn't be why. We're not going to update the binding example
> >again to match a different version the next time one is added to a device tree...
> >
> >> Documentation: dts: fsl-usb: Document USB node compatible string for
> >IP version
> >>
> >> arch/powerpc/boot/dts/fsl/t2081si-post.dtsi | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
> >> b/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
> >> index 97479f0..aecee96 100644
> >> --- a/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
> >> +++ b/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
> >> @@ -410,7 +410,7 @@
> >> /include/ "qoriq-gpio-3.dtsi"
> >> /include/ "qoriq-usb2-mph-0.dtsi"
> >> usb0: usb@210000 {
> >> - compatible = "fsl-usb2-mph-v2.4", "fsl-usb2-mph";
> >> + compatible = "fsl-usb2-mph-v2.5", "fsl-usb2-mph";
> >
> >This is an example of why it's better to rely on version registers when present.
> >
> >-Scott
> >
> Hi scott,
>
> I can see this patch in "superseded" state in patchwork. As per our discussion the IP version checking is to be done by compatible string only, so can I proceed to send this patch again?
Sorry, apparently I thought that
http://patchwork.ozlabs.org/patch/383670/ was a newer version of the
patch, and didn't notice they were for different chips. No need to
resend. Thanks for pointing this out.
-Scott
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-09-10 5:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-21 10:31 [PATCH] powerpc: dts: t208x: Change T208x USB controller version Nikhil Badola
2014-08-21 22:36 ` Scott Wood
2014-09-10 4:45 ` nikhil.badola
2014-09-10 5:16 ` Scott Wood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).