From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1lp0145.outbound.protection.outlook.com [207.46.163.145]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 21BE51A004F for ; Thu, 28 Aug 2014 09:33:47 +1000 (EST) Message-ID: <1409182412.6510.129.camel@snotra.buserror.net> Subject: Re: [RESEND] clk: ppc-corenet: Add Freescale ARM-based platforms CLK_OF_DECLARE support From: Scott Wood To: Lu Jingchang-B35083 Date: Wed, 27 Aug 2014 18:33:32 -0500 In-Reply-To: <164af7b3be3747a0be3fe3a6cf83d3b1@BL2PR03MB467.namprd03.prod.outlook.com> References: <1408700096-25415-1-git-send-email-jingchang.lu@freescale.com> <1409093463.6510.92.camel@snotra.buserror.net> <164af7b3be3747a0be3fe3a6cf83d3b1@BL2PR03MB467.namprd03.prod.outlook.com> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Cc: "linuxppc-dev@lists.ozlabs.org" , "mturquette@linaro.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2014-08-26 at 21:19 -0500, Lu Jingchang-B35083 wrote: > >-----Original Message----- > >From: Wood Scott-B07421 > >Sent: Wednesday, August 27, 2014 6:51 AM > >To: Lu Jingchang-B35083 > >Cc: mturquette@linaro.org; linuxppc-dev@lists.ozlabs.org; linux- > >kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org > >Subject: Re: [RESEND] clk: ppc-corenet: Add Freescale ARM-based platforms > >CLK_OF_DECLARE support > > > >On Fri, 2014-08-22 at 17:34 +0800, Jingchang Lu wrote: > >> +CLK_OF_DECLARE(ppc_core_pll_v1, "fsl,qoriq-core-pll-1.0", > >core_pll_init); > >> +CLK_OF_DECLARE(ppc_core_pll_v2, "fsl,qoriq-core-pll-2.0", > >core_pll_init); > >> +CLK_OF_DECLARE(ppc_core_mux_v1, "fsl,qoriq-core-mux-1.0", > >core_mux_init); > >> +CLK_OF_DECLARE(ppc_core_mux_v2, "fsl,qoriq-core-mux-2.0", > >core_mux_init); > > > >What does this do that the existing platform driver and match table > >don't? Why is it needed for ARM when PPC didn't need it? > > > >-Scott > > > Common clk init on ARM platform is initialized earlier via of_clk_init() instead of > driver probe method, the of_clk_init will walk a __clk_of_table to init each clk provider > in the table, the CLK_OF_DECLARE() macro puts a supported clk in the __clk_of_table for > it initializing on starup, and the clk system has added some common clk such as "fixed-clk" > to this table already. > So here I add our specific clk init declaration to consist this framework, and the driver > probe function will not be needed on ARM. OK... Is there any reason why the new method won't work on PPC? -Scott