From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 616101A001E for ; Fri, 29 Aug 2014 17:04:48 +1000 (EST) Message-ID: <1409295887.9191.6.camel@concordia> Subject: Re: [PATCH] drivers: char: hw_random: printk replacement From: Michael Ellerman To: Sudip Mukherjee Date: Fri, 29 Aug 2014 17:04:47 +1000 In-Reply-To: <1409238178-16496-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1409238178-16496-1-git-send-email-sudipm.mukherjee@gmail.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: Herbert Xu , linux-kernel@vger.kernel.org, linux-geode@lists.infradead.org, Matt Mackall , Olof Johansson , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2014-08-28 at 20:32 +0530, Sudip Mukherjee wrote: > as pr_* macros are more preffered over printk, so printk replaced with corresponding pr_* macros I suppose ... > drivers/char/hw_random/pasemi-rng.c | 2 +- > drivers/char/hw_random/pseries-rng.c | 2 +- These look OK to me. cheers