From: Michael Ellerman <mpe@ellerman.id.au>
To: Alexander Gordeev <agordeev@redhat.com>
Cc: linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] PCI/MSI/PPC: Remove arch_msi_check_device()
Date: Fri, 29 Aug 2014 18:41:32 +1000 [thread overview]
Message-ID: <1409301692.30345.1.camel@concordia> (raw)
In-Reply-To: <18276ae8c0b212b8d40dfd186e1c84b8ae949525.1405160163.git.agordeev@redhat.com>
On Sat, 2014-07-12 at 13:21 +0200, Alexander Gordeev wrote:
> PowerPC is the only architecture that makes use of hook
> arch_msi_check_device() and does perform some checks to
> figure out if MSI/MSI-X could be enabled for a device.
> However, there are no reasons why those checks could not
> be done within arch_setup_msi_irqs() hook.
>
> Moving MSI checks into arch_setup_msi_irqs() makes code
> more readable and allows getting rid of unnecessary hook
> arch_msi_check_device().
The intention was that this hook allowed a platform to reject the request
early, ie. before all the setup had been done. But if no one except us is using
it then fine, get rid of it.
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
cheers
next prev parent reply other threads:[~2014-08-29 8:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-12 11:21 [PATCH 0/2] PCI/MSI: Remove arch_msi_check_device() Alexander Gordeev
2014-07-12 11:21 ` [PATCH 1/2] PCI/MSI/PPC: " Alexander Gordeev
2014-07-31 13:53 ` Alexander Gordeev
2014-08-19 7:50 ` Alexander Gordeev
2014-08-29 8:41 ` Michael Ellerman [this message]
2014-07-12 11:21 ` [PATCH 2/2] PCI/MSI: " Alexander Gordeev
2014-07-14 2:11 ` Yijing Wang
2014-07-14 9:55 ` Alexander Gordeev
2014-07-16 22:20 ` Bjorn Helgaas
2014-07-17 10:22 ` Alexander Gordeev
2014-08-11 11:45 ` [PATCH v2 " Alexander Gordeev
2014-08-11 14:33 ` Bharat.Bhushan
2014-08-11 19:35 ` Alexander Gordeev
2014-09-05 21:25 ` [PATCH 0/2] " Bjorn Helgaas
2014-09-05 21:27 ` Bjorn Helgaas
2014-09-07 19:07 ` Alexander Gordeev
2014-09-09 0:43 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409301692.30345.1.camel@concordia \
--to=mpe@ellerman.id.au \
--cc=agordeev@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).