From: Johannes Berg <johannes@sipsolutions.net>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>
Subject: Re: [PATCH] sound: aoa: printk replacement
Date: Wed, 10 Sep 2014 15:57:04 +0200 [thread overview]
Message-ID: <1410357424.2761.5.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1410357107-29933-1-git-send-email-sudipm.mukherjee@gmail.com> (sfid-20140910_155200_822543_7A3FBE01)
On Wed, 2014-09-10 at 19:21 +0530, Sudip Mukherjee wrote:
> as pr_* macros are more preffered over printk, so printk replaced
> with corresponding pr_* macros.
Are you simply running checkpatch on every file and decided to do
something about it? :)
I'll let Takashi decide whether to take this or not as I no longer care
about this code, but IMHO this changes is completely pointless since you
don't also clean up the code to have a common prefix with #define pr_fmt
and then clean up the callers etc.
There's a reason pr_* is preferred, but random code changes like this
aren't it, I think.
johannes
next prev parent reply other threads:[~2014-09-10 14:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 13:51 [PATCH] sound: aoa: printk replacement Sudip Mukherjee
2014-09-10 13:57 ` Johannes Berg [this message]
2014-09-10 14:32 ` Sudip Mukherjee
2014-09-10 14:43 ` Takashi Iwai
2014-09-10 15:07 ` Sudip Mukherjee
2014-09-10 15:38 ` Takashi Iwai
2014-09-10 17:14 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410357424.2761.5.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=perex@perex.cz \
--cc=sudipm.mukherjee@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).