From: Michael Ellerman <mpe@ellerman.id.au>
To: Aaron Tomlin <atomlin@redhat.com>
Cc: dzickus@redhat.com, jcastillo@redhat.com, riel@redhat.com,
prarit@redhat.com, pzijlstr@redhat.com, peterz@infradead.org,
bmr@redhat.com, x86@kernel.org, oleg@redhat.com,
rostedt@goodmis.org, linux-kernel@vger.kernel.org,
minchan@kernel.org, mingo@redhat.com, tglx@linutronix.de,
aneesh.kumar@linux.vnet.ibm.com, hannes@cmpxchg.org,
akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org,
jgh@redhat.com, akpm@google.com
Subject: Re: [PATCH v3 1/3] init/main.c: Give init_task a canary
Date: Fri, 12 Sep 2014 17:28:56 +1000 [thread overview]
Message-ID: <1410506936.17540.7.camel@concordia> (raw)
In-Reply-To: <1410450088-18236-2-git-send-email-atomlin@redhat.com>
On Thu, 2014-09-11 at 16:41 +0100, Aaron Tomlin wrote:
> Tasks get their end of stack set to STACK_END_MAGIC with the
> aim to catch stack overruns. Currently this feature does not
> apply to init_task. This patch removes this restriction.
>
> diff --git a/arch/powerpc/mm/fault.c b/arch/powerpc/mm/fault.c
> index 51ab9e7..35d0760c 100644
> --- a/arch/powerpc/mm/fault.c
> +++ b/arch/powerpc/mm/fault.c
> @@ -30,7 +30,6 @@
> #include <linux/kprobes.h>
> #include <linux/kdebug.h>
> #include <linux/perf_event.h>
> -#include <linux/magic.h>
> #include <linux/ratelimit.h>
> #include <linux/context_tracking.h>
>
> @@ -538,7 +537,7 @@ void bad_page_fault(struct pt_regs *regs, unsigned long address, int sig)
> regs->nip);
>
> stackend = end_of_stack(current);
> - if (current != &init_task && *stackend != STACK_END_MAGIC)
> + if (*stackend != STACK_END_MAGIC)
> printk(KERN_ALERT "Thread overran stack, or stack corrupted\n");
This part looks fine.
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
cheers
next prev parent reply other threads:[~2014-09-12 7:28 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 14:50 [PATCH 0/2] sched: Always check the integrity of the canary Aaron Tomlin
2014-09-04 14:50 ` [PATCH 1/2] sched: Add helper for task stack page overrun checking Aaron Tomlin
2014-09-04 15:02 ` Oleg Nesterov
2014-09-04 15:52 ` Aaron Tomlin
2014-09-04 15:30 ` Peter Zijlstra
2014-09-04 14:50 ` [PATCH 2/2] sched: BUG when stack end location is over written Aaron Tomlin
2014-09-04 15:32 ` Peter Zijlstra
2014-09-04 16:11 ` Aaron Tomlin
2014-09-08 19:23 ` [PATCH v2 0/3] sched: Always check the integrity of the canary Aaron Tomlin
2014-09-08 19:23 ` [PATCH 1/3] init/main.c: Give init_task a canary Aaron Tomlin
2014-09-08 19:23 ` [PATCH 2/3] sched: Add helper for task stack page overrun checking Aaron Tomlin
2014-09-08 19:23 ` [PATCH 3/3] sched: BUG when stack end location is over written Aaron Tomlin
2014-09-09 9:42 ` [PATCH v2 0/3] sched: Always check the integrity of the canary Aaron Tomlin
2014-09-09 9:42 ` [PATCH v2 1/3] init/main.c: Give init_task a canary Aaron Tomlin
2014-09-10 7:26 ` Chuck Ebbert
2014-09-10 13:29 ` Aaron Tomlin
2014-09-11 12:23 ` Chuck Ebbert
2014-09-11 14:47 ` Aaron Tomlin
2014-09-09 9:42 ` [PATCH v2 2/3] sched: Add helper for task stack page overrun checking Aaron Tomlin
2014-09-09 9:42 ` [PATCH v2 3/3] sched: BUG when stack end location is over written Aaron Tomlin
2014-09-11 15:41 ` [PATCH v3 0/3] sched: Always check the integrity of the canary Aaron Tomlin
2014-09-11 15:41 ` [PATCH v3 1/3] init/main.c: Give init_task a canary Aaron Tomlin
2014-09-12 7:28 ` Michael Ellerman [this message]
2014-09-11 15:41 ` [PATCH v3 2/3] sched: Add helper for task stack page overrun checking Aaron Tomlin
2014-09-11 15:41 ` [PATCH v3 3/3] sched: BUG when stack end location is over written Aaron Tomlin
2014-09-12 4:06 ` Michael Ellerman
2014-09-12 9:44 ` Aaron Tomlin
2014-09-12 10:58 ` Mike Galbraith
2014-09-15 2:39 ` Michael Ellerman
2014-09-12 6:04 ` Michael Ellerman
2014-09-12 9:50 ` Aaron Tomlin
2014-09-11 15:53 ` [PATCH v3 0/3] sched: Always check the integrity of the canary Peter Zijlstra
2014-09-11 15:59 ` Aaron Tomlin
2014-09-11 16:02 ` David Laight
2014-09-11 17:26 ` Chuck Ebbert
2014-09-12 8:43 ` David Laight
2014-09-11 17:44 ` Aaron Tomlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410506936.17540.7.camel@concordia \
--to=mpe@ellerman.id.au \
--cc=akpm@google.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=atomlin@redhat.com \
--cc=bmr@redhat.com \
--cc=dzickus@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=jcastillo@redhat.com \
--cc=jgh@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=prarit@redhat.com \
--cc=pzijlstr@redhat.com \
--cc=riel@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).