From: Michael Ellerman <mpe@ellerman.id.au>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Paul Mackerras <paulus@samba.org>,
kernel@pengutronix.de, Grant Likely <grant.likely@linaro.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: make of_device_ids const
Date: Fri, 12 Sep 2014 18:34:24 +1000 [thread overview]
Message-ID: <1410510864.17540.11.camel@concordia> (raw)
In-Reply-To: <1410378998-8823-1-git-send-email-u.kleine-koenig@pengutronix.de>
On Wed, 2014-09-10 at 21:56 +0200, Uwe Kleine-König wrote:
> of_device_ids (i.e. compatible strings and the respective data) are not
> supposed to change at runtime. All functions working with of_device_ids
> provided by <linux/of.h> work with const of_device_ids. This allows to
> mark all struct of_device_id const, too.
>
> While touching these line also put the __init annotation at the right
> position where necessary.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> I don't know how arch/powerpc is maintained. So please tell me if I
> should split this patch further.
>
> I manually checked that all const annotations are OK, and the 0day build
> bot didn't find a regression.
Thanks.
We'll take it as-is, it seems to merge cleanly.
We track patches via patchwork, this one is at:
http://patchwork.ozlabs.org/patch/387959/
cheers
prev parent reply other threads:[~2014-09-12 8:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 19:56 [PATCH] powerpc: make of_device_ids const Uwe Kleine-König
2014-09-12 8:34 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410510864.17540.11.camel@concordia \
--to=mpe@ellerman.id.au \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=kernel@pengutronix.de \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=robh+dt@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).