From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id BD0801A00C5 for ; Mon, 22 Sep 2014 16:56:17 +1000 (EST) Message-ID: <1411368977.16867.11.camel@concordia> Subject: Re: [PATCH 0/2] powerpc: pci-ioda: Neatening From: Michael Ellerman To: Joe Perches Date: Mon, 22 Sep 2014 16:56:17 +1000 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, shangw@linux.vnet.ibm.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sun, 2014-09-21 at 10:55 -0700, Joe Perches wrote: > printk calls should return void > > Joe Perches (2): > powerpc: pci-ioda: Remove unnecessary return value from printk > powerpc: pci-ioda: Use a single function to emit logging messages Patches look good to me. Ben/Gavin, what do these macros give us over pr/dev_debug() ? cheers