From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: linuxppc-dev@ozlabs.org, Takashi Iwai <tiwai@suse.de>,
Linux PCI <linux-pci@vger.kernel.org>,
Brian King <brking@linux.vnet.ibm.com>,
Anton Blanchard <anton@au1.ibm.com>,
Dave Airlie <airlied@linux.ie>,
Yijing Wang <wangyijing@huawei.com>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH 4/4] sounds/hda/radeon: Disable 64-bit DMA on radeon
Date: Thu, 02 Oct 2014 10:15:52 +1000 [thread overview]
Message-ID: <1412208952.4285.239.camel@pasglop> (raw)
In-Reply-To: <1412201282.4285.232.camel@pasglop>
On Thu, 2014-10-02 at 08:08 +1000, Benjamin Herrenschmidt wrote:
> On Wed, 2014-10-01 at 13:58 -0400, Alex Deucher wrote:
> > Patch looks good. Audio DMAs are limited to 40 bits, same as the GPU
> > side. I'm still waiting to hear back on the MSIs for audio, but they
> > probably follow the GPU side, so I expect they should be fixed on Sea
> > Islands as well.
>
> In the audio driver we don't have the "family names", just a list of
> PCI IDs, do you happen to know which ones are unaffected ?
So I tried to be more discriminate but in the end, I had to give up, the
most recent ID we have in the driver seems to be Cap Verde/Pitcairn,
which isn't fixed. So either we are missing IDs or the new cards use the
same ID.
I think the consequences of being over-zealous here are nil on what
matters, ie, x86. AFAIK, x86 always uses 32-bit addresses for MSIs
anyway, so it's unaffected and ARM ... well, I doubt it will be. In
general, I don't think we have a big issue here by just flagging them
all.
I'll send an updated series with just the flag name changed as suggested
by Alex and the DMA bits updated as suggested by Takashi.
Cheers,
Ben.
next prev parent reply other threads:[~2014-10-02 0:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 2:09 [PATCH 4/4] sounds/hda/radeon: Disable 64-bit DMA on radeon Benjamin Herrenschmidt
2014-10-01 7:38 ` Takashi Iwai
2014-10-01 7:41 ` Benjamin Herrenschmidt
2014-10-01 7:48 ` Benjamin Herrenschmidt
2014-10-01 8:09 ` Takashi Iwai
2014-10-01 8:30 ` Takashi Iwai
2014-10-01 17:58 ` Alex Deucher
2014-10-01 22:08 ` Benjamin Herrenschmidt
2014-10-02 0:15 ` Benjamin Herrenschmidt [this message]
2014-10-02 1:19 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412208952.4285.239.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=airlied@linux.ie \
--cc=alexdeucher@gmail.com \
--cc=anton@au1.ibm.com \
--cc=bhelgaas@google.com \
--cc=brking@linux.vnet.ibm.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=tiwai@suse.de \
--cc=wangyijing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).