* [PATCH 1/3] powerpc: Don't build powernv for other platform defconfigs
@ 2014-09-24 5:57 Michael Ellerman
2014-09-24 5:57 ` [PATCH 2/3] powerpc: Enable CONFIG_CRASH_DUMP=y for ppc64_defconfig Michael Ellerman
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Michael Ellerman @ 2014-09-24 5:57 UTC (permalink / raw)
To: linuxppc-dev
Because powernv arrived after these other platforms, the defconfigs
didn't have PPC_POWERNV disabled, and being default y it gets turned on.
If we're going to bother having defconfigs for the specific platforms
then they should only build the code required for those platforms.
The grab bag of everything config is ppc64_defconfig.
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
arch/powerpc/configs/cell_defconfig | 1 +
arch/powerpc/configs/celleb_defconfig | 1 +
arch/powerpc/configs/g5_defconfig | 1 +
arch/powerpc/configs/maple_defconfig | 1 +
arch/powerpc/configs/pasemi_defconfig | 1 +
5 files changed, 5 insertions(+)
diff --git a/arch/powerpc/configs/cell_defconfig b/arch/powerpc/configs/cell_defconfig
index 45fd06cdc3e8..7a7b3c879f96 100644
--- a/arch/powerpc/configs/cell_defconfig
+++ b/arch/powerpc/configs/cell_defconfig
@@ -18,6 +18,7 @@ CONFIG_OPROFILE=m
CONFIG_MODULES=y
CONFIG_MODULE_UNLOAD=y
# CONFIG_BLK_DEV_BSG is not set
+# CONFIG_PPC_POWERNV is not set
# CONFIG_PPC_PSERIES is not set
# CONFIG_PPC_PMAC is not set
CONFIG_PPC_PS3=y
diff --git a/arch/powerpc/configs/celleb_defconfig b/arch/powerpc/configs/celleb_defconfig
index 77d7bf3ca2ac..acccbfde8a50 100644
--- a/arch/powerpc/configs/celleb_defconfig
+++ b/arch/powerpc/configs/celleb_defconfig
@@ -15,6 +15,7 @@ CONFIG_MODULES=y
CONFIG_MODULE_UNLOAD=y
CONFIG_MODVERSIONS=y
CONFIG_MODULE_SRCVERSION_ALL=y
+# CONFIG_PPC_POWERNV is not set
# CONFIG_PPC_PSERIES is not set
# CONFIG_PPC_PMAC is not set
CONFIG_PPC_CELLEB=y
diff --git a/arch/powerpc/configs/g5_defconfig b/arch/powerpc/configs/g5_defconfig
index 7594c5ac6481..6fab06f7f411 100644
--- a/arch/powerpc/configs/g5_defconfig
+++ b/arch/powerpc/configs/g5_defconfig
@@ -16,6 +16,7 @@ CONFIG_MODULES=y
CONFIG_MODULE_UNLOAD=y
CONFIG_MODVERSIONS=y
CONFIG_MODULE_SRCVERSION_ALL=y
+# CONFIG_PPC_POWERNV is not set
# CONFIG_PPC_PSERIES is not set
CONFIG_CPU_FREQ=y
CONFIG_CPU_FREQ_GOV_POWERSAVE=y
diff --git a/arch/powerpc/configs/maple_defconfig b/arch/powerpc/configs/maple_defconfig
index c8b6a9ddb21b..fbd9e4163311 100644
--- a/arch/powerpc/configs/maple_defconfig
+++ b/arch/powerpc/configs/maple_defconfig
@@ -16,6 +16,7 @@ CONFIG_MODULE_UNLOAD=y
CONFIG_MODVERSIONS=y
CONFIG_MODULE_SRCVERSION_ALL=y
# CONFIG_BLK_DEV_BSG is not set
+# CONFIG_PPC_POWERNV is not set
# CONFIG_PPC_PSERIES is not set
# CONFIG_PPC_PMAC is not set
CONFIG_PPC_MAPLE=y
diff --git a/arch/powerpc/configs/pasemi_defconfig b/arch/powerpc/configs/pasemi_defconfig
index e5e7838af008..3e72c8c06a0d 100644
--- a/arch/powerpc/configs/pasemi_defconfig
+++ b/arch/powerpc/configs/pasemi_defconfig
@@ -14,6 +14,7 @@ CONFIG_MODULE_UNLOAD=y
# CONFIG_BLK_DEV_BSG is not set
CONFIG_PARTITION_ADVANCED=y
CONFIG_MAC_PARTITION=y
+# CONFIG_PPC_POWERNV is not set
# CONFIG_PPC_PSERIES is not set
# CONFIG_PPC_PMAC is not set
CONFIG_PPC_PASEMI=y
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 2/3] powerpc: Enable CONFIG_CRASH_DUMP=y for ppc64_defconfig
2014-09-24 5:57 [PATCH 1/3] powerpc: Don't build powernv for other platform defconfigs Michael Ellerman
@ 2014-09-24 5:57 ` Michael Ellerman
2014-09-24 5:57 ` [PATCH 3/3] powerpc/kdump: crash_dump.c needs to include io.h Michael Ellerman
2014-09-24 6:34 ` [PATCH 1/3] powerpc: Don't build powernv for other platform defconfigs Stephen Rothwell
2 siblings, 0 replies; 7+ messages in thread
From: Michael Ellerman @ 2014-09-24 5:57 UTC (permalink / raw)
To: linuxppc-dev
It pulls in more code, including causing us to build a relocatable
kernel, which is good for testing.
The resulting kernel is still usable as a non-crash dump kernel.
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
arch/powerpc/configs/ppc64_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/configs/ppc64_defconfig b/arch/powerpc/configs/ppc64_defconfig
index f6c02f8cdc62..b9b769e4a23e 100644
--- a/arch/powerpc/configs/ppc64_defconfig
+++ b/arch/powerpc/configs/ppc64_defconfig
@@ -50,6 +50,7 @@ CONFIG_HZ_100=y
CONFIG_BINFMT_MISC=m
CONFIG_PPC_TRANSACTIONAL_MEM=y
CONFIG_KEXEC=y
+CONFIG_CRASH_DUMP=y
CONFIG_IRQ_ALL_CPUS=y
CONFIG_MEMORY_HOTREMOVE=y
CONFIG_SCHED_SMT=y
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/3] powerpc/kdump: crash_dump.c needs to include io.h
2014-09-24 5:57 [PATCH 1/3] powerpc: Don't build powernv for other platform defconfigs Michael Ellerman
2014-09-24 5:57 ` [PATCH 2/3] powerpc: Enable CONFIG_CRASH_DUMP=y for ppc64_defconfig Michael Ellerman
@ 2014-09-24 5:57 ` Michael Ellerman
2014-09-24 6:36 ` Stephen Rothwell
2014-09-24 6:34 ` [PATCH 1/3] powerpc: Don't build powernv for other platform defconfigs Stephen Rothwell
2 siblings, 1 reply; 7+ messages in thread
From: Michael Ellerman @ 2014-09-24 5:57 UTC (permalink / raw)
To: linuxppc-dev
For __ioremap().
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
arch/powerpc/kernel/crash_dump.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/kernel/crash_dump.c b/arch/powerpc/kernel/crash_dump.c
index 7a13f378ca2c..c78e6dac4d7d 100644
--- a/arch/powerpc/kernel/crash_dump.c
+++ b/arch/powerpc/kernel/crash_dump.c
@@ -13,6 +13,7 @@
#include <linux/crash_dump.h>
#include <linux/bootmem.h>
+#include <linux/io.h>
#include <linux/memblock.h>
#include <asm/code-patching.h>
#include <asm/kdump.h>
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 3/3] powerpc/kdump: crash_dump.c needs to include io.h
2014-09-24 5:57 ` [PATCH 3/3] powerpc/kdump: crash_dump.c needs to include io.h Michael Ellerman
@ 2014-09-24 6:36 ` Stephen Rothwell
2014-10-03 8:04 ` Michael Ellerman
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2014-09-24 6:36 UTC (permalink / raw)
To: Michael Ellerman; +Cc: linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 340 bytes --]
Hi Michael,
On Wed, 24 Sep 2014 15:57:12 +1000 Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> For __ioremap().
So does that mean that you really want this patch before 2/3 so that you
don't introduce an unnecessary bisection breakage in ppc64_defconfig?
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 3/3] powerpc/kdump: crash_dump.c needs to include io.h
2014-09-24 6:36 ` Stephen Rothwell
@ 2014-10-03 8:04 ` Michael Ellerman
0 siblings, 0 replies; 7+ messages in thread
From: Michael Ellerman @ 2014-10-03 8:04 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linuxppc-dev
On Wed, 2014-09-24 at 16:36 +1000, Stephen Rothwell wrote:
> Hi Michael,
>
> On Wed, 24 Sep 2014 15:57:12 +1000 Michael Ellerman <mpe@ellerman.id.au> wrote:
> >
> > For __ioremap().
>
> So does that mean that you really want this patch before 2/3 so that you
> don't introduce an unnecessary bisection breakage in ppc64_defconfig?
Yeah I guess it does.
cheers
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] powerpc: Don't build powernv for other platform defconfigs
2014-09-24 5:57 [PATCH 1/3] powerpc: Don't build powernv for other platform defconfigs Michael Ellerman
2014-09-24 5:57 ` [PATCH 2/3] powerpc: Enable CONFIG_CRASH_DUMP=y for ppc64_defconfig Michael Ellerman
2014-09-24 5:57 ` [PATCH 3/3] powerpc/kdump: crash_dump.c needs to include io.h Michael Ellerman
@ 2014-09-24 6:34 ` Stephen Rothwell
2014-10-03 8:04 ` Michael Ellerman
2 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2014-09-24 6:34 UTC (permalink / raw)
To: Michael Ellerman; +Cc: linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 394 bytes --]
Hi Michael,
On Wed, 24 Sep 2014 15:57:10 +1000 Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> Because powernv arrived after these other platforms, the defconfigs
> didn't have PPC_POWERNV disabled, and being default y it gets turned on.
Well, that raises the question of why PPC_POWERNV is default y at all?
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] powerpc: Don't build powernv for other platform defconfigs
2014-09-24 6:34 ` [PATCH 1/3] powerpc: Don't build powernv for other platform defconfigs Stephen Rothwell
@ 2014-10-03 8:04 ` Michael Ellerman
0 siblings, 0 replies; 7+ messages in thread
From: Michael Ellerman @ 2014-10-03 8:04 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linuxppc-dev
On Wed, 2014-09-24 at 16:34 +1000, Stephen Rothwell wrote:
> Hi Michael,
>
> On Wed, 24 Sep 2014 15:57:10 +1000 Michael Ellerman <mpe@ellerman.id.au> wrote:
> >
> > Because powernv arrived after these other platforms, the defconfigs
> > didn't have PPC_POWERNV disabled, and being default y it gets turned on.
>
> Well, that raises the question of why PPC_POWERNV is default y at all?
I think that makes sense. With a bare config, you want all the platforms that
can be built to build, so that the kernel you produce is able to boot on as
many things as possible.
If you want a stripped down config for a particular target then we have
defconfigs that do that.
cheers
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-10-03 8:05 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-24 5:57 [PATCH 1/3] powerpc: Don't build powernv for other platform defconfigs Michael Ellerman
2014-09-24 5:57 ` [PATCH 2/3] powerpc: Enable CONFIG_CRASH_DUMP=y for ppc64_defconfig Michael Ellerman
2014-09-24 5:57 ` [PATCH 3/3] powerpc/kdump: crash_dump.c needs to include io.h Michael Ellerman
2014-09-24 6:36 ` Stephen Rothwell
2014-10-03 8:04 ` Michael Ellerman
2014-09-24 6:34 ` [PATCH 1/3] powerpc: Don't build powernv for other platform defconfigs Stephen Rothwell
2014-10-03 8:04 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).