From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: linuxppc-dev@ozlabs.org, Dave Airlie <airlied@linux.ie>,
Linux PCI <linux-pci@vger.kernel.org>,
Anton Blanchard <anton@au1.ibm.com>,
Brian King <brking@linux.vnet.ibm.com>,
Yijing Wang <wangyijing@huawei.com>, Takashi Iwai <tiwai@suse.de>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH v3 4/7] sound/radeon: Add quirk for broken 64-bit MSI
Date: Wed, 08 Oct 2014 10:49:50 +1100 [thread overview]
Message-ID: <1412725790.30859.214.camel@pasglop> (raw)
In-Reply-To: <CADnq5_NFt8neiOAg896d3-DbAn0rnrE7iXaTFmkNGSg-J9oSkA@mail.gmail.com>
On Tue, 2014-10-07 at 19:47 -0400, Alex Deucher wrote:
> > While recent ASICs have that problem fixed, they don't seem to
> > be listed in the PCI IDs of the current driver, so let's quirk all
> > the ATI HDMI for now. The consequences are nil on x86 anyway.
> >
> > Signed-off-by: Alex Deucher <alexdeucher@gmail.com>
> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > CC: <stable@vger.kernel.org>
>
> Further discussion with the hw teams have revealed that this is still
> an issue on newer asics so I think your original patch is correct
> after all. Just disable 64 bit MSIs on all AMD audio PCI ids.
Ok. You confirm that this is however good on newer video side right ?
Also, is there a known issue that if MSI were once enabled, the chip
still shoots them even if we disable them in config space ?
When testing my new patch set, I was trying to test the error path
when the arch does *not* honor the limitation. The error went back
up to the driver as far as I can tell (ie, pci_enable_msi() failed),
but the system still got into error state as if the card had tried
to shoot an MSI to the wrong address.
(I suspect the graphics side)
Cheers,
Ben.
next prev parent reply other threads:[~2014-10-07 23:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 4:38 [PATCH v3 4/7] sound/radeon: Add quirk for broken 64-bit MSI Benjamin Herrenschmidt
2014-10-07 23:47 ` Alex Deucher
2014-10-07 23:49 ` Benjamin Herrenschmidt [this message]
2014-10-08 0:18 ` Alex Deucher
2014-10-08 5:28 ` Benjamin Herrenschmidt
2014-10-08 6:23 ` Alex Deucher
2014-10-08 6:59 ` Takashi Iwai
2014-10-13 20:11 ` Benjamin Herrenschmidt
2014-10-13 20:39 ` Alex Deucher
2014-10-13 20:46 ` Bjorn Helgaas
2014-10-15 22:19 ` Bjorn Helgaas
2014-10-15 22:55 ` Benjamin Herrenschmidt
2014-11-11 21:12 ` Bjorn Helgaas
2014-11-12 2:23 ` Michael Ellerman
2014-11-12 4:06 ` Benjamin Herrenschmidt
2014-11-12 4:09 ` Bjorn Helgaas
2014-11-13 5:19 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412725790.30859.214.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=airlied@linux.ie \
--cc=alexdeucher@gmail.com \
--cc=anton@au1.ibm.com \
--cc=bhelgaas@google.com \
--cc=brking@linux.vnet.ibm.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=tiwai@suse.de \
--cc=wangyijing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).